From: Lee Jones <lee@kernel.org>
To: Maarten Zanders <maarten.zanders@mind.be>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/2] leds: lp55xx: configure internal charge pump
Date: Thu, 27 Apr 2023 16:21:53 +0100 [thread overview]
Message-ID: <20230427152153.GY50521@google.com> (raw)
In-Reply-To: <20230421075305.37597-3-maarten.zanders@mind.be>
On Fri, 21 Apr 2023, Maarten Zanders wrote:
> The LP55xx range of devices have an internal charge pump which
> can (automatically) increase the output voltage towards the
> LED's, boosting the output voltage to 4.5V.
>
> Implement this option from the devicetree. When the setting
> is not present it will operate in automatic mode as before.
>
> Tested on LP55231. Datasheet analysis shows that LP5521, LP5523
> and LP8501 are identical in topology and are modified in the
> same way.
>
> Signed-off-by: Maarten Zanders <maarten.zanders@mind.be>
> ---
>
> Notes:
> v1: implement as bool to disable charge pump
> v2: rewrite to use string configuration, supporting all modes
> v3: simplification by replacing string from DTS by constant
> v4: added notes
> v5: property type to u32
> v6: cleanup parsing of DT paramter
> v7: formatting
>
> drivers/leds/leds-lp5521.c | 11 +++++------
> drivers/leds/leds-lp5523.c | 14 +++++++++-----
> drivers/leds/leds-lp55xx-common.c | 9 +++++++++
> drivers/leds/leds-lp8501.c | 8 +++++---
> include/linux/platform_data/leds-lp55xx.h | 3 +++
> 5 files changed, 31 insertions(+), 14 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-04-27 15:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 7:53 [PATCH v8 0/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-04-21 7:53 ` [PATCH v8 1/2] dt-bindings: leds-lp55xx: add ti,charge-pump-mode Maarten Zanders
2023-04-27 15:21 ` Lee Jones
2023-04-21 7:53 ` [PATCH v8 2/2] leds: lp55xx: configure internal charge pump Maarten Zanders
2023-04-27 15:21 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427152153.GY50521@google.com \
--to=lee@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maarten.zanders@mind.be \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.