From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4712C77B61 for ; Thu, 27 Apr 2023 17:17:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244315AbjD0RRv (ORCPT ); Thu, 27 Apr 2023 13:17:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244326AbjD0RRi (ORCPT ); Thu, 27 Apr 2023 13:17:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AF1A59F1; Thu, 27 Apr 2023 10:17:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E92263DCE; Thu, 27 Apr 2023 17:17:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E6F5C433EF; Thu, 27 Apr 2023 17:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682615847; bh=0xWA8A0zUyKpHuYdXUaZ5SCZXM9LKzezszDIXzsri/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EFLNI5Y8xqGLUGpTKLeRHASq6Vz8HG18a76B1ZAevLGlYgFL45sxMgHqW65HWt7Kf V2oGRRSayE9yxw3fDhhT5oy8/BX9egr9j3YWsai/fNpdjnJ10QottK2SQn9CZawxTC vC1O5BXmzfbpSsyeDZamy51tCyvCjyXJiPNhFWDBM1JJap3SxNkV3jBN2DcUUFPk2M drjRHy+Wtk/lUpBPEQ415pY6wkMEbi36h7MysKSBznJgSEdCPcN+bRqUmpFAmKtAzp fFLPuKsM+epJDb1xmW4oN67Cj9HtuNKw7OlHO7IwrDL59b+I9FONeoxC3gltaSc9DV mogPQQ78asJTQ== Date: Thu, 27 Apr 2023 18:17:22 +0100 From: Lee Jones To: Nishanth Menon Cc: Manivannan Sadhasivam , Jacek Anaszewski , Krzysztof Kozlowski , Rob Herring , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra , Manivannan Sadhasivam Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match Message-ID: <20230427171722.GG620451@google.com> References: <20230424151437.256073-1-nm@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230424151437.256073-1-nm@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, 24 Apr 2023, Nishanth Menon wrote: > Commit e91a4d5deb96 ("dt-bindings: leds: Document commonly used > LED triggers") introduced a enum match for cpu, while a pattern > '^cpu[0-9]*$' already exists. > > This causes linux,default-trigger = "cpu" to have more than one match > and generates the following dtbs_check warning: > > arch/arm64/boot/dts/ti/k3-j721e-beagleboneai64.dtb: leds: led-2:linux,default-trigger: More than one condition true in oneOf schema: > {'$ref': '/schemas/types.yaml#/definitions/string', > 'oneOf': [{'items': [{'enum': ['backlight', > 'default-on', > 'heartbeat', > 'disk-activity', > 'disk-read', > 'disk-write', > 'timer', > 'pattern', > 'audio-micmute', > 'audio-mute', > 'bluetooth-power', > 'cpu', > 'flash', > 'kbd-capslock', > 'mtd', > 'nand-disk', > 'none', > 'torch', > 'usb-gadget', > 'usb-host', > 'usbport']}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^cpu[0-9]*$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^hci[0-9]+-power$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^mmc[0-9]+$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}, > {'items': [{'pattern': '^phy[0-9]+tx$'}], > 'maxItems': 1, > 'minItems': 1, > 'type': 'array'}]} > > Drop the explicit match against cpu since the pattern match already > covers the same. > > Fixes: e91a4d5deb96 ("dt-bindings: leds: Document commonly used LED triggers") > Cc: Manivannan Sadhasivam > Signed-off-by: Nishanth Menon > --- > Documentation/devicetree/bindings/leds/common.yaml | 2 -- > 1 file changed, 2 deletions(-) Applied, thanks -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B9BBC77B61 for ; Thu, 27 Apr 2023 17:18:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=F57Xi/6rjYFauN0xsDA/bpAuBWjIbJ9xc4rfdowwE9c=; b=MBltpiQ0QnSfal D6eFc9WNs8II9IuASZXT/H8jXMD0LDibyk/qfJX1DBcy6frEGOYBxMiZQITrtx7IQfW+nSRzOnpk3 YUaVYuELdpOX24lffcw47LHV3HXY3IpQvtiVBgGhMqZxkQ2vQHspm/uvhed1xCn4Y7x8ghwy+OO3n KkOQvtg84CC4i5Xw3Se0DcBk2OReQukdH7BUQxw3eSZ7riarbg/m134I4K8GtGHqTZCtNJcIxk6Fw zLbDOaw0aW6NIbLRuV6lp4d082PVW5DR0I46MgveGIADnGxmhCuXcH0/eMOeNUDOYbFQ2Epptrg85 zvw22tMKgiJF2imAW40g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1ps5FL-0075Gu-2w; Thu, 27 Apr 2023 17:17:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1ps5FI-0075Fl-33 for linux-arm-kernel@lists.infradead.org; Thu, 27 Apr 2023 17:17:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1215163E82; Thu, 27 Apr 2023 17:17:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4E6F5C433EF; Thu, 27 Apr 2023 17:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682615847; bh=0xWA8A0zUyKpHuYdXUaZ5SCZXM9LKzezszDIXzsri/I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EFLNI5Y8xqGLUGpTKLeRHASq6Vz8HG18a76B1ZAevLGlYgFL45sxMgHqW65HWt7Kf V2oGRRSayE9yxw3fDhhT5oy8/BX9egr9j3YWsai/fNpdjnJ10QottK2SQn9CZawxTC vC1O5BXmzfbpSsyeDZamy51tCyvCjyXJiPNhFWDBM1JJap3SxNkV3jBN2DcUUFPk2M drjRHy+Wtk/lUpBPEQ415pY6wkMEbi36h7MysKSBznJgSEdCPcN+bRqUmpFAmKtAzp fFLPuKsM+epJDb1xmW4oN67Cj9HtuNKw7OlHO7IwrDL59b+I9FONeoxC3gltaSc9DV mogPQQ78asJTQ== Date: Thu, 27 Apr 2023 18:17:22 +0100 From: Lee Jones To: Nishanth Menon Cc: Manivannan Sadhasivam , Jacek Anaszewski , Krzysztof Kozlowski , Rob Herring , Pavel Machek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vignesh Raghavendra , Manivannan Sadhasivam Subject: Re: [PATCH] dt-bindings: leds: Drop redundant cpus enum match Message-ID: <20230427171722.GG620451@google.com> References: <20230424151437.256073-1-nm@ti.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230424151437.256073-1-nm@ti.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230427_101729_078519_A3162E08 X-CRM114-Status: GOOD ( 12.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyNCBBcHIgMjAyMywgTmlzaGFudGggTWVub24gd3JvdGU6Cgo+IENvbW1pdCBlOTFh NGQ1ZGViOTYgKCJkdC1iaW5kaW5nczogbGVkczogRG9jdW1lbnQgY29tbW9ubHkgdXNlZAo+IExF RCB0cmlnZ2VycyIpIGludHJvZHVjZWQgYSBlbnVtIG1hdGNoIGZvciBjcHUsIHdoaWxlIGEgcGF0 dGVybgo+ICdeY3B1WzAtOV0qJCcgYWxyZWFkeSBleGlzdHMuCj4gCj4gVGhpcyBjYXVzZXMgbGlu dXgsZGVmYXVsdC10cmlnZ2VyID0gImNwdSIgdG8gaGF2ZSBtb3JlIHRoYW4gb25lIG1hdGNoCj4g YW5kIGdlbmVyYXRlcyB0aGUgZm9sbG93aW5nIGR0YnNfY2hlY2sgd2FybmluZzoKPiAKPiBhcmNo L2FybTY0L2Jvb3QvZHRzL3RpL2szLWo3MjFlLWJlYWdsZWJvbmVhaTY0LmR0YjogbGVkczogbGVk LTI6bGludXgsZGVmYXVsdC10cmlnZ2VyOiBNb3JlIHRoYW4gb25lIGNvbmRpdGlvbiB0cnVlIGlu IG9uZU9mIHNjaGVtYToKPiAJeyckcmVmJzogJy9zY2hlbWFzL3R5cGVzLnlhbWwjL2RlZmluaXRp b25zL3N0cmluZycsCj4gCSAnb25lT2YnOiBbeydpdGVtcyc6IFt7J2VudW0nOiBbJ2JhY2tsaWdo dCcsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2RlZmF1bHQtb24nLAo+IAkg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdoZWFydGJlYXQnLAo+IAkgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdkaXNrLWFjdGl2aXR5JywKPiAJICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnZGlzay1yZWFkJywKPiAJICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnZGlzay13cml0ZScsCj4gCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg J3RpbWVyJywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAncGF0dGVybicsCj4g CSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ2F1ZGlvLW1pY211dGUnLAo+IAkgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICdhdWRpby1tdXRlJywKPiAJICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAnYmx1ZXRvb3RoLXBvd2VyJywKPiAJICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAnY3B1JywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAnZmxhc2gnLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdrYmQtY2Fwc2xv Y2snLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICdtdGQnLAo+IAkgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICduYW5kLWRpc2snLAo+IAkgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICdub25lJywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAndG9yY2gnLAo+IAkgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd1c2ItZ2FkZ2V0 JywKPiAJICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAndXNiLWhvc3QnLAo+IAkgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICd1c2Jwb3J0J119XSwKPiAJICAgICAgICAgICAg J21heEl0ZW1zJzogMSwKPiAJICAgICAgICAgICAgJ21pbkl0ZW1zJzogMSwKPiAJICAgICAgICAg ICAgJ3R5cGUnOiAnYXJyYXknfSwKPiAJICAgICAgICAgICB7J2l0ZW1zJzogW3sncGF0dGVybic6 ICdeY3B1WzAtOV0qJCd9XSwKPiAJICAgICAgICAgICAgJ21heEl0ZW1zJzogMSwKPiAJICAgICAg ICAgICAgJ21pbkl0ZW1zJzogMSwKPiAJICAgICAgICAgICAgJ3R5cGUnOiAnYXJyYXknfSwKPiAJ ICAgICAgICAgICB7J2l0ZW1zJzogW3sncGF0dGVybic6ICdeaGNpWzAtOV0rLXBvd2VyJCd9XSwK PiAJICAgICAgICAgICAgJ21heEl0ZW1zJzogMSwKPiAJICAgICAgICAgICAgJ21pbkl0ZW1zJzog MSwKPiAJICAgICAgICAgICAgJ3R5cGUnOiAnYXJyYXknfSwKPiAJICAgICAgICAgICB7J2l0ZW1z JzogW3sncGF0dGVybic6ICdebW1jWzAtOV0rJCd9XSwKPiAJICAgICAgICAgICAgJ21heEl0ZW1z JzogMSwKPiAJICAgICAgICAgICAgJ21pbkl0ZW1zJzogMSwKPiAJICAgICAgICAgICAgJ3R5cGUn OiAnYXJyYXknfSwKPiAJICAgICAgICAgICB7J2l0ZW1zJzogW3sncGF0dGVybic6ICdecGh5WzAt OV0rdHgkJ31dLAo+IAkgICAgICAgICAgICAnbWF4SXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAn bWluSXRlbXMnOiAxLAo+IAkgICAgICAgICAgICAndHlwZSc6ICdhcnJheSd9XX0KPiAKPiBEcm9w IHRoZSBleHBsaWNpdCBtYXRjaCBhZ2FpbnN0IGNwdSBzaW5jZSB0aGUgcGF0dGVybiBtYXRjaCBh bHJlYWR5Cj4gY292ZXJzIHRoZSBzYW1lLgo+IAo+IEZpeGVzOiBlOTFhNGQ1ZGViOTYgKCJkdC1i aW5kaW5nczogbGVkczogRG9jdW1lbnQgY29tbW9ubHkgdXNlZCBMRUQgdHJpZ2dlcnMiKQo+IENj OiBNYW5pdmFubmFuIFNhZGhhc2l2YW0gPG1hbml2YW5uYW4uc2FkaGFzaXZhbUBsaW5hcm8ub3Jn Pgo+IFNpZ25lZC1vZmYtYnk6IE5pc2hhbnRoIE1lbm9uIDxubUB0aS5jb20+Cj4gLS0tCj4gIERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9sZWRzL2NvbW1vbi55YW1sIHwgMiAtLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkKCkFwcGxpZWQsIHRoYW5rcwoKLS0gCkxl ZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=