From: Petr Vorel <pvorel@suse.cz>
To: Edward Liaw <edliaw@google.com>
Cc: kernel-team@android.com, rpalethorpe@suse.com, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v1 1/2] fcntl{34, 36}: Only use fcntl64 with 32bit abi
Date: Thu, 27 Apr 2023 19:47:36 +0200 [thread overview]
Message-ID: <20230427174736.GA3142007@pevik> (raw)
In-Reply-To: <CAG4es9VFfgMQZWO+YLW3YFKTfpDdT2RybHJ5o9TtJr-0dUeF9w@mail.gmail.com>
> On Thu, Apr 27, 2023 at 2:35 AM Petr Vorel <pvorel@suse.cz> wrote:
> > Hi Edward,
> > > Fixes: 7643115aaacb ("fcntl{34,36}: Always use 64-bit flock struct to avoid EINVAL")
> > > On Android arm64, tst_kernel_bits is disregarding the abi, so compiling
> > What exactly do you mean by "disregarding the abi"? Why is aarch64 different?
> In x86/entry/syscalls/syscall_32.tbl, a 64bit kernel uses
> compat_sys_fcntl64, which is flock64 compatible; whereas in
> arm/tools/syscall.tbl it uses sys_fcntl, which is not flock64
> compatible.
Thanks for info! Also thanks you updated the description in v2.
Kind regards,
Petr
> > Once we removed tst_kernel_bits(), there is no need to pass "fcntl64" as %s,
> > thus it should be:
> > "fcntl64(%d, %s, { %d, %d, %"PRId64", %"PRId64", %d })",
> > fd, cmd_name, l64.l_type, l64.l_whence, l64.l_start, l64.l_len,
> > l64.l_pid);
> > Otherwise LGTM.
> Sounds good, I will send a v2.
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-04-27 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 0:29 [LTP] [PATCH v1 0/2] fcntl{34,36}: Fixes for Android arm64 Edward Liaw via ltp
2023-04-27 0:29 ` [LTP] [PATCH v1 1/2] fcntl{34, 36}: Only use fcntl64 with 32bit abi Edward Liaw via ltp
2023-04-27 9:33 ` Richard Palethorpe
2023-04-27 16:57 ` Edward Liaw via ltp
2023-04-27 9:35 ` Petr Vorel
2023-04-27 17:24 ` Edward Liaw via ltp
2023-04-27 17:47 ` Petr Vorel [this message]
2023-04-27 0:29 ` [LTP] [PATCH v1 2/2] fcntl{34, 36}: Use arch dependent types for my_flock64 Edward Liaw via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230427174736.GA3142007@pevik \
--to=pvorel@suse.cz \
--cc=edliaw@google.com \
--cc=kernel-team@android.com \
--cc=ltp@lists.linux.it \
--cc=rpalethorpe@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.