All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: Conor Dooley <conor.dooley@microchip.com>, stable@vger.kernel.org
Subject: Re: [PATCH 6.2.11 3/3] riscv: No need to relocate the dtb as it lies in the fixmap region
Date: Thu, 27 Apr 2023 11:53:31 +0200	[thread overview]
Message-ID: <2023042756-aggregate-distance-1d1a@gregkh> (raw)
In-Reply-To: <20230424150354.195572-4-alexghiti@rivosinc.com>

On Mon, Apr 24, 2023 at 05:03:54PM +0200, Alexandre Ghiti wrote:
> commit 1b50f956c8fe9082bdee4a9cfd798149c52f7043 upstream.
> 
> We used to access the dtb via its linear mapping address but now that the
> dtb early mapping was moved in the fixmap region, we can keep using this
> address since it is present in swapper_pg_dir, and remove the dtb
> relocation.
> 
> Note that the relocation was wrong anyway since early_memremap() is
> restricted to 256K whereas the maximum fdt size is 2MB.
> 
> Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
> Cc: <stable@vger.kernel.org> # 6.2.x

You dropped everyone else's s-o-b for this patch, why?

Please don't do that.  Please fix up all of these series and resend.

thanks,

greg k-h

  reply	other threads:[~2023-04-27  9:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-24 15:03 [PATCH 6.2.11 0/3] Fixes for dtb mapping Alexandre Ghiti
2023-04-24 15:03 ` [PATCH 6.2.11 1/3] riscv: Move early dtb mapping into the fixmap region Alexandre Ghiti
2023-04-24 15:03 ` [PATCH 6.2.11 2/3] riscv: Do not set initial_boot_params to the linear address of the dtb Alexandre Ghiti
2023-04-24 15:03 ` [PATCH 6.2.11 3/3] riscv: No need to relocate the dtb as it lies in the fixmap region Alexandre Ghiti
2023-04-27  9:53   ` Greg KH [this message]
2023-04-27 15:23     ` Alexandre Ghiti
2023-04-28  4:46       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023042756-aggregate-distance-1d1a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=alexghiti@rivosinc.com \
    --cc=conor.dooley@microchip.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.