All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raghu H <raghuhack78@gmail.com>
To: linux-cxl@vger.kernel.org,
	Alison Schofield <alison.schofield@intel.com>,
	raghuhack78@gmail.com, ira.weiny@intel.com, bwidawsk@kernel.org,
	dan.j.williams@intel.com, vishal.l.verma@intel.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc
Date: Fri, 28 Apr 2023 01:22:34 +0000	[thread overview]
Message-ID: <20230428012235.119333-2-raghuhack78@gmail.com> (raw)
In-Reply-To: <20230428012235.119333-1-raghuhack78@gmail.com>

Issue found with checkpatch

A return of errno should be good enough if the memory allocation fails,
the error message here is redundatant as per the coding style, removing it.

Signed-off-by: Raghu H <raghuhack78@gmail.com>
---
 drivers/cxl/core/mbox.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
index f2addb457172..11ea145b4b1f 100644
--- a/drivers/cxl/core/mbox.c
+++ b/drivers/cxl/core/mbox.c
@@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev)
 	struct cxl_dev_state *cxlds;
 
 	cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL);
-	if (!cxlds) {
-		dev_err(dev, "No memory available\n");
+	if (!cxlds)
 		return ERR_PTR(-ENOMEM);
-	}
 
 	mutex_init(&cxlds->mbox_mutex);
 	mutex_init(&cxlds->event.log_lock);
-- 
2.39.2


  reply	other threads:[~2023-04-28  1:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28  1:22 [PATCH v2 0/2] Fixing check patch styling issues Raghu H
2023-04-28  1:22 ` Raghu H [this message]
2023-05-01 14:52   ` [PATCH v2 1/2] cxl/mbox: Remove redundant dev_err() after failed mem alloc Dave Jiang
2023-05-03 17:57   ` Verma, Vishal L
2023-05-03 18:32   ` Fabio M. De Francesco
2023-05-03 22:03     ` Alison Schofield
2023-05-04 10:46       ` Fabio M. De Francesco
2023-05-04 15:23         ` Alison Schofield
2023-05-08  4:12           ` RAGHU H
2023-05-03 22:36   ` Davidlohr Bueso
2023-05-04  2:26     ` Alison Schofield
2023-04-28  1:22 ` [PATCH v2 2/2] cxl/region: Remove else after return statement Raghu H
2023-05-01 14:53   ` Dave Jiang
2023-05-03 17:58     ` Verma, Vishal L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230428012235.119333-2-raghuhack78@gmail.com \
    --to=raghuhack78@gmail.com \
    --cc=alison.schofield@intel.com \
    --cc=bwidawsk@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.