Re: [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support

From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: linux-i3c@lists.infradead.org,
	Matt Johnston <matt@codeconstruct.com.au>,
	Vitor Soares <ivitro@gmail.com>,
	Jack Chen <zenghuchen@google.com>,
	Billy Tsai <billy_tsai@aspeedtech.com>,
	Dylan Hung <dylan_hung@aspeedtech.com>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support
Date: Fri, 28 Apr 2023 08:51:37 +0200	[thread overview]
Message-ID: <20230428065137097609fa@mail.local> (raw)
In-Reply-To: <cda6874790ced41cbbeca5b5dbfe39be869fb2d4.camel@codeconstruct.com.au>

On 28/04/2023 08:01:39+0800, Jeremy Kerr wrote:
> Hi Aledandre,
> 
> > I'm sorry about the late reply, I've been super busy this month. I'm
> > happy to take this series but it doesn't apply on top of v3 of your
> > other series. I guess this will have to wait for the next release.
> 
> That was originally based on v3 - I think you've applied v2 of the
> ast2600 series. 
> 
> In:
> 
>  https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git/commit/?id=7dcbb33d3b2b8bd903d3157fc7249a4cb4f6820d
> 
> your linux-i3c tree has the v2 dw struct, with:
> 
> +	/* platform-specific data */
> +	const struct dw_i3c_platform_ops *platform_ops;
> +	void *platform_data;
> +};
> 
> (platform_data was removed in v3).
> 
> The Link: tag is correct though.

Indeed, I fixed that but this wasn't the issue. Patch 5/5 doesn't apply.
If you look at the context, it has "struct ast2600_i3c_platform_data {"
which is "struct ast2600_i3c {" in your v3. Also the chunk in
ast2600_i3c_probe() can't apply.

I fixed it up and pushed, please check.

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c