From: Thomas Devoogdt <thomas@devoogdt.com>
To: buildroot@buildroot.org
Cc: Joseph Kogut <joseph.kogut@gmail.com>,
Thomas Devoogdt <thomas@devoogdt.com>,
Daniel Lang <d.lang@abatec.at>,
Thomas Devoogdt <thomas.devoogdt@barco.com>,
James Knight <james.knight@collins.com>,
Adrian Perez de Castro <aperez@igalia.com>,
Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory
Date: Fri, 28 Apr 2023 09:59:20 +0200 [thread overview]
Message-ID: <20230428075920.3750005-5-thomas@devoogdt.com> (raw)
In-Reply-To: <20230428075920.3750005-1-thomas@devoogdt.com>
If both, hicolor-icon-theme (selected by libgtk3-demo) and
adwaita-icon-theme is not selected, then the /usr/share/icons
folder is empty, causing find to fail.
Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Tested-by: Adrian Perez de Castro <aperez@igalia.com>
---
v5:
- Fixed indentation.
- Grouped patches.
v6: no change
v7: no change
---
package/libgtk3/libgtk3.mk | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/package/libgtk3/libgtk3.mk b/package/libgtk3/libgtk3.mk
index bdd54dcdc8..eac569fd41 100644
--- a/package/libgtk3/libgtk3.mk
+++ b/package/libgtk3/libgtk3.mk
@@ -146,8 +146,9 @@ endef
# Create icon-theme.cache for each of the icon directories/themes
# It's not strictly necessary but speeds up lookups
define LIBGTK3_UPDATE_ICON_CACHE
- find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
- -exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
+ [ ! -d $(TARGET_DIR)/usr/share/icons ] || \
+ find $(TARGET_DIR)/usr/share/icons -maxdepth 1 -mindepth 1 -type d \
+ -exec $(HOST_DIR)/bin/gtk-update-icon-cache {} \;
endef
LIBGTK3_TARGET_FINALIZE_HOOKS += LIBGTK3_UPDATE_ICON_CACHE
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-04-28 8:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 7:59 [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Thomas Devoogdt
2023-04-28 7:59 ` [Buildroot] [PATCH v7 2/5] package/at-spi2-atk: remove package Thomas Devoogdt
2023-05-05 11:56 ` Adrian Perez de Castro
2023-04-28 7:59 ` [Buildroot] [PATCH v7 3/5] package/atk: " Thomas Devoogdt
2023-05-05 11:56 ` Adrian Perez de Castro
2023-04-28 7:59 ` [Buildroot] [PATCH v7 4/5] package/libgtk3: re-enable atk-bridge Thomas Devoogdt
2023-05-05 11:57 ` Adrian Perez de Castro
2023-04-28 7:59 ` Thomas Devoogdt [this message]
2023-05-05 11:57 ` [Buildroot] [PATCH v7 5/5] package/libgtk3: fix update-icon-cache on empty directory Adrian Perez de Castro
2023-05-05 11:56 ` [Buildroot] [PATCH v7 1/5] package/at-spi2-core: bump to version 2.48.0 Adrian Perez de Castro
2023-05-05 11:58 ` Adrian Perez de Castro
2023-05-08 11:35 ` Yann E. MORIN
2023-05-08 14:52 ` Thomas Devoogdt
2023-05-08 16:05 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428075920.3750005-5-thomas@devoogdt.com \
--to=thomas@devoogdt.com \
--cc=aperez@igalia.com \
--cc=buildroot@buildroot.org \
--cc=d.lang@abatec.at \
--cc=fontaine.fabrice@gmail.com \
--cc=james.knight@collins.com \
--cc=joseph.kogut@gmail.com \
--cc=thomas.devoogdt@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.