From: kernel test robot <lkp@intel.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [djwong-xfs:inodegc-fixes-6.4 6/8] fs/xfs/xfs_icache.c:1859:13: error: no member named 'cpu' in 'struct xfs_inodegc'
Date: Fri, 28 Apr 2023 09:26:32 +0800 [thread overview]
Message-ID: <202304280906.eIEx70UE-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git inodegc-fixes-6.4
head: e97bcb3a53526411603a2fb17dfca3b311ccd986
commit: baa0f3f3405029259068bcbdbbdc71785f105691 [6/8] xfs: check that per-cpu inodegc workers actually run on that cpu
config: arm64-randconfig-r001-20230428 (https://download.01.org/0day-ci/archive/20230428/202304280906.eIEx70UE-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 437b7602e4a998220871de78afcb020b9c14a661)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/commit/?id=baa0f3f3405029259068bcbdbbdc71785f105691
git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git fetch --no-tags djwong-xfs inodegc-fixes-6.4
git checkout baa0f3f3405029259068bcbdbbdc71785f105691
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash fs/xfs/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202304280906.eIEx70UE-lkp@intel.com/
All errors (new ones prefixed by >>):
>> fs/xfs/xfs_icache.c:1859:13: error: no member named 'cpu' in 'struct xfs_inodegc'
ASSERT(gc->cpu == smp_processor_id());
~~ ^
fs/xfs/xfs_linux.h:215:10: note: expanded from macro 'ASSERT'
(likely(expr) ? (void)0 : asswarn(NULL, #expr, __FILE__, __LINE__))
^~~~
include/linux/compiler.h:45:39: note: expanded from macro 'likely'
# define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
^
include/linux/compiler.h:33:34: note: expanded from macro '__branch_check__'
______r = __builtin_expect(!!(x), expect); \
^
>> fs/xfs/xfs_icache.c:1859:13: error: no member named 'cpu' in 'struct xfs_inodegc'
ASSERT(gc->cpu == smp_processor_id());
~~ ^
fs/xfs/xfs_linux.h:215:10: note: expanded from macro 'ASSERT'
(likely(expr) ? (void)0 : asswarn(NULL, #expr, __FILE__, __LINE__))
^~~~
include/linux/compiler.h:45:66: note: expanded from macro 'likely'
# define likely(x) (__branch_check__(x, 1, __builtin_constant_p(x)))
^
include/linux/compiler.h:35:19: note: expanded from macro '__branch_check__'
expect, is_constant); \
^~~~~~~~~~~
2 errors generated.
vim +1859 fs/xfs/xfs_icache.c
1848
1849 void
1850 xfs_inodegc_worker(
1851 struct work_struct *work)
1852 {
1853 struct xfs_inodegc *gc = container_of(to_delayed_work(work),
1854 struct xfs_inodegc, work);
1855 struct llist_node *node = llist_del_all(&gc->list);
1856 struct xfs_inode *ip, *n;
1857 unsigned int nofs_flag;
1858
> 1859 ASSERT(gc->cpu == smp_processor_id());
1860
1861 WRITE_ONCE(gc->items, 0);
1862
1863 if (!node)
1864 return;
1865
1866 /*
1867 * We can allocate memory here while doing writeback on behalf of
1868 * memory reclaim. To avoid memory allocation deadlocks set the
1869 * task-wide nofs context for the following operations.
1870 */
1871 nofs_flag = memalloc_nofs_save();
1872
1873 ip = llist_entry(node, struct xfs_inode, i_gclist);
1874 trace_xfs_inodegc_worker(ip->i_mount, READ_ONCE(gc->shrinker_hits));
1875
1876 WRITE_ONCE(gc->shrinker_hits, 0);
1877 llist_for_each_entry_safe(ip, n, node, i_gclist) {
1878 xfs_iflags_set(ip, XFS_INACTIVATING);
1879 xfs_inodegc_inactivate(ip);
1880 }
1881
1882 memalloc_nofs_restore(nofs_flag);
1883 }
1884
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-04-28 1:27 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202304280906.eIEx70UE-lkp@intel.com \
--to=lkp@intel.com \
--cc=darrick.wong@oracle.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.