From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Damien Le Moal <damien.lemoal@opensource.wdc.com>,
Ming Lei <ming.lei@redhat.com>
Subject: Re: [PATCH v3 8/9] block: mq-deadline: Handle requeued requests correctly
Date: Mon, 1 May 2023 06:37:40 +0200 [thread overview]
Message-ID: <20230501043740.GC19847@lst.de> (raw)
In-Reply-To: <05a7d0cb-44c9-cb2f-12c2-957123e031d5@acm.org>
On Fri, Apr 28, 2023 at 10:03:45AM -0700, Bart Van Assche wrote:
> Because the blk_rq_zone_no() definition is surrounded with #ifdef
> CONFIG_BLK_DEV_ZONED / #endif. Without the #ifdef the above code would
> trigger a compilation error with CONFIG_BLK_DEV_ZONED=n. I have considered
> to add a definition of blk_rq_zone_no() for CONFIG_BLK_DEV_ZONED=n. I
> prefer not to do this because I think it's better to cause a compiler error
> if blk_rq_zone_no() is used in code that is also used for the
> CONFIG_BLK_DEV_ZONED=n case.
Ok.
next prev parent reply other threads:[~2023-05-01 4:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-24 20:33 [PATCH v3 0/9] mq-deadline: Improve support for zoned block devices Bart Van Assche
2023-04-24 20:33 ` [PATCH v3 1/9] block: Simplify blk_req_needs_zone_write_lock() Bart Van Assche
2023-04-24 20:33 ` [PATCH v3 2/9] block: Micro-optimize blk_req_needs_zone_write_lock() Bart Van Assche
2023-04-28 5:44 ` Christoph Hellwig
2023-04-28 19:46 ` Bart Van Assche
2023-05-01 4:34 ` Christoph Hellwig
2023-04-24 20:33 ` [PATCH v3 3/9] block: Introduce blk_rq_is_seq_zoned_write() Bart Van Assche
2023-04-28 5:45 ` Christoph Hellwig
2023-04-28 19:59 ` Bart Van Assche
2023-04-24 20:33 ` [PATCH v3 4/9] block: mq-deadline: Clean up deadline_check_fifo() Bart Van Assche
2023-04-28 5:46 ` Christoph Hellwig
2023-04-24 20:33 ` [PATCH v3 5/9] block: mq-deadline: Simplify deadline_skip_seq_writes() Bart Van Assche
2023-04-28 5:47 ` Christoph Hellwig
2023-04-24 20:33 ` [PATCH v3 6/9] block: mq-deadline: Improve deadline_skip_seq_writes() Bart Van Assche
2023-04-28 5:48 ` Christoph Hellwig
2023-04-24 20:33 ` [PATCH v3 7/9] block: mq-deadline: Track the dispatch position Bart Van Assche
2023-04-28 5:50 ` Christoph Hellwig
2023-04-28 17:04 ` Bart Van Assche
2023-04-28 20:04 ` Bart Van Assche
2023-05-01 4:35 ` Christoph Hellwig
2023-04-24 20:33 ` [PATCH v3 8/9] block: mq-deadline: Handle requeued requests correctly Bart Van Assche
2023-04-28 5:54 ` Christoph Hellwig
2023-04-28 17:03 ` Bart Van Assche
2023-05-01 4:37 ` Christoph Hellwig [this message]
2023-04-24 20:33 ` [PATCH v3 9/9] block: mq-deadline: Fix handling of at-head zoned writes Bart Van Assche
2023-04-28 5:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230501043740.GC19847@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jaegeuk@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.