From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CF93C77B73 for ; Mon, 1 May 2023 19:11:00 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.103586.1682968253597740243 for ; Mon, 01 May 2023 12:10:53 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id 77A0040C1C; Mon, 1 May 2023 19:10:52 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7U8i-eAk1ICX; Mon, 1 May 2023 19:10:52 +0000 (UTC) Received: from mail.denix.org (pool-100-15-88-116.washdc.fios.verizon.net [100.15.88.116]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 4632640C13; Mon, 1 May 2023 19:10:49 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id 1970816387C; Mon, 1 May 2023 15:10:08 -0400 (EDT) Date: Mon, 1 May 2023 15:10:08 -0400 From: Denys Dmytriyenko To: Ryan Eatmon Cc: Praneeth Bajjuri , Denys Dmytriyenko , meta-arago@lists.yoctoproject.org Subject: Re: [meta-arago][master/kirkstone][PATCH] packagegroup-arago-gst: Disable vpe and ducati plugins Message-ID: <20230501191008.GX9226@denix.org> References: <20230501163915.10612-1-reatmon@ti.com> <20230501165551.GV9226@denix.org> <3c531a0e-7c07-16ce-5fce-084c66cdb5c6@ti.com> <20230501184934.GW9226@denix.org> <696be171-120c-87eb-d987-251a3afb9d8e@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <696be171-120c-87eb-d987-251a3afb9d8e@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 01 May 2023 19:11:00 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/14385 On Mon, May 01, 2023 at 02:08:40PM -0500, Ryan Eatmon wrote: > > > On 5/1/2023 13:49, Denys Dmytriyenko wrote: > >On Mon, May 01, 2023 at 01:39:12PM -0500, Ryan Eatmon wrote: > >> > >> > >>On 5/1/2023 11:55, Denys Dmytriyenko wrote: > >>>On Mon, May 01, 2023 at 11:39:15AM -0500, Ryan Eatmon via lists.yoctoproject.org wrote: > >>>>The code for the plugins uses dma allocation code that we add in with a > >>>>patch. Theoretically we no longer need that code and can use some > >>>>upstreamed dma buffer allocation code. The work to rewrite these > >>>>plugins to support the newer gstreamer versions needs to be scheduled. > >>> > >>>I'm guessing you are missing this in "ltsprep" and other brandings: > >>>https://git.yoctoproject.org/meta-arago/tree/meta-arago-distro/conf/distro/include/branding-core.inc#n15 > >>> > >>>But it is a more broader approach, so maybe surgically disabling individual > >>>components and re-enabling "mmip" machine feature in "core" is better... > >> > >>It's not that I missed it, but evn running ltsprep the recipes were > >>being included and they fail to build. So something else must be > >>going on to make them be included. Let me look into it. > >> > >>I still need to understand why we did not see these build failures > >>in kirkstone-wip. Because these errors are related to the version > >>of gstreamer and the bbappends not being applied. And the only time > >>these tests were turned off was under ltsprep... Odd. > > > >I think you got it in reverse: "mmip" is being completely disabled for default > >"core" builds, but not for "ltsprep" ones, hence you see the breakage there. > > Ahhhh... gotcha... Yes. That is what is missing. I'll remove this > patch and add that to the ltsprep brand file. What about this one: https://patchwork.yoctoproject.org/project/arago/patch/20230429144445.32401-1-reatmon@ti.com/ > >>>>In the meantime, disable using these plugins that cause build errors. > >>>> > >>>>Signed-off-by: Ryan Eatmon > >>>>--- > >>>> .../recipes-core/packagegroups/packagegroup-arago-gst.bb | 4 ++-- > >>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>> > >>>>diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>index e8a639bd..2184ab58 100644 > >>>>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-gst.bb > >>>>@@ -27,8 +27,8 @@ GSTREAMER_DEPS:append:dra7xx = " \ > >>>> " > >>>> GSTREAMER_ACCEL_MM = "" > >>>>-GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>>>-GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >>>>+#GSTREAMER_ACCEL_MM:omap-a15 = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', "gstreamer1.0-plugins-ducati", '', d)}" > >>>>+#GSTREAMER_ACCEL_MM:append:dra7xx = "${@bb.utils.contains('MACHINE_FEATURES', 'mmip', " gstreamer1.0-plugins-vpe", '', d)}" > >>>> RDEPENDS:${PN} = "\ > >>>> ${GSTREAMER_DEPS} \ > >>>>-- > >>>>2.17.1