From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-comment] Re: [PATCH 1/2] admin: Remove dependency on the deprecated register
Date: Tue, 2 May 2023 03:39:42 -0400 [thread overview]
Message-ID: <20230502033812-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230501224430.485139-2-parav@nvidia.com>
On Tue, May 02, 2023 at 01:44:29AM +0300, Parav Pandit wrote:
> 'VF Migration Capable' is already deprecated as per
> PCI base specification 6.0.1 section 9.3.3.2.1.
> It was long ago deprecated which was meant for MR-IOV.
>
> Hence, remove virtio PCI specification to not depend
> on such deprecated bits.
>
> This patch is on top of [1].
>
> [1] https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat.com/T/#t
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
OK you know best I guess. I will drop mentions of VF Migration Capable.
> ---
> admin.tex | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/admin.tex b/admin.tex
> index 2efd4d7..037e2e6 100644
> --- a/admin.tex
> +++ b/admin.tex
> @@ -372,9 +372,8 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> \field{status} set to VIRTIO_ADMIN_STATUS_EINVAL and
> \field{status_qualifier} set to
> VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \drivernormative{\paragraph}{Group administration commands}{Basic Facilities of a Virtio Device / Device groups / Group administration commands}
>
> @@ -423,11 +422,9 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> the driver specify a value for \field{group_member_id}
> between $1$ and \field{NumVFs} inclusive,
> the driver MUST also make sure that as long as any such command
> -is outstanding, \field{VF Migration Capable} is clear and
> -\field{VF Enable} is set;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +is outstanding, is clear and \field{VF Enable} is set;
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues}
>
> --
> 2.26.2
This publicly archived list offers a means to provide input to the
OASIS Virtual I/O Device (VIRTIO) TC.
In order to verify user consent to the Feedback License terms and
to minimize spam in the list archive, subscription is required
before posting.
Subscribe: virtio-comment-subscribe@lists.oasis-open.org
Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org
List help: virtio-comment-help@lists.oasis-open.org
List archive: https://lists.oasis-open.org/archives/virtio-comment/
Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf
List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists
Committee: https://www.oasis-open.org/committees/virtio/
Join OASIS: https://www.oasis-open.org/join/
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Parav Pandit <parav@nvidia.com>
Cc: virtio-dev@lists.oasis-open.org, cohuck@redhat.com,
virtio-comment@lists.oasis-open.org, shahafs@nvidia.com
Subject: [virtio-dev] Re: [PATCH 1/2] admin: Remove dependency on the deprecated register
Date: Tue, 2 May 2023 03:39:42 -0400 [thread overview]
Message-ID: <20230502033812-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230501224430.485139-2-parav@nvidia.com>
On Tue, May 02, 2023 at 01:44:29AM +0300, Parav Pandit wrote:
> 'VF Migration Capable' is already deprecated as per
> PCI base specification 6.0.1 section 9.3.3.2.1.
> It was long ago deprecated which was meant for MR-IOV.
>
> Hence, remove virtio PCI specification to not depend
> on such deprecated bits.
>
> This patch is on top of [1].
>
> [1] https://lore.kernel.org/virtio-comment/cover.1682354275.git.mst@redhat.com/T/#t
>
> Signed-off-by: Parav Pandit <parav@nvidia.com>
OK you know best I guess. I will drop mentions of VF Migration Capable.
> ---
> admin.tex | 13 +++++--------
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/admin.tex b/admin.tex
> index 2efd4d7..037e2e6 100644
> --- a/admin.tex
> +++ b/admin.tex
> @@ -372,9 +372,8 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> \field{status} set to VIRTIO_ADMIN_STATUS_EINVAL and
> \field{status_qualifier} set to
> VIRTIO_ADMIN_STATUS_Q_INVALID_MEMBER;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \drivernormative{\paragraph}{Group administration commands}{Basic Facilities of a Virtio Device / Device groups / Group administration commands}
>
> @@ -423,11 +422,9 @@ \subsection{Group administration commands}\label{sec:Basic Facilities of a Virti
> the driver specify a value for \field{group_member_id}
> between $1$ and \field{NumVFs} inclusive,
> the driver MUST also make sure that as long as any such command
> -is outstanding, \field{VF Migration Capable} is clear and
> -\field{VF Enable} is set;
> -\field{NumVFs}, \field{VF Migration Capable} and
> -\field{VF Enable} refer to registers within the SR-IOV Extended
> -Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
> +is outstanding, is clear and \field{VF Enable} is set;
> +\field{NumVFs} and \field{VF Enable} refer to registers within the
> +SR-IOV Extended Capability as specified by \hyperref[intro:PCIe]{[PCIe]}.
>
> \section{Administration Virtqueues}\label{sec:Basic Facilities of a Virtio Device / Administration Virtqueues}
>
> --
> 2.26.2
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2023-05-02 7:39 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 22:44 [virtio-comment] [PATCH 0/2] admin virtqueue fixes Parav Pandit
2023-05-01 22:44 ` [virtio-dev] " Parav Pandit
2023-05-01 22:44 ` [virtio-comment] [PATCH 1/2] admin: Remove dependency on the deprecated register Parav Pandit
2023-05-01 22:44 ` [virtio-dev] " Parav Pandit
2023-05-02 7:39 ` Michael S. Tsirkin [this message]
2023-05-02 7:39 ` [virtio-dev] " Michael S. Tsirkin
2023-05-01 22:44 ` [virtio-comment] [PATCH 2/2] admin: Make optional command data type to u8 Parav Pandit
2023-05-01 22:44 ` [virtio-dev] " Parav Pandit
2023-05-02 7:37 ` [virtio-comment] " Michael S. Tsirkin
2023-05-02 7:37 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 11:29 ` [virtio-comment] " Parav Pandit
2023-05-02 11:29 ` [virtio-dev] " Parav Pandit
2023-05-02 11:36 ` [virtio-comment] " Michael S. Tsirkin
2023-05-02 11:36 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 7:41 ` [virtio-comment] Re: [PATCH 0/2] admin virtqueue fixes Michael S. Tsirkin
2023-05-02 7:41 ` [virtio-dev] " Michael S. Tsirkin
2023-05-02 11:34 ` [virtio-comment] " Parav Pandit
2023-05-02 11:34 ` [virtio-dev] " Parav Pandit
2023-05-02 11:40 ` [virtio-comment] " Michael S. Tsirkin
2023-05-02 11:40 ` [virtio-dev] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502033812-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=cohuck@redhat.com \
--cc=parav@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=virtio-comment@lists.oasis-open.org \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.