From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF66C77B7F for ; Wed, 3 May 2023 16:29:42 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 83CDD81F34; Wed, 3 May 2023 16:29:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 83CDD81F34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1683131382; bh=cc493d7n/KPL8a9i+00Vkowl6TUmOAiU5Dvzcalpjy8=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=e7Jt2zBSDHCVL1lv20+vcNLpHQTVMSCOGcW/1q5oFIuWcfGb69KewL2DkHOL2LzHn J2Eidpxlt/Qjwm1mG4ijPgL6TWnsCEt0Jz1K189oCrgAcVcx+n1ly5aJvnuD8d6xWU Kt4Ms/o7VpATnEV6m/YFFW7USz6WSxqbPd4QlG31Sl47lcsX4v50xGvTHRkCybvGcI TgsXIVdrcHcejEQ8zZI66hLa9NANw9ERpdFmt1QBezuP4p3PB0LVkZw/T7ep5U+rIt EIOQ+7fVhnt37HEwVpq52vpnZYO77LSzEqji5p/iw7w3KwaCaplaETlnMKerVlaQ9k 5DTZuR7eKvJxw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MxgaJYSjWZED; Wed, 3 May 2023 16:29:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 76F6E81F50; Wed, 3 May 2023 16:29:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 76F6E81F50 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id AFD891BF3E8 for ; Wed, 3 May 2023 16:29:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 87ED76152F for ; Wed, 3 May 2023 16:29:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 87ED76152F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q4ErjCVFwsD8 for ; Wed, 3 May 2023 16:29:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org B669861526 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id B669861526 for ; Wed, 3 May 2023 16:29:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 157F26265A; Wed, 3 May 2023 16:29:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC06CC433D2; Wed, 3 May 2023 16:29:35 +0000 (UTC) Date: Wed, 3 May 2023 19:29:32 +0300 From: Leon Romanovsky To: Ding Hui Message-ID: <20230503162932.GN525452@unreal> References: <20230503031541.27855-1-dinghui@sangfor.com.cn> <20230503031541.27855-3-dinghui@sangfor.com.cn> <20230503082458.GH525452@unreal> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683131376; bh=+Fa8lWXq+eKn54nxvLtDWjF14FF8nVDjXsR+6SPokpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ala5bqNF4QzuhsDsLBzQ1IP0XdwwIbDJ3GLns3f6uzPfhcI7QGlMw2tqwy04hpTRt 0oHMxsoxfOKIkGu+X4P62VCbNbGiKnb86a3Onb/lBvNbHpJjlMzk060TTdista/eVW RGq0xAj4h2Gi86TTggpW7vmEqbXglXHX8Bz18ffQ9hzgIrWaKg2Ka+YUsfIgHy6RQd oFIzyqUPYoo4Mbd2gW0oaMTZJaBlZJINKgaxGy5x0npQkSQRL6vIu8JBhiWvwvWTj5 heLSJohzf2nBNT9CbXpER2fku1XcLUmA/cFnyLs2j0Fio0ZNCOopL0DdHQglz7JyqF 20zuTnRxMm08g== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Ala5bqNF Subject: Re: [Intel-wired-lan] [PATCH net v4 2/2] iavf: Fix out-of-bounds when setting channels on remove X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pengdonglin@sangfor.com.cn, keescook@chromium.org, gregory.v.rose@intel.com, anthony.l.nguyen@intel.com, mitch.a.williams@intel.com, jesse.brandeburg@intel.com, huangcun@sangfor.com.cn, linux-kernel@vger.kernel.org, grzegorzx.szczurek@intel.com, edumazet@google.com, michal.kubiak@intel.com, intel-wired-lan@lists.osuosl.org, jeffrey.t.kirsher@intel.com, simon.horman@corigine.com, kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" T24gV2VkLCBNYXkgMDMsIDIwMjMgYXQgMTA6MDA6NDlQTSArMDgwMCwgRGluZyBIdWkgd3JvdGU6 Cj4gT24gMjAyMy81LzMgNDoyNCDkuIvljYgsIExlb24gUm9tYW5vdnNreSB3cm90ZToKPiA+IE9u IFdlZCwgTWF5IDAzLCAyMDIzIGF0IDExOjE1OjQxQU0gKzA4MDAsIERpbmcgSHVpIHdyb3RlOgo+ IAo+ID4gPiAKPiA+ID4gSWYgd2UgZGV0ZWN0ZWQgcmVtb3ZpbmcgaXMgaW4gcHJvY2Vzc2luZywg d2UgY2FuIGF2b2lkIHVubmVjZXNzYXJ5Cj4gPiA+IHdhaXRpbmcgYW5kIHJldHVybiBlcnJvciBm YXN0ZXIuCj4gPiA+IAo+ID4gPiBPbiB0aGUgb3RoZXIgaGFuZCBpbiB0aW1lb3V0IGhhbmRsaW5n LCB3ZSBzaG91bGQga2VlcCB0aGUgb3JpZ2luYWwKPiA+ID4gbnVtX2FjdGl2ZV9xdWV1ZXMgYW5k IHJlc2V0IG51bV9yZXFfcXVldWVzIHRvIDAuCj4gPiA+IAo+ID4gPiBGaXhlczogNGU1ZTZiNWQ5 ZDEzICgiaWF2ZjogRml4IHJldHVybiBvZiBzZXQgdGhlIG5ldyBjaGFubmVsIGNvdW50IikKPiA+ ID4gU2lnbmVkLW9mZi1ieTogRGluZyBIdWkgPGRpbmdodWlAc2FuZ2Zvci5jb20uY24+Cj4gPiA+ IENjOiBEb25nbGluIFBlbmcgPHBlbmdkb25nbGluQHNhbmdmb3IuY29tLmNuPgo+ID4gPiBDYzog SHVhbmcgQ3VuIDxodWFuZ2N1bkBzYW5nZm9yLmNvbS5jbj4KPiA+ID4gUmV2aWV3ZWQtYnk6IFNp bW9uIEhvcm1hbiA8c2ltb24uaG9ybWFuQGNvcmlnaW5lLmNvbT4KPiA+ID4gUmV2aWV3ZWQtYnk6 IE1pY2hhbCBLdWJpYWsgPG1pY2hhbC5rdWJpYWtAaW50ZWwuY29tPgo+ID4gPiAtLS0KPiA+ID4g djMgdG8gdjQ6Cj4gPiA+ICAgIC0gbm90aGluZyBjaGFuZ2VkCj4gPiA+IAo+ID4gPiB2MiB0byB2 MzoKPiA+ID4gICAgLSBmaXggcmV2aWV3IHRhZwo+ID4gPiAKPiA+ID4gdjEgdG8gdjI6Cj4gPiA+ ICAgIC0gYWRkIHJlcHJvZHVjdGlvbiBzY3JpcHQKPiA+ID4gCj4gPiA+IC0tLQo+ID4gPiAgIGRy aXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2lhdmYvaWF2Zl9ldGh0b29sLmMgfCA0ICsrKy0KPiA+ ID4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gPiA+ IAo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaWF2Zi9pYXZm X2V0aHRvb2wuYyBiL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2lhdmYvaWF2Zl9ldGh0b29s LmMKPiA+ID4gaW5kZXggNmYxNzFkMWQ4NWI3Li5kOGEzYzBjZmVkZDAgMTAwNjQ0Cj4gPiA+IC0t LSBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L2ludGVsL2lhdmYvaWF2Zl9ldGh0b29sLmMKPiA+ID4g KysrIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvaW50ZWwvaWF2Zi9pYXZmX2V0aHRvb2wuYwo+ID4g PiBAQCAtMTg1NywxMyArMTg1NywxNSBAQCBzdGF0aWMgaW50IGlhdmZfc2V0X2NoYW5uZWxzKHN0 cnVjdCBuZXRfZGV2aWNlICpuZXRkZXYsCj4gPiA+ICAgCS8qIHdhaXQgZm9yIHRoZSByZXNldCBp cyBkb25lICovCj4gPiA+ICAgCWZvciAoaSA9IDA7IGkgPCBJQVZGX1JFU0VUX1dBSVRfQ09NUExF VEVfQ09VTlQ7IGkrKykgewo+ID4gPiAgIAkJbXNsZWVwKElBVkZfUkVTRVRfV0FJVF9NUyk7Cj4g PiA+ICsJCWlmICh0ZXN0X2JpdChfX0lBVkZfSU5fUkVNT1ZFX1RBU0ssICZhZGFwdGVyLT5jcml0 X3NlY3Rpb24pKQo+ID4gPiArCQkJcmV0dXJuIC1FT1BOT1RTVVBQOwo+ID4gCj4gPiBUaGlzIG1h a2VzIG5vIHNlbnNlIHdpdGhvdXQgbG9ja2luZyBhcyBjaGFuZ2UgdG8gX19JQVZGX0lOX1JFTU9W RV9UQVNLCj4gPiBjYW4gaGFwcGVuIGFueSB0aW1lLgo+ID4gCj4gCj4gVGhlIHN0YXRlIGRvZXNu J3QgbmVlZCB0byBiZSB0aGF0IHByZWNpc2UgaGVyZSwgaXQgaXMgb3B0aW1pemVkIG9ubHkgZm9y Cj4gdGhlIGZhc3QgcGF0aC4gRHVyaW5nIHRoZSBsaWZlY3ljbGUgb2YgdGhlIGFkYXB0ZXIsIHRo ZSBfX0lBVkZfSU5fUkVNT1ZFX1RBU0sKPiBzdGF0ZSB3aWxsIG9ubHkgYmUgc2V0IGFuZCBub3Qg Y2xlYXJlZC4KPiAKPiBJZiB3ZSBkaWRuJ3QgZGV0ZWN0IHRoZSAicmVtb3ZpbmciIHN0YXRlLCB3 ZSBhbHNvIGNhbiBmYWxsYmFjayB0byB0aW1lb3V0Cj4gaGFuZGxpbmcuCj4gCj4gU28gSSBkb24n dCB0aGluayB0aGUgbG9ja2luZyBpcyBuZWNlc3NhcnkgaGVyZSwgd2hhdCBkbyB0aGUgbWFpbnRh aW5lcnMKPiBhdCBJbnRlbCB0aGluaz8KCkknbSBub3QgSW50ZWwgbWFpbnRhaW5lciwgYnV0IHlv dXIgY2hhbmdlLCBleHBsYW5hdGlvbiBhbmQgdGhlIGZvbGxvd2luZwpsaW5lIGZyb20geW91ciBj b21taXQgbWVzc2FnZSBhcmVuJ3QgcmVhbGx5IGFsaWduZWQuCgpbIDM1MTAuNDAwNzk5XSA9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KWyAzNTEwLjQwMDgyMF0gQlVHOiBLQVNBTjogc2xhYi1vdXQtb2YtYm91bmRzIGluIGlh dmZfZnJlZV9hbGxfdHhfcmVzb3VyY2VzKzB4MTU2LzB4MTYwIFtpYXZmXQoKCj4gCj4gPiBUaGFu a3MKPiA+IAo+ID4gPiAgIAkJaWYgKGFkYXB0ZXItPmZsYWdzICYgSUFWRl9GTEFHX1JFU0VUX1BF TkRJTkcpCj4gPiA+ICAgCQkJY29udGludWU7Cj4gPiA+ICAgCQlicmVhazsKPiA+ID4gICAJfQo+ ID4gPiAgIAlpZiAoaSA9PSBJQVZGX1JFU0VUX1dBSVRfQ09NUExFVEVfQ09VTlQpIHsKPiA+ID4g ICAJCWFkYXB0ZXItPmZsYWdzICY9IH5JQVZGX0ZMQUdfUkVJTklUX0lUUl9ORUVERUQ7Cj4gPiA+ IC0JCWFkYXB0ZXItPm51bV9hY3RpdmVfcXVldWVzID0gbnVtX3JlcTsKPiA+ID4gKwkJYWRhcHRl ci0+bnVtX3JlcV9xdWV1ZXMgPSAwOwo+ID4gPiAgIAkJcmV0dXJuIC1FT1BOT1RTVVBQOwo+ID4g PiAgIAl9Cj4gPiA+IC0tIAo+ID4gPiAyLjE3LjEKPiA+ID4gCj4gPiA+IAo+ID4gCj4gCj4gLS0g Cj4gVGhhbmtzLAo+IC1kaW5naHVpCj4gCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLXdpcmVkLWxhbiBtYWlsaW5nIGxpc3QKSW50ZWwtd2ly ZWQtbGFuQG9zdW9zbC5vcmcKaHR0cHM6Ly9saXN0cy5vc3Vvc2wub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtd2lyZWQtbGFuCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B19DC77B7F for ; Wed, 3 May 2023 16:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229676AbjECQ35 (ORCPT ); Wed, 3 May 2023 12:29:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229677AbjECQ3y (ORCPT ); Wed, 3 May 2023 12:29:54 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88A0C72B9; Wed, 3 May 2023 09:29:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11B496259B; Wed, 3 May 2023 16:29:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC06CC433D2; Wed, 3 May 2023 16:29:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1683131376; bh=+Fa8lWXq+eKn54nxvLtDWjF14FF8nVDjXsR+6SPokpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ala5bqNF4QzuhsDsLBzQ1IP0XdwwIbDJ3GLns3f6uzPfhcI7QGlMw2tqwy04hpTRt 0oHMxsoxfOKIkGu+X4P62VCbNbGiKnb86a3Onb/lBvNbHpJjlMzk060TTdista/eVW RGq0xAj4h2Gi86TTggpW7vmEqbXglXHX8Bz18ffQ9hzgIrWaKg2Ka+YUsfIgHy6RQd oFIzyqUPYoo4Mbd2gW0oaMTZJaBlZJINKgaxGy5x0npQkSQRL6vIu8JBhiWvwvWTj5 heLSJohzf2nBNT9CbXpER2fku1XcLUmA/cFnyLs2j0Fio0ZNCOopL0DdHQglz7JyqF 20zuTnRxMm08g== Date: Wed, 3 May 2023 19:29:32 +0300 From: Leon Romanovsky To: Ding Hui Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, intel-wired-lan@lists.osuosl.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, keescook@chromium.org, grzegorzx.szczurek@intel.com, mateusz.palczewski@intel.com, mitch.a.williams@intel.com, gregory.v.rose@intel.com, jeffrey.t.kirsher@intel.com, michal.kubiak@intel.com, simon.horman@corigine.com, madhu.chittim@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, pengdonglin@sangfor.com.cn, huangcun@sangfor.com.cn Subject: Re: [PATCH net v4 2/2] iavf: Fix out-of-bounds when setting channels on remove Message-ID: <20230503162932.GN525452@unreal> References: <20230503031541.27855-1-dinghui@sangfor.com.cn> <20230503031541.27855-3-dinghui@sangfor.com.cn> <20230503082458.GH525452@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org On Wed, May 03, 2023 at 10:00:49PM +0800, Ding Hui wrote: > On 2023/5/3 4:24 下午, Leon Romanovsky wrote: > > On Wed, May 03, 2023 at 11:15:41AM +0800, Ding Hui wrote: > > > > > > > If we detected removing is in processing, we can avoid unnecessary > > > waiting and return error faster. > > > > > > On the other hand in timeout handling, we should keep the original > > > num_active_queues and reset num_req_queues to 0. > > > > > > Fixes: 4e5e6b5d9d13 ("iavf: Fix return of set the new channel count") > > > Signed-off-by: Ding Hui > > > Cc: Donglin Peng > > > Cc: Huang Cun > > > Reviewed-by: Simon Horman > > > Reviewed-by: Michal Kubiak > > > --- > > > v3 to v4: > > > - nothing changed > > > > > > v2 to v3: > > > - fix review tag > > > > > > v1 to v2: > > > - add reproduction script > > > > > > --- > > > drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c > > > index 6f171d1d85b7..d8a3c0cfedd0 100644 > > > --- a/drivers/net/ethernet/intel/iavf/iavf_ethtool.c > > > +++ b/drivers/net/ethernet/intel/iavf/iavf_ethtool.c > > > @@ -1857,13 +1857,15 @@ static int iavf_set_channels(struct net_device *netdev, > > > /* wait for the reset is done */ > > > for (i = 0; i < IAVF_RESET_WAIT_COMPLETE_COUNT; i++) { > > > msleep(IAVF_RESET_WAIT_MS); > > > + if (test_bit(__IAVF_IN_REMOVE_TASK, &adapter->crit_section)) > > > + return -EOPNOTSUPP; > > > > This makes no sense without locking as change to __IAVF_IN_REMOVE_TASK > > can happen any time. > > > > The state doesn't need to be that precise here, it is optimized only for > the fast path. During the lifecycle of the adapter, the __IAVF_IN_REMOVE_TASK > state will only be set and not cleared. > > If we didn't detect the "removing" state, we also can fallback to timeout > handling. > > So I don't think the locking is necessary here, what do the maintainers > at Intel think? I'm not Intel maintainer, but your change, explanation and the following line from your commit message aren't really aligned. [ 3510.400799] ================================================================== [ 3510.400820] BUG: KASAN: slab-out-of-bounds in iavf_free_all_tx_resources+0x156/0x160 [iavf] > > > Thanks > > > > > if (adapter->flags & IAVF_FLAG_RESET_PENDING) > > > continue; > > > break; > > > } > > > if (i == IAVF_RESET_WAIT_COMPLETE_COUNT) { > > > adapter->flags &= ~IAVF_FLAG_REINIT_ITR_NEEDED; > > > - adapter->num_active_queues = num_req; > > > + adapter->num_req_queues = 0; > > > return -EOPNOTSUPP; > > > } > > > -- > > > 2.17.1 > > > > > > > > > > -- > Thanks, > -dinghui > >