From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 712CFC77B7F for ; Wed, 3 May 2023 18:54:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbjECSyd (ORCPT ); Wed, 3 May 2023 14:54:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjECSya (ORCPT ); Wed, 3 May 2023 14:54:30 -0400 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:237:300::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 808753C16 for ; Wed, 3 May 2023 11:54:19 -0700 (PDT) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1puHcI-0000dE-23; Wed, 03 May 2023 20:54:18 +0200 Date: Wed, 3 May 2023 20:54:18 +0200 From: Florian Westphal To: Boris Sukholitko Cc: netfilter-devel@vger.kernel.org, Ilya Lifshits Subject: Re: [PATCH nf-next 04/19] selftest: netfilter: monitor result file sizes Message-ID: <20230503185418.GE28036@breakpoint.cc> References: <20230503125552.41113-1-boris.sukholitko@broadcom.com> <20230503125552.41113-5-boris.sukholitko@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503125552.41113-5-boris.sukholitko@broadcom.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Boris Sukholitko wrote: > When running nft_flowtable.sh in VM on a busy server we've found that > the time of the netcat file transfers vary wildly. > > Therefore replace hardcoded 3 second sleep with the loop checking for > a change in the file sizes. Once no change in detected we test the results. > > Nice side effect is that we shave 1 second sleep in the fast case > (hard-coded 3 second sleep vs two 1 second sleeps). Much better than the old 'sleep', thanks. Acked-by: Florian Westphal