Re: [Buildroot] [PATCH] package/libpqxx: bump version to 7.7.5

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: James Knight <james.d.knight@live.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/libpqxx: bump version to 7.7.5
Date: Wed, 3 May 2023 21:55:03 +0200	[thread overview]
Message-ID: <20230503195503.GH2696@scaer> (raw)
In-Reply-To: <SJ0P221MB06891584D4A1A8E230113F46A06C9@SJ0P221MB0689.NAMP221.PROD.OUTLOOK.COM>

James, All,

On 2023-05-03 10:55 -0400, James Knight spake thusly:
> Signed-off-by: James Knight <james.d.knight@live.com>
> ---
>  package/libpqxx/libpqxx.hash | 4 ++--
>  package/libpqxx/libpqxx.mk   | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/libpqxx/libpqxx.hash b/package/libpqxx/libpqxx.hash
> index 167b5edc9d6b4260f60ce667e5e77c65d226a72b..1c0e4c185dedb910abd911059e6ada60b436802f 100644
> --- a/package/libpqxx/libpqxx.hash
> +++ b/package/libpqxx/libpqxx.hash
> @@ -1,3 +1,3 @@
>  # Locally computed:
> -sha256  86921fdb0fe54495a79d5af2c96f2c771098c31e9b352d0834230fd2799ad362  libpqxx-6.4.5.tar.gz
> -sha256  36c48c1ca1b0a68639d919196b5d92c971858ad8e24da24385ba1c65cc5eac38  COPYING
> +sha256  c7dc3e8fa2eee656f2b6a8179d72f15db10e97a80dc4f173f806e615ea990973  libpqxx-7.7.5.tar.gz
> +sha256  91718581edafc9f722915133d75f74c82d7c2e41a1831c1e042206423e5a63b0  COPYING

You forgot to explain why COIPYING was updated.

Indeed, if we have hashes for license files, that's because we want to
notice when they change, and so we can review the new lisensing terms.

Silently updating the license hash without explanations kinda defeat the
very purpose of the hash.

In this case, the reason for the change is an update in copyright years,
so just stating that in the commit log would have been enough.

Applied to master, thanks (but I forgot to amend the commit log to
explain the license hash change).

Regards,
Yann E. MORIN.

> diff --git a/package/libpqxx/libpqxx.mk b/package/libpqxx/libpqxx.mk
> index 9de7df3ed28ba26d3d979b32d34d6c0cdae0da9a..b280f5a52a15b7c60d3da16ad326dbedac123137 100644
> --- a/package/libpqxx/libpqxx.mk
> +++ b/package/libpqxx/libpqxx.mk
> @@ -4,7 +4,7 @@
>  #
>  ################################################################################
>  
> -LIBPQXX_VERSION = 6.4.5
> +LIBPQXX_VERSION = 7.7.5
>  LIBPQXX_SITE = $(call github,jtv,libpqxx,$(LIBPQXX_VERSION))
>  LIBPQXX_INSTALL_STAGING = YES
>  LIBPQXX_DEPENDENCIES = postgresql
> -- 
> 2.40.1.windows.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot