From: Jakub Kicinski <kuba@kernel.org>
To: Jon Maloy <jmaloy@redhat.com>, Xin Long <lucien.xin@gmail.com>
Cc: Tung Quang Nguyen <tung.q.nguyen@dektech.com.au>,
network dev <netdev@vger.kernel.org>,
"tipc-discussion@lists.sourceforge.net"
<tipc-discussion@lists.sourceforge.net>,
"davem@davemloft.net" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCHv2 net 2/3] tipc: do not update mtu if msg_max is too small in mtu negotiation
Date: Wed, 3 May 2023 19:55:09 -0700 [thread overview]
Message-ID: <20230503195509.1d637de6@kernel.org> (raw)
In-Reply-To: <d7ccfcc9-b446-66ad-ab04-baa1cdbbe0ce@redhat.com>
On Wed, 3 May 2023 15:29:07 -0400 Jon Maloy wrote:
> > I think it's correct to NOT use ''---' for version changes, see the
> > comment from davem:
> >
> > https://lore.kernel.org/netdev/20160415.172858.253625178036493951.davem@davemloft.net/
> >
> > unless there are some new rules I missed.
> I have not seen this one before, and I disagree with David here. Many of
> the changes
> between versions are trivial, and some comments even incomprehensible
> once the patch has
> been applied.
> I have always put them after the "---" comment, and I will continue to
> do so until David starts
> rejecting such patches.
>
> But ok, do as you find right.
Yes, I think the motivation has changed a bit since we now have
the permanent lore archive and we add links when applying patches.
The change log is easy to find on lore, even after the --- delimiter.
next prev parent reply other threads:[~2023-05-04 2:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 22:13 [PATCHv2 net 0/3] tipc: fix the mtu update in link mtu negotiation Xin Long
2023-05-02 22:13 ` [PATCHv2 net 1/3] tipc: add tipc_bearer_min_mtu to calculate min mtu Xin Long
2023-05-03 3:37 ` Tung Quang Nguyen
2023-05-03 13:40 ` Xin Long
2023-05-02 22:13 ` [PATCHv2 net 2/3] tipc: do not update mtu if msg_max is too small in mtu negotiation Xin Long
2023-05-03 3:31 ` Tung Quang Nguyen
2023-05-03 13:35 ` Xin Long
2023-05-03 19:29 ` Jon Maloy
2023-05-04 2:55 ` Jakub Kicinski [this message]
2023-05-02 22:13 ` [PATCHv2 net 3/3] tipc: check the bearer min mtu properly when setting it by netlink Xin Long
2023-05-07 21:46 ` [PATCHv2 net 0/3] tipc: fix the mtu update in link mtu negotiation Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503195509.1d637de6@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=tung.q.nguyen@dektech.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.