From: Jakub Kicinski <kuba@kernel.org>
To: Maxim Georgiev <glipus@gmail.com>
Cc: kory.maincent@bootlin.com, netdev@vger.kernel.org,
maxime.chevallier@bootlin.com, vladimir.oltean@nxp.com,
vadim.fedorenko@linux.dev, richardcochran@gmail.com,
gerhard@engleder-embedded.com, liuhangbin@gmail.com
Subject: Re: [RFC PATCH net-next v6 2/5] net: Add ifreq pointer field to kernel_hwtstamp_config structure
Date: Wed, 3 May 2023 20:05:45 -0700 [thread overview]
Message-ID: <20230503200545.2ff5d9d2@kernel.org> (raw)
In-Reply-To: <20230502043150.17097-3-glipus@gmail.com>
On Mon, 1 May 2023 22:31:47 -0600 Maxim Georgiev wrote:
> + err = dev_eth_ioctl(dev, &ifrr, SIOCSHWTSTAMP);
> + if (!err) {
> + kernel_cfg->ifr->ifr_ifru = ifrr.ifr_ifru;
> + kernel_cfg->kernel_flags |= KERNEL_HWTSTAMP_FLAG_IFR_RESULT;
> + }
> + return err;
nit: I think we should stick to the normal flow even if it costs
a few extra lines:
err = dev_eth_ioctl(..
if (err)
return err;
kernel_cfg->ifr->ifr_ifru = ifrr.ifr_ifru;
kernel_cfg->kernel_flags |= KERNEL_HWTSTAMP_FLAG_IFR_RESULT;
return 0;
Other than that patches LGTM :)
next prev parent reply other threads:[~2023-05-04 3:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 4:31 [RFC PATCH net-next v6 0/5] New NDO methods ndo_hwtstamp_get/set Maxim Georgiev
2023-05-02 4:31 ` [RFC PATCH net-next v6 1/5] net: Add NDOs for hardware timestamp get/set Maxim Georgiev
2023-05-11 12:32 ` Vladimir Oltean
2023-05-12 3:22 ` Max Georgiev
2023-05-12 17:41 ` Jakub Kicinski
2023-05-15 15:36 ` Max Georgiev
2023-05-02 4:31 ` [RFC PATCH net-next v6 2/5] net: Add ifreq pointer field to kernel_hwtstamp_config structure Maxim Georgiev
2023-05-04 3:05 ` Jakub Kicinski [this message]
2023-05-04 15:21 ` Max Georgiev
2023-05-04 15:41 ` Jakub Kicinski
2023-05-11 9:30 ` Vladimir Oltean
2023-05-02 4:31 ` [RFC PATCH net-next v6 3/5] vlan/macvlan: Add ndo_hwtstamp_get/set support to vlan/macvlan code path Maxim Georgiev
2023-05-02 4:31 ` [RFC PATCH net-next v6 4/5] bond: Add ndo_hwtstamp_get/set support to bond driver Maxim Georgiev
2023-05-02 4:31 ` [RFC PATCH net-next v6 5/5] netdevsim: Implement ndo_hwtstamp_get/set methods in netdevsim driver Maxim Georgiev
2023-06-21 2:23 ` [RFC PATCH net-next v6 0/5] New NDO methods ndo_hwtstamp_get/set Jakub Kicinski
2023-07-01 10:03 ` Vladimir Oltean
2023-07-01 14:51 ` Max Georgiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230503200545.2ff5d9d2@kernel.org \
--to=kuba@kernel.org \
--cc=gerhard@engleder-embedded.com \
--cc=glipus@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=liuhangbin@gmail.com \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.