All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric DeVolder <eric.devolder@oracle.com>
To: kexec@lists.infradead.org
Cc: boris.ostrovsky@oracle.com, eric.devolder@oracle.com
Subject: [PATCH v2 3/6] crashdump: setup hotplug support
Date: Wed,  3 May 2023 18:16:08 -0400	[thread overview]
Message-ID: <20230503221611.2119-4-eric.devolder@oracle.com> (raw)
In-Reply-To: <20230503221611.2119-1-eric.devolder@oracle.com>

To allow direct modification of the elfcorehdr by the kernel, in
response to CPU and memory hot un/plug and/or online/offline events,
the buffer containing the:
 - elfcorehdr must be excluded from the purgatory checksum/digest
   (see "crashdump: exclude elfcorehdr segment from digest for
   hotplug")
 - the elfcorehdr segment must be large enough, and
 - the kernel must be permitted to modify the elfcorehdr

For hotplug, the size of the elfcorehdr segment is obtained from the
kernel, or from the command line option.

The KEXEC_UPDATE_ELFCOREHDR flag indicates to the kernel that it can
make direct modifications to the elfcorehdr.

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
---
 kexec/kexec.c | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/kexec/kexec.c b/kexec/kexec.c
index 4a64e53..c59e795 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -1626,6 +1626,28 @@ int main(int argc, char *argv[])
 		die("--load-live-update can only be used with xen\n");
 	}
 
+    /* NOTE: Xen KEXEC_LIVE_UPDATE and KEXEC_UPDATE_ELFCOREHDR collide */
+	if (do_hotplug) {
+		const char *ces = "/sys/kernel/crash_elfcorehdr_size";
+		if (!elfcorehdrsz) {
+			unsigned long ul;
+			char *buf;
+			off_t nread = 0;
+			buf = slurp_file_len(ces, sizeof(buf)-1, &nread);
+			if (buf) {
+			    ul = strtoul(buf, NULL, 0);
+				elfcorehdrsz = ul;
+			}
+		}
+		if (!elfcorehdrsz) {
+			die("If path %s does not exist, must specify the\n"
+				"--elfcorehdrsz= option\n", ces);
+		}
+		dbgprintf("ELFCOREHDR_SIZE %lu\n", elfcorehdrsz);
+		/* Indicate to the kernel it is ok to modify the elfcorehdr */
+		kexec_flags |= KEXEC_UPDATE_ELFCOREHDR;
+	}
+
 	fileind = optind;
 	/* Reset getopt for the next pass; called in other source modules */
 	opterr = 1;
-- 
2.31.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2023-05-03 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 22:16 [PATCH v2 0/6] crashdump: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 1/6] kexec: define KEXEC_UPDATE_ELFCOREHDR Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 2/6] crashdump: introduce the hotplug command line options Eric DeVolder
2023-05-03 22:16 ` Eric DeVolder [this message]
2023-05-03 22:16 ` [PATCH v2 4/6] crashdump: exclude elfcorehdr segment from digest for hotplug Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 5/6] crashdump/x86: identify elfcorehdr segment " Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 6/6] crashdump/x86: set the elfcorehdr segment size " Eric DeVolder
2023-05-04  6:19 ` [PATCH v2 0/6] crashdump: Kernel handling of CPU and memory hot un/plug Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503221611.2119-4-eric.devolder@oracle.com \
    --to=eric.devolder@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.