From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface Date: Thu, 4 May 2023 08:23:59 +0200 Message-ID: <20230504062359.GE1734100@hirez.programming.kicks-ass.net> References: <20230503072228.115707-1-juri.lelli@redhat.com> <20230503072228.115707-6-juri.lelli@redhat.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j16Bh52nzyJO9VnirYe2+W5J9gGnfrNEg+DqgmtGTK4=; b=o39RDzof6y4haLdWTv/dU4Ezo1 00lekUFPh1bpwrIBOFfrFQtxvnmNYxA+cPAl3zBtS5pnDMARzaEnn+hmjQGcfjyrMrafdnp56iHaB jCU4qImPx1pTrvi3mVZQIVDHBvy/8bmRNgI3TQa0qOK3AH3GMSynPqiy7ueCFYCjgW3u/AOhW/SHl 1KCW0DPlxbZcmJSFtRGXN2sPMGjdh3wyyP68Ly28Da3f6DAp1AKKXuyDvLWV6vq75DXF4J5eOyH+r GCcSGtu4wI3BzOk2U/Yz1J2rnxpbodfdOOwaOT/rg8p0YjccZWbaRM/gyWRIqIutipwdiXuRhyIi2 hMejCuGA==; Content-Disposition: inline In-Reply-To: <20230503072228.115707-6-juri.lelli-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Juri Lelli Cc: Ingo Molnar , Qais Yousef , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo , Dietmar Eggemann , Steven Rostedt , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, luca.abeni-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, claudio-YOzL5CV4y4YG1A2ADO40+w@public.gmane.org, tommaso.cucinotta-5rdYK369eBLQB0XuIGIEkQ@public.gmane.org, bristot-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mathieu.poirier-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev On Wed, May 03, 2023 at 09:22:27AM +0200, Juri Lelli wrote: > From: Dietmar Eggemann > > Rework the existing dl_cpu_busy() interface which offers DL BW overflow > checking and per-task DL BW allocation. > > Add dl_bw_free() as an interface to be able to free DL BW. > It will be used to allow freeing of the DL BW request done during > cpuset_can_attach() in case multiple controllers are attached to the > cgroup next to the cpuset controller and one of the non-cpuset > can_attach() fails. > > dl_bw_alloc() (and dl_bw_free()) now take a `u64 dl_bw` parameter > instead of `struct task_struct *p` used in dl_cpu_busy(). This allows > to allocate DL BW for a set of tasks too rater than only for a single > task. > Changlog fails the 'why' test. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FB8C77B7C for ; Thu, 4 May 2023 06:24:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbjEDGYl (ORCPT ); Thu, 4 May 2023 02:24:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229886AbjEDGYi (ORCPT ); Thu, 4 May 2023 02:24:38 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 036BE26BE; Wed, 3 May 2023 23:24:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j16Bh52nzyJO9VnirYe2+W5J9gGnfrNEg+DqgmtGTK4=; b=o39RDzof6y4haLdWTv/dU4Ezo1 00lekUFPh1bpwrIBOFfrFQtxvnmNYxA+cPAl3zBtS5pnDMARzaEnn+hmjQGcfjyrMrafdnp56iHaB jCU4qImPx1pTrvi3mVZQIVDHBvy/8bmRNgI3TQa0qOK3AH3GMSynPqiy7ueCFYCjgW3u/AOhW/SHl 1KCW0DPlxbZcmJSFtRGXN2sPMGjdh3wyyP68Ly28Da3f6DAp1AKKXuyDvLWV6vq75DXF4J5eOyH+r GCcSGtu4wI3BzOk2U/Yz1J2rnxpbodfdOOwaOT/rg8p0YjccZWbaRM/gyWRIqIutipwdiXuRhyIi2 hMejCuGA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1puSNk-001ebz-1p; Thu, 04 May 2023 06:24:03 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id A7CF9301326; Thu, 4 May 2023 08:23:59 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 8ACBF24080DDC; Thu, 4 May 2023 08:23:59 +0200 (CEST) Date: Thu, 4 May 2023 08:23:59 +0200 From: Peter Zijlstra To: Juri Lelli Cc: Ingo Molnar , Qais Yousef , Waiman Long , Tejun Heo , Zefan Li , Johannes Weiner , Hao Luo , Dietmar Eggemann , Steven Rostedt , linux-kernel@vger.kernel.org, luca.abeni@santannapisa.it, claudio@evidence.eu.com, tommaso.cucinotta@santannapisa.it, bristot@redhat.com, mathieu.poirier@linaro.org, cgroups@vger.kernel.org, Vincent Guittot , Wei Wang , Rick Yiu , Quentin Perret , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Sudeep Holla Subject: Re: [PATCH v2 5/6] sched/deadline: Create DL BW alloc, free & check overflow interface Message-ID: <20230504062359.GE1734100@hirez.programming.kicks-ass.net> References: <20230503072228.115707-1-juri.lelli@redhat.com> <20230503072228.115707-6-juri.lelli@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230503072228.115707-6-juri.lelli@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2023 at 09:22:27AM +0200, Juri Lelli wrote: > From: Dietmar Eggemann > > Rework the existing dl_cpu_busy() interface which offers DL BW overflow > checking and per-task DL BW allocation. > > Add dl_bw_free() as an interface to be able to free DL BW. > It will be used to allow freeing of the DL BW request done during > cpuset_can_attach() in case multiple controllers are attached to the > cgroup next to the cpuset controller and one of the non-cpuset > can_attach() fails. > > dl_bw_alloc() (and dl_bw_free()) now take a `u64 dl_bw` parameter > instead of `struct task_struct *p` used in dl_cpu_busy(). This allows > to allocate DL BW for a set of tasks too rater than only for a single > task. > Changlog fails the 'why' test.