From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60870C77B78 for ; Thu, 4 May 2023 07:43:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9BAD789048; Thu, 4 May 2023 07:43:48 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0472B89048 for ; Thu, 4 May 2023 07:43:46 +0000 (UTC) Received: from pendragon.ideasonboard.com (133-32-181-51.west.xps.vectant.ne.jp [133.32.181.51]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6C42F755; Thu, 4 May 2023 09:43:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1683186221; bh=UOPsfm9Ll3BUsxkEm1+Wyywr1K7vJG7h9UqJ7TI3xEs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=COViMnQroPHt1gP6E6h88sOaEv84F/m8Ghv2qz9bjPVb+RtFIM5CquPdTVqxCm27Z Ug2EeL8ZeO3vNAoPO2b/bOf0C+XyJWaeFXHGB1qKMT/SkUxmeLL1AjVWJC6cfyXDzE iFRJiu4+kSVVGf7nMlmeKbM7iMbS6y7/K1F6WG+I= Date: Thu, 4 May 2023 10:43:56 +0300 From: Laurent Pinchart To: Alexander Stein Subject: Re: [PATCH 1/1] drm/bridge: ti-sn65dsi83: Fix enable error path Message-ID: <20230504074356.GD4551@pendragon.ideasonboard.com> References: <20230504065316.2640739-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230504065316.2640739-1-alexander.stein@ew.tq-group.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Andrzej Hajda Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Alexander, Thank you for the patch. On Thu, May 04, 2023 at 08:53:16AM +0200, Alexander Stein wrote: > If PLL locking failed, the regulator needs to be disabled again. > > Fixes: 5664e3c907e2 ("drm/bridge: ti-sn65dsi83: Add vcc supply regulator support") > Signed-off-by: Alexander Stein Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-sn65dsi83.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi83.c b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > index 75286c9afbb9..1f5c07989e2b 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi83.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi83.c > @@ -478,6 +478,7 @@ static void sn65dsi83_atomic_enable(struct drm_bridge *bridge, > dev_err(ctx->dev, "failed to lock PLL, ret=%i\n", ret); > /* On failure, disable PLL again and exit. */ > regmap_write(ctx->regmap, REG_RC_PLL_EN, 0x00); > + regulator_disable(ctx->vcc); > return; > } > -- Regards, Laurent Pinchart