From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EC4FC77B78 for ; Thu, 4 May 2023 09:04:55 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2DD50855D9; Thu, 4 May 2023 11:04:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683191093; bh=v0koxDtwuWJzdaGdj8y56zPDxF2lMzvUysP1cTKd4yU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=O0m/UV4g8fIzWoM5TX907mG7wqyHFocsO7jc0eiJ/B6MO1f5bJFDLKYfKaq/TmsCe g1wyh2JieAT/B0BTT0Ghm4X5x4SJGywHqCQ/QiqkuQEI9I+sM9u+w6pnF2gexylVPg K+APHiK6fdAgHjjFVlPwojgdfAu2pL/0zFW3CRzRCMCpy44mR+Fqh+E8o9UiZy8lCw mkOiTQUV1nfXApWz03rM39RtTk24fGTyGZ8g2+FN3z7lUmP1FaUq83odFAv5Xvomow ysoqxtzyupzDf4NZcGKD7+6X/cuYKvAuoYuEusoLlTiwdSiFUG0lPqweaDHNRuEwHP tFVdHVAtXlhkQ== Received: from wsk (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 405E0846D7; Thu, 4 May 2023 11:04:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1683191091; bh=v0koxDtwuWJzdaGdj8y56zPDxF2lMzvUysP1cTKd4yU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZwqCuVr98Ibyf4qEwAw9uw55tJG/W/3uLh1o2wHPwX+iGU94fxqdASsABu5gXBG/L G0AHaScvOzQl6ZeOE6+v0WDnBbAWWiCCySjK+6MILL+Mh5jq7uCYMk74l681QB7CVL /SNihN3pkXLNy/nxP/vae/xWtLLuwvb2e+PnqoxrMdf3xkKsGg4/P7cwRedhWbP09J MYZ6t3TnPyrYHuag3kZJTnxg3f7FEugv7VX9xL+dejT/lRjhGYlRzAy3fZPbSKxKca uAxmBju2C5cUstKjkkWnAn2LW70UY5zj5z1cBe076WUDz5Wyklz0E9YpsRG3Roe0QJ S15tbZfIqinmA== Date: Thu, 4 May 2023 11:04:45 +0200 From: Lukasz Majewski To: Marek Vasut Cc: u-boot@lists.denx.de Subject: Re: [PATCH] usb: gadget: Compile USB ethernet gadget only if NET is enabled Message-ID: <20230504110445.733f58f5@wsk> In-Reply-To: <20230430212035.379838-1-marex@denx.de> References: <20230430212035.379838-1-marex@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/hbBoqcBxpSJ6/08fsXkpv2l"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --Sig_/hbBoqcBxpSJ6/08fsXkpv2l Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 30 Apr 2023 23:20:35 +0200 Marek Vasut wrote: > In case NET networking is not enabled, it is not possible to compile > the USB ethernet gadget. Protect the symbols in Makefile to avoid > build failure. Such build failure may occur e.g. in case NET and USB > ethernet gadget is enabled in U-Boot proper, but not in SPL. >=20 > Signed-off-by: Marek Vasut > --- > Cc: Lukasz Majewski > --- > drivers/usb/gadget/Makefile | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile > index 6cfe0f3a041..36f65e7eb95 100644 > --- a/drivers/usb/gadget/Makefile > +++ b/drivers/usb/gadget/Makefile > @@ -34,8 +34,10 @@ endif > =20 > obj-$(CONFIG_CI_UDC) +=3D ci_udc.o > =20 > +ifeq ($(CONFIG_$(SPL_TPL_)NET),y) > obj-$(CONFIG_USB_ETHER) +=3D ether.o > obj-$(CONFIG_USB_ETH_RNDIS) +=3D rndis.o > +endif > =20 > # Devices not related to the new gadget layer depend on > CONFIG_USB_DEVICE # This is really only N900 and USBTTY now. Reviewed-by: Lukasz Majewski Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/hbBoqcBxpSJ6/08fsXkpv2l Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmRTdS0ACgkQAR8vZIA0 zr0ilwf/ZTSRcYi9mhknSFGMfOqzyf1ScckIKLX9qGWdqL2SbwIlL5gmmzsBMSgy 5dPFnGOOc1SRcr+WB8gFYrGONmhXrhhtbS3rsGYtgln/jUMKMYw5WyU8sRRNx+wR qRtnm3mVRgDFu5v5BK8/x0MIA33oIRBnyOSRSqFIexYRP9fEAhJkTfFKVsjrQBH5 fWG5qNev5Jh6gBx0/mG5magqTgJCEnPjPFFkw0N5VygS9IwisGfanXuwSS2hOoq/ 5KjqQ/g9EPYpteLCjB0iEanhkbU2Y/uzyFb2gL9NHpEod1RhHArjW3J1fFvdSVrt oqjxpW1roluzUJf4r7SjRM1yC39EtA== =vJFH -----END PGP SIGNATURE----- --Sig_/hbBoqcBxpSJ6/08fsXkpv2l--