From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>, Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Niklas Cassel <niklas.cassel@wdc.com>,
Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.de>,
John Garry <john.g.garry@oracle.com>,
Mike Christie <michael.christie@oracle.com>,
Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Changyuan Lyu <changyuanl@google.com>,
Jolly Shah <jollys@google.com>,
Vishakha Channapattan <vishakhavc@google.com>
Subject: Re: [PATCH v2 3/5] scsi: core: Trace SCSI sense data
Date: Fri, 5 May 2023 08:01:45 +0200 [thread overview]
Message-ID: <20230505060145.GC11897@lst.de> (raw)
In-Reply-To: <20230503230654.2441121-4-bvanassche@acm.org>
On Wed, May 03, 2023 at 04:06:52PM -0700, Bart Van Assche wrote:
> If a command fails, SCSI sense data is essential to determine why it
> failed. Hence make the sense key, ASC and ASCQ codes available in the
> ftrace output.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although, I'd also love to see pre-decoded ASC and ASCQ codes in the
scsi_cmnd at some point.
next prev parent reply other threads:[~2023-05-05 6:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 23:06 [PATCH v2 0/5] SCSI core patches Bart Van Assche
2023-05-03 23:06 ` [PATCH v2 1/5] scsi: core: Use min() instead of open-coding it Bart Van Assche
2023-05-05 6:00 ` Christoph Hellwig
2023-05-08 10:51 ` Benjamin Block
2023-05-03 23:06 ` [PATCH v2 2/5] scsi: core: Update a source code comment Bart Van Assche
2023-05-05 6:00 ` Christoph Hellwig
2023-05-08 11:25 ` Benjamin Block
2023-05-08 14:09 ` Bart Van Assche
2023-05-03 23:06 ` [PATCH v2 3/5] scsi: core: Trace SCSI sense data Bart Van Assche
2023-05-04 8:07 ` Hannes Reinecke
2023-05-05 22:00 ` Bart Van Assche
2023-05-04 9:03 ` Niklas Cassel
2023-05-05 6:01 ` Christoph Hellwig [this message]
2023-05-06 22:48 ` Martin K. Petersen
2023-05-17 19:56 ` Bart Van Assche
2023-05-08 14:05 ` Benjamin Block
2023-05-08 14:10 ` Bart Van Assche
2023-05-08 14:21 ` Benjamin Block
2023-05-03 23:06 ` [PATCH v2 4/5] scsi: core: Only kick the requeue list if necessary Bart Van Assche
2023-05-04 4:15 ` Ming Lei
2023-05-05 7:49 ` Christoph Hellwig
2023-05-03 23:06 ` [PATCH v2 5/5] scsi: core: Delay running the queue if the host is blocked Bart Van Assche
2023-05-05 7:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230505060145.GC11897@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=changyuanl@google.com \
--cc=hare@suse.de \
--cc=jaegeuk@kernel.org \
--cc=john.g.garry@oracle.com \
--cc=jollys@google.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mhiramat@kernel.org \
--cc=michael.christie@oracle.com \
--cc=ming.lei@redhat.com \
--cc=niklas.cassel@wdc.com \
--cc=rostedt@goodmis.org \
--cc=vishakhavc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.