From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74FF61857 for ; Sat, 6 May 2023 07:58:45 +0000 (UTC) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6436e004954so2858010b3a.0 for ; Sat, 06 May 2023 00:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=NQRCz43CT3Am3q/I02DZVA0uqVsD/A7hjEDQjanb1XYTXvdhgJhATgrvGC/pEKtZ53 czw2fdaLr3ZB76Bw6/1H9YubH2IK2ap/hVjLZcCwc/Bs75xT96EizfONWjqYhcfQUGXl lwraI32bJREv8kOJ2O8aNUuSAN2Npeh9AFDoCzk6Nlrl4/YOkHEEPkdab4MOEyVV13gA pmRSW3ebFAApIF65wN8wyLf6i/mlBP2PvkqKZPsRG6iXzCyGZPKW9aKEANwVLl3jNrBy J2m0/s23etfyiSjR/Cbz+ylvBLzFaJBuHXbotkrFPdknOMrr4M6Na5Hoo2hysHuhtF81 kgLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=k0f9kOZGGImbcT954oD4Bn+GKJhAV8mfJfszITHg+MIcv/JfQKR4bH6EVGz7mawNbw yvHQB29317JVI0YHaM/2S06Q0elPGle1kQVL9MWQaKKOh0iFMs501mTGw8NIUHheYs7V FRFKuwc97Qn+EwDDglvMQ//HHlaoOBCVdCn9nGQV4bP0e/w7Y1BgjInzZVZOilvAIMKV aC8qlJ6UnfBEnDYME3Be4SrWCWPr+7WGMJ6A6oYGCVdadW3HcIiMaIE6Tf7pa2uItcwp d7S5dJNu8K/7f4OBhoyMRHajphwxBcUazpOktz0/8hVZNSkBg/nJsuEeX4VSkDGYSudw M7ZA== X-Gm-Message-State: AC+VfDzlahdrAoubvOnZ40aEcMeMM3He0aq9KgPg8IkZcizk3jBhPI2E /aFT7bmCDI9NUmMquE7e2RZZ X-Google-Smtp-Source: ACHHUZ6s1Jzex0YPfLJUb6h3oibL3F+U2pv0j40QoSsQ4BhKF3WctKGX8jpyOyBkUm482uYZcTvusw== X-Received: by 2002:a05:6a00:1686:b0:643:a35d:b8dc with SMTP id k6-20020a056a00168600b00643a35db8dcmr5053349pfc.28.1683359924874; Sat, 06 May 2023 00:58:44 -0700 (PDT) Received: from thinkpad ([120.138.12.87]) by smtp.gmail.com with ESMTPSA id h16-20020aa786d0000000b0063b8f33cb81sm2728451pfo.93.2023.05.06.00.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 00:58:44 -0700 (PDT) Date: Sat, 6 May 2023 13:28:37 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support Message-ID: <20230506075837.GA9238@thinkpad> References: <20230501144807.1616244-1-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230501144807.1616244-1-Frank.Li@nxp.com> On Mon, May 01, 2023 at 10:48:06AM -0400, Frank Li wrote: > Layerscape has PME interrupt, which can be used as linkup notifier. > Set CFG_READY bit when linkup detected. Where are you setting this bit? > > Signed-off-by: Xiaowei Bao > Signed-off-by: Frank Li > --- > Change from v1 to v2 > - pme -> PME > - irq -> IRQ > - update dev_info message according to Bjorn's suggestion > - remove '.' at error message > > .../pci/controller/dwc/pci-layerscape-ep.c | 104 +++++++++++++++++- > 1 file changed, 103 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index c640db60edc6..e974fbe3b6d8 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -18,6 +18,20 @@ > > #include "pcie-designware.h" > > +#define PEX_PF0_CONFIG 0xC0014 > +#define PEX_PF0_CFG_READY BIT(0) > + > +/* PEX PFa PCIE PME and message interrupt registers*/ > +#define PEX_PF0_PME_MES_DR 0xC0020 > +#define PEX_PF0_PME_MES_DR_LUD BIT(7) > +#define PEX_PF0_PME_MES_DR_LDD BIT(9) > +#define PEX_PF0_PME_MES_DR_HRD BIT(10) > + > +#define PEX_PF0_PME_MES_IER 0xC0028 > +#define PEX_PF0_PME_MES_IER_LUDIE BIT(7) > +#define PEX_PF0_PME_MES_IER_LDDIE BIT(9) > +#define PEX_PF0_PME_MES_IER_HRDIE BIT(10) > + > #define to_ls_pcie_ep(x) dev_get_drvdata((x)->dev) > > struct ls_pcie_ep_drvdata { > @@ -30,8 +44,88 @@ struct ls_pcie_ep { > struct dw_pcie *pci; > struct pci_epc_features *ls_epc; > const struct ls_pcie_ep_drvdata *drvdata; > + bool big_endian; > + int irq; > }; > > +static u32 ls_lut_readl(struct ls_pcie_ep *pcie, u32 offset) > +{ > + struct dw_pcie *pci = pcie->pci; > + > + if (pcie->big_endian) > + return ioread32be(pci->dbi_base + offset); > + else > + return ioread32(pci->dbi_base + offset); > +} > + > +static void ls_lut_writel(struct ls_pcie_ep *pcie, u32 offset, > + u32 value) Above function argument could be wrapped within 80 columns. > +{ > + struct dw_pcie *pci = pcie->pci; > + > + if (pcie->big_endian) > + iowrite32be(value, pci->dbi_base + offset); > + else > + iowrite32(value, pci->dbi_base + offset); > +} > + > +static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > +{ > + struct ls_pcie_ep *pcie = (struct ls_pcie_ep *)dev_id; No need to do explicit typecase for void pointer. > + struct dw_pcie *pci = pcie->pci; > + u32 val, cfg; > + > + val = ls_lut_readl(pcie, PEX_PF0_PME_MES_DR); > + if (!val) > + return IRQ_NONE; > + > + if (val & PEX_PF0_PME_MES_DR_LUD) { > + cfg = ls_lut_readl(pcie, PEX_PF0_CONFIG); > + cfg |= PEX_PF0_CFG_READY; > + ls_lut_writel(pcie, PEX_PF0_CONFIG, cfg); > + dw_pcie_ep_linkup(&pci->ep); > + > + dev_info(pci->dev, "Link up\n"); These messages could be demoted to dev_dbg() logs. > + } else if (val & PEX_PF0_PME_MES_DR_LDD) { > + dev_info(pci->dev, "Link down\n"); > + } else if (val & PEX_PF0_PME_MES_DR_HRD) { > + dev_info(pci->dev, "Hot reset\n"); > + } > + > + ls_lut_writel(pcie, PEX_PF0_PME_MES_DR, val); You should clear the interrupts before processing. > + > + return IRQ_HANDLED; > +} > + > +static int ls_pcie_ep_interrupt_init(struct ls_pcie_ep *pcie, > + struct platform_device *pdev) > +{ > + u32 val; > + int ret; > + > + pcie->irq = platform_get_irq_byname(pdev, "pme"); > + if (pcie->irq < 0) { > + dev_err(&pdev->dev, "Can't get 'pme' IRQ\n"); PME > + return pcie->irq; > + } > + > + ret = devm_request_irq(&pdev->dev, pcie->irq, > + ls_pcie_ep_event_handler, IRQF_SHARED, > + pdev->name, pcie); Again, please wrap to fit the 80 column width. > + if (ret) { > + dev_err(&pdev->dev, "Can't register PCIe IRQ\n"); > + return ret; > + } > + > + /* Enable interrupts */ > + val = ls_lut_readl(pcie, PEX_PF0_PME_MES_IER); > + val |= PEX_PF0_PME_MES_IER_LDDIE | PEX_PF0_PME_MES_IER_HRDIE | > + PEX_PF0_PME_MES_IER_LUDIE; > + ls_lut_writel(pcie, PEX_PF0_PME_MES_IER, val); > + > + return 0; > +} > + > static const struct pci_epc_features* > ls_pcie_ep_get_features(struct dw_pcie_ep *ep) > { > @@ -125,6 +219,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > struct ls_pcie_ep *pcie; > struct pci_epc_features *ls_epc; > struct resource *dbi_base; > + int ret; > > pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL); > if (!pcie) > @@ -144,6 +239,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > pci->ops = pcie->drvdata->dw_pcie_ops; > > ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4); > + ls_epc->linkup_notifier = true; > > pcie->pci = pci; > pcie->ls_epc = ls_epc; > @@ -155,9 +251,15 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pci->ep.ops = &ls_pcie_ep_ops; > > + pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian"); > + > platform_set_drvdata(pdev, pcie); > > - return dw_pcie_ep_init(&pci->ep); > + ret = dw_pcie_ep_init(&pci->ep); > + if (ret) > + return ret; Double space after return. > + > + return ls_pcie_ep_interrupt_init(pcie, pdev); Double space after return. - Mani > } > > static struct platform_driver ls_pcie_ep_driver = { > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EDD6C77B73 for ; Sat, 6 May 2023 07:59:45 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4QD0ML3vb1z3fHR for ; Sat, 6 May 2023 17:59:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NQRCz43C; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2607:f8b0:4864:20::42e; helo=mail-pf1-x42e.google.com; envelope-from=manivannan.sadhasivam@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=NQRCz43C; dkim-atps=neutral Received: from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com [IPv6:2607:f8b0:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4QD0LL35nzz3bpn for ; Sat, 6 May 2023 17:58:47 +1000 (AEST) Received: by mail-pf1-x42e.google.com with SMTP id d2e1a72fcca58-643b60855c8so506157b3a.2 for ; Sat, 06 May 2023 00:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=NQRCz43CT3Am3q/I02DZVA0uqVsD/A7hjEDQjanb1XYTXvdhgJhATgrvGC/pEKtZ53 czw2fdaLr3ZB76Bw6/1H9YubH2IK2ap/hVjLZcCwc/Bs75xT96EizfONWjqYhcfQUGXl lwraI32bJREv8kOJ2O8aNUuSAN2Npeh9AFDoCzk6Nlrl4/YOkHEEPkdab4MOEyVV13gA pmRSW3ebFAApIF65wN8wyLf6i/mlBP2PvkqKZPsRG6iXzCyGZPKW9aKEANwVLl3jNrBy J2m0/s23etfyiSjR/Cbz+ylvBLzFaJBuHXbotkrFPdknOMrr4M6Na5Hoo2hysHuhtF81 kgLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=iRk62Ka8kvgrVBWgBgT/+8tA7ILd6RpS6R+I8mULJMW+orL+pPysFix7WGi5sdLTtC 5/XfcUD3Dr38niXqArxjNqSYeyUbAPw24iyWGX3IP4g2aIHYFAR0wH24YquGs1Btiwr7 hYE/fhPKXz9/LUQZQNNCkbsCRbC+PKbd/LdulepeaVqcj1C3Xh7Aqx3HE67kJAOst6Kc kOy7etmeas59qGKeGRd1Q6tG9x4HWlkSUrYzgWhzQV00L0B7fBRrt0CvbqTvOTYcTcLA HKnRGxBdpIIWKfSCo4jagBmsP82eoQ78GMvmLhSwzdTeHFZhohlGCTXESCoGkKsMFHZT vkCA== X-Gm-Message-State: AC+VfDyQqYHYFCORBX0a/QeHeH/dOuAd4+bcUM5Xvkr4TlKTOyMBKHxA AGTqqfeublloKcoQu8O2oHJq X-Google-Smtp-Source: ACHHUZ6s1Jzex0YPfLJUb6h3oibL3F+U2pv0j40QoSsQ4BhKF3WctKGX8jpyOyBkUm482uYZcTvusw== X-Received: by 2002:a05:6a00:1686:b0:643:a35d:b8dc with SMTP id k6-20020a056a00168600b00643a35db8dcmr5053349pfc.28.1683359924874; Sat, 06 May 2023 00:58:44 -0700 (PDT) Received: from thinkpad ([120.138.12.87]) by smtp.gmail.com with ESMTPSA id h16-20020aa786d0000000b0063b8f33cb81sm2728451pfo.93.2023.05.06.00.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 00:58:44 -0700 (PDT) Date: Sat, 6 May 2023 13:28:37 +0530 From: Manivannan Sadhasivam To: Frank Li Subject: Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support Message-ID: <20230506075837.GA9238@thinkpad> References: <20230501144807.1616244-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230501144807.1616244-1-Frank.Li@nxp.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , imx@lists.linux.dev, Rob Herring , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Lorenzo Pieralisi , open list , Minghuan Lian , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Roy Zang , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , Mingkai Hu Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, May 01, 2023 at 10:48:06AM -0400, Frank Li wrote: > Layerscape has PME interrupt, which can be used as linkup notifier. > Set CFG_READY bit when linkup detected. Where are you setting this bit? > > Signed-off-by: Xiaowei Bao > Signed-off-by: Frank Li > --- > Change from v1 to v2 > - pme -> PME > - irq -> IRQ > - update dev_info message according to Bjorn's suggestion > - remove '.' at error message > > .../pci/controller/dwc/pci-layerscape-ep.c | 104 +++++++++++++++++- > 1 file changed, 103 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c b/drivers/pci/controller/dwc/pci-layerscape-ep.c > index c640db60edc6..e974fbe3b6d8 100644 > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c > @@ -18,6 +18,20 @@ > > #include "pcie-designware.h" > > +#define PEX_PF0_CONFIG 0xC0014 > +#define PEX_PF0_CFG_READY BIT(0) > + > +/* PEX PFa PCIE PME and message interrupt registers*/ > +#define PEX_PF0_PME_MES_DR 0xC0020 > +#define PEX_PF0_PME_MES_DR_LUD BIT(7) > +#define PEX_PF0_PME_MES_DR_LDD BIT(9) > +#define PEX_PF0_PME_MES_DR_HRD BIT(10) > + > +#define PEX_PF0_PME_MES_IER 0xC0028 > +#define PEX_PF0_PME_MES_IER_LUDIE BIT(7) > +#define PEX_PF0_PME_MES_IER_LDDIE BIT(9) > +#define PEX_PF0_PME_MES_IER_HRDIE BIT(10) > + > #define to_ls_pcie_ep(x) dev_get_drvdata((x)->dev) > > struct ls_pcie_ep_drvdata { > @@ -30,8 +44,88 @@ struct ls_pcie_ep { > struct dw_pcie *pci; > struct pci_epc_features *ls_epc; > const struct ls_pcie_ep_drvdata *drvdata; > + bool big_endian; > + int irq; > }; > > +static u32 ls_lut_readl(struct ls_pcie_ep *pcie, u32 offset) > +{ > + struct dw_pcie *pci = pcie->pci; > + > + if (pcie->big_endian) > + return ioread32be(pci->dbi_base + offset); > + else > + return ioread32(pci->dbi_base + offset); > +} > + > +static void ls_lut_writel(struct ls_pcie_ep *pcie, u32 offset, > + u32 value) Above function argument could be wrapped within 80 columns. > +{ > + struct dw_pcie *pci = pcie->pci; > + > + if (pcie->big_endian) > + iowrite32be(value, pci->dbi_base + offset); > + else > + iowrite32(value, pci->dbi_base + offset); > +} > + > +static irqreturn_t ls_pcie_ep_event_handler(int irq, void *dev_id) > +{ > + struct ls_pcie_ep *pcie = (struct ls_pcie_ep *)dev_id; No need to do explicit typecase for void pointer. > + struct dw_pcie *pci = pcie->pci; > + u32 val, cfg; > + > + val = ls_lut_readl(pcie, PEX_PF0_PME_MES_DR); > + if (!val) > + return IRQ_NONE; > + > + if (val & PEX_PF0_PME_MES_DR_LUD) { > + cfg = ls_lut_readl(pcie, PEX_PF0_CONFIG); > + cfg |= PEX_PF0_CFG_READY; > + ls_lut_writel(pcie, PEX_PF0_CONFIG, cfg); > + dw_pcie_ep_linkup(&pci->ep); > + > + dev_info(pci->dev, "Link up\n"); These messages could be demoted to dev_dbg() logs. > + } else if (val & PEX_PF0_PME_MES_DR_LDD) { > + dev_info(pci->dev, "Link down\n"); > + } else if (val & PEX_PF0_PME_MES_DR_HRD) { > + dev_info(pci->dev, "Hot reset\n"); > + } > + > + ls_lut_writel(pcie, PEX_PF0_PME_MES_DR, val); You should clear the interrupts before processing. > + > + return IRQ_HANDLED; > +} > + > +static int ls_pcie_ep_interrupt_init(struct ls_pcie_ep *pcie, > + struct platform_device *pdev) > +{ > + u32 val; > + int ret; > + > + pcie->irq = platform_get_irq_byname(pdev, "pme"); > + if (pcie->irq < 0) { > + dev_err(&pdev->dev, "Can't get 'pme' IRQ\n"); PME > + return pcie->irq; > + } > + > + ret = devm_request_irq(&pdev->dev, pcie->irq, > + ls_pcie_ep_event_handler, IRQF_SHARED, > + pdev->name, pcie); Again, please wrap to fit the 80 column width. > + if (ret) { > + dev_err(&pdev->dev, "Can't register PCIe IRQ\n"); > + return ret; > + } > + > + /* Enable interrupts */ > + val = ls_lut_readl(pcie, PEX_PF0_PME_MES_IER); > + val |= PEX_PF0_PME_MES_IER_LDDIE | PEX_PF0_PME_MES_IER_HRDIE | > + PEX_PF0_PME_MES_IER_LUDIE; > + ls_lut_writel(pcie, PEX_PF0_PME_MES_IER, val); > + > + return 0; > +} > + > static const struct pci_epc_features* > ls_pcie_ep_get_features(struct dw_pcie_ep *ep) > { > @@ -125,6 +219,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > struct ls_pcie_ep *pcie; > struct pci_epc_features *ls_epc; > struct resource *dbi_base; > + int ret; > > pcie = devm_kzalloc(dev, sizeof(*pcie), GFP_KERNEL); > if (!pcie) > @@ -144,6 +239,7 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > pci->ops = pcie->drvdata->dw_pcie_ops; > > ls_epc->bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4); > + ls_epc->linkup_notifier = true; > > pcie->pci = pci; > pcie->ls_epc = ls_epc; > @@ -155,9 +251,15 @@ static int __init ls_pcie_ep_probe(struct platform_device *pdev) > > pci->ep.ops = &ls_pcie_ep_ops; > > + pcie->big_endian = of_property_read_bool(dev->of_node, "big-endian"); > + > platform_set_drvdata(pdev, pcie); > > - return dw_pcie_ep_init(&pci->ep); > + ret = dw_pcie_ep_init(&pci->ep); > + if (ret) > + return ret; Double space after return. > + > + return ls_pcie_ep_interrupt_init(pcie, pdev); Double space after return. - Mani > } > > static struct platform_driver ls_pcie_ep_driver = { > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம் From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E29DCC77B73 for ; Sat, 6 May 2023 07:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/TUgrE/bHCPJP9yiASenwzkBDgxxEAo05LVkH5+2CN4=; b=TFRRG0iigG0C/W A+hBrIj+dlCpcGMYXmoHD0VLVsYRzaKGgFCmR227InyVHQadB4bD46Uaod7vOTK+EQy+EIbHqCWXE Zzb7zh77thRODpFPfcabq4MpB7Z6LaXJSYhT6N3h/cw/oUAc/hZ3R5CZf5JamKYa/ToXueUlO1n1x vcepdJ4OUhPByWBR0ryBS+XXFAVXb6wUAAekncftczFkiEouWRNEVLQxvW0epL5wQ2nSnNiBnm/QO 7CLvJ5HHCueOD5oTpE4j+vYIu5+gSDZC/awsqGRaK2+HXLRbLi5Lea6UkPFrbjis5c7QZlClkvwX6 Yv9WhdvVyjd3Ua2Bh4Sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pvCof-00CqNB-1T; Sat, 06 May 2023 07:58:53 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pvCob-00CqM6-3D for linux-arm-kernel@lists.infradead.org; Sat, 06 May 2023 07:58:51 +0000 Received: by mail-pf1-x432.google.com with SMTP id d2e1a72fcca58-643bb9cdd6eso204423b3a.1 for ; Sat, 06 May 2023 00:58:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=NQRCz43CT3Am3q/I02DZVA0uqVsD/A7hjEDQjanb1XYTXvdhgJhATgrvGC/pEKtZ53 czw2fdaLr3ZB76Bw6/1H9YubH2IK2ap/hVjLZcCwc/Bs75xT96EizfONWjqYhcfQUGXl lwraI32bJREv8kOJ2O8aNUuSAN2Npeh9AFDoCzk6Nlrl4/YOkHEEPkdab4MOEyVV13gA pmRSW3ebFAApIF65wN8wyLf6i/mlBP2PvkqKZPsRG6iXzCyGZPKW9aKEANwVLl3jNrBy J2m0/s23etfyiSjR/Cbz+ylvBLzFaJBuHXbotkrFPdknOMrr4M6Na5Hoo2hysHuhtF81 kgLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683359925; x=1685951925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=9N1rc/5Fi1FR3PRXTb19F/ZGifHjTtA2q2Cae30+mlA=; b=T4ksQ75GaE0skOxG9HjTS5g/H/gBEBw0THK2pAX/TUz9V4jscsxSiWyvSKSYa7VdH5 yOk2z6Wmh1kgk1Zw8RthMmvtnKGcsChO8AlhrI9mOQNXLmAuamCWQsb9mwC6HVydXyCz /203pkBzRIhtnmAIar+fTE+FV+OnrsmWwXMRk21PscjY41l7m9oD3p4f6zRPnPIZ+bVE cFCNidXpHQ2nPxNMr/iAG4KQTP3igR2cNqc680qbtyW3qqxV5ls3ZL3l/z7NHDAWUQf2 9h2052GpMBmLC6IFgzHKhYeNDfsM6DvznLHQ3iWL/wVoiQRQ+fBqiFvrkQdGY3f8KqK3 UyAQ== X-Gm-Message-State: AC+VfDyfWU+jhN2yv/ZLFVBJmICmxEAkMAuhUjH99GEsiKcZRmjoFFj3 6Npw2ZItuQFJpRedSPKB2oBz X-Google-Smtp-Source: ACHHUZ6s1Jzex0YPfLJUb6h3oibL3F+U2pv0j40QoSsQ4BhKF3WctKGX8jpyOyBkUm482uYZcTvusw== X-Received: by 2002:a05:6a00:1686:b0:643:a35d:b8dc with SMTP id k6-20020a056a00168600b00643a35db8dcmr5053349pfc.28.1683359924874; Sat, 06 May 2023 00:58:44 -0700 (PDT) Received: from thinkpad ([120.138.12.87]) by smtp.gmail.com with ESMTPSA id h16-20020aa786d0000000b0063b8f33cb81sm2728451pfo.93.2023.05.06.00.58.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 May 2023 00:58:44 -0700 (PDT) Date: Sat, 6 May 2023 13:28:37 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: Minghuan Lian , Mingkai Hu , Roy Zang , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "open list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , "moderated list:PCI DRIVER FOR FREESCALE LAYERSCAPE" , open list , imx@lists.linux.dev Subject: Re: [PATCH v2 1/1] PCI: layerscape: Add the endpoint linkup notifier support Message-ID: <20230506075837.GA9238@thinkpad> References: <20230501144807.1616244-1-Frank.Li@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230501144807.1616244-1-Frank.Li@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230506_005850_041721_AA44FBD5 X-CRM114-Status: GOOD ( 28.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBNYXkgMDEsIDIwMjMgYXQgMTA6NDg6MDZBTSAtMDQwMCwgRnJhbmsgTGkgd3JvdGU6 Cj4gTGF5ZXJzY2FwZSBoYXMgUE1FIGludGVycnVwdCwgd2hpY2ggY2FuIGJlIHVzZWQgYXMgbGlu a3VwIG5vdGlmaWVyLgo+IFNldCBDRkdfUkVBRFkgYml0IHdoZW4gbGlua3VwIGRldGVjdGVkLgoK V2hlcmUgYXJlIHlvdSBzZXR0aW5nIHRoaXMgYml0PwoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBYaWFv d2VpIEJhbyA8eGlhb3dlaS5iYW9AbnhwLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBGcmFuayBMaSA8 RnJhbmsuTGlAbnhwLmNvbT4KPiAtLS0KPiBDaGFuZ2UgZnJvbSB2MSB0byB2Mgo+IC0gcG1lIC0+ IFBNRQo+IC0gaXJxIC0+IElSUQo+IC0gdXBkYXRlIGRldl9pbmZvIG1lc3NhZ2UgYWNjb3JkaW5n IHRvIEJqb3JuJ3Mgc3VnZ2VzdGlvbgo+IC0gcmVtb3ZlICcuJyBhdCBlcnJvciBtZXNzYWdlCj4g CQo+ICAuLi4vcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLWVwLmMgICAgfCAxMDQg KysrKysrKysrKysrKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMDMgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3 Yy9wY2ktbGF5ZXJzY2FwZS1lcC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci9kd2MvcGNpLWxh eWVyc2NhcGUtZXAuYwo+IGluZGV4IGM2NDBkYjYwZWRjNi4uZTk3NGZiZTNiNmQ4IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvcGNpL2NvbnRyb2xsZXIvZHdjL3BjaS1sYXllcnNjYXBlLWVwLmMKPiAr KysgYi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL2R3Yy9wY2ktbGF5ZXJzY2FwZS1lcC5jCj4gQEAg LTE4LDYgKzE4LDIwIEBACj4gIAo+ICAjaW5jbHVkZSAicGNpZS1kZXNpZ253YXJlLmgiCj4gIAo+ ICsjZGVmaW5lIFBFWF9QRjBfQ09ORklHCQkJMHhDMDAxNAo+ICsjZGVmaW5lIFBFWF9QRjBfQ0ZH X1JFQURZCQlCSVQoMCkKPiArCj4gKy8qIFBFWCBQRmEgUENJRSBQTUUgYW5kIG1lc3NhZ2UgaW50 ZXJydXB0IHJlZ2lzdGVycyovCj4gKyNkZWZpbmUgUEVYX1BGMF9QTUVfTUVTX0RSCQkweEMwMDIw Cj4gKyNkZWZpbmUgUEVYX1BGMF9QTUVfTUVTX0RSX0xVRAkJQklUKDcpCj4gKyNkZWZpbmUgUEVY X1BGMF9QTUVfTUVTX0RSX0xERAkJQklUKDkpCj4gKyNkZWZpbmUgUEVYX1BGMF9QTUVfTUVTX0RS X0hSRAkJQklUKDEwKQo+ICsKPiArI2RlZmluZSBQRVhfUEYwX1BNRV9NRVNfSUVSCQkweEMwMDI4 Cj4gKyNkZWZpbmUgUEVYX1BGMF9QTUVfTUVTX0lFUl9MVURJRQlCSVQoNykKPiArI2RlZmluZSBQ RVhfUEYwX1BNRV9NRVNfSUVSX0xERElFCUJJVCg5KQo+ICsjZGVmaW5lIFBFWF9QRjBfUE1FX01F U19JRVJfSFJESUUJQklUKDEwKQo+ICsKPiAgI2RlZmluZSB0b19sc19wY2llX2VwKHgpCWRldl9n ZXRfZHJ2ZGF0YSgoeCktPmRldikKPiAgCj4gIHN0cnVjdCBsc19wY2llX2VwX2RydmRhdGEgewo+ IEBAIC0zMCw4ICs0NCw4OCBAQCBzdHJ1Y3QgbHNfcGNpZV9lcCB7Cj4gIAlzdHJ1Y3QgZHdfcGNp ZQkJCSpwY2k7Cj4gIAlzdHJ1Y3QgcGNpX2VwY19mZWF0dXJlcwkJKmxzX2VwYzsKPiAgCWNvbnN0 IHN0cnVjdCBsc19wY2llX2VwX2RydmRhdGEgKmRydmRhdGE7Cj4gKwlib29sCQkJCWJpZ19lbmRp YW47Cj4gKwlpbnQJCQkJaXJxOwo+ICB9Owo+ICAKPiArc3RhdGljIHUzMiBsc19sdXRfcmVhZGwo c3RydWN0IGxzX3BjaWVfZXAgKnBjaWUsIHUzMiBvZmZzZXQpCj4gK3sKPiArCXN0cnVjdCBkd19w Y2llICpwY2kgPSBwY2llLT5wY2k7Cj4gKwo+ICsJaWYgKHBjaWUtPmJpZ19lbmRpYW4pCj4gKwkJ cmV0dXJuIGlvcmVhZDMyYmUocGNpLT5kYmlfYmFzZSArIG9mZnNldCk7Cj4gKwllbHNlCj4gKwkJ cmV0dXJuIGlvcmVhZDMyKHBjaS0+ZGJpX2Jhc2UgKyBvZmZzZXQpOwo+ICt9Cj4gKwo+ICtzdGF0 aWMgdm9pZCBsc19sdXRfd3JpdGVsKHN0cnVjdCBsc19wY2llX2VwICpwY2llLCB1MzIgb2Zmc2V0 LAo+ICsJCQkgIHUzMiB2YWx1ZSkKCkFib3ZlIGZ1bmN0aW9uIGFyZ3VtZW50IGNvdWxkIGJlIHdy YXBwZWQgd2l0aGluIDgwIGNvbHVtbnMuCgo+ICt7Cj4gKwlzdHJ1Y3QgZHdfcGNpZSAqcGNpID0g cGNpZS0+cGNpOwo+ICsKPiArCWlmIChwY2llLT5iaWdfZW5kaWFuKQo+ICsJCWlvd3JpdGUzMmJl KHZhbHVlLCBwY2ktPmRiaV9iYXNlICsgb2Zmc2V0KTsKPiArCWVsc2UKPiArCQlpb3dyaXRlMzIo dmFsdWUsIHBjaS0+ZGJpX2Jhc2UgKyBvZmZzZXQpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgaXJxcmV0 dXJuX3QgbHNfcGNpZV9lcF9ldmVudF9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmRldl9pZCkKPiAr ewo+ICsJc3RydWN0IGxzX3BjaWVfZXAgKnBjaWUgPSAoc3RydWN0IGxzX3BjaWVfZXAgKilkZXZf aWQ7CgpObyBuZWVkIHRvIGRvIGV4cGxpY2l0IHR5cGVjYXNlIGZvciB2b2lkIHBvaW50ZXIuCgo+ ICsJc3RydWN0IGR3X3BjaWUgKnBjaSA9IHBjaWUtPnBjaTsKPiArCXUzMiB2YWwsIGNmZzsKPiAr Cj4gKwl2YWwgPSBsc19sdXRfcmVhZGwocGNpZSwgUEVYX1BGMF9QTUVfTUVTX0RSKTsKPiArCWlm ICghdmFsKQo+ICsJCXJldHVybiBJUlFfTk9ORTsKPiArCj4gKwlpZiAodmFsICYgUEVYX1BGMF9Q TUVfTUVTX0RSX0xVRCkgewo+ICsJCWNmZyA9IGxzX2x1dF9yZWFkbChwY2llLCBQRVhfUEYwX0NP TkZJRyk7Cj4gKwkJY2ZnIHw9IFBFWF9QRjBfQ0ZHX1JFQURZOwo+ICsJCWxzX2x1dF93cml0ZWwo cGNpZSwgUEVYX1BGMF9DT05GSUcsIGNmZyk7Cj4gKwkJZHdfcGNpZV9lcF9saW5rdXAoJnBjaS0+ ZXApOwo+ICsKPiArCQlkZXZfaW5mbyhwY2ktPmRldiwgIkxpbmsgdXBcbiIpOwoKVGhlc2UgbWVz c2FnZXMgY291bGQgYmUgZGVtb3RlZCB0byBkZXZfZGJnKCkgbG9ncy4KCj4gKwl9IGVsc2UgaWYg KHZhbCAmIFBFWF9QRjBfUE1FX01FU19EUl9MREQpIHsKPiArCQlkZXZfaW5mbyhwY2ktPmRldiwg IkxpbmsgZG93blxuIik7Cj4gKwl9IGVsc2UgaWYgKHZhbCAmIFBFWF9QRjBfUE1FX01FU19EUl9I UkQpIHsKPiArCQlkZXZfaW5mbyhwY2ktPmRldiwgIkhvdCByZXNldFxuIik7Cj4gKwl9Cj4gKwo+ ICsJbHNfbHV0X3dyaXRlbChwY2llLCBQRVhfUEYwX1BNRV9NRVNfRFIsIHZhbCk7CgpZb3Ugc2hv dWxkIGNsZWFyIHRoZSBpbnRlcnJ1cHRzIGJlZm9yZSBwcm9jZXNzaW5nLgoKPiArCj4gKwlyZXR1 cm4gSVJRX0hBTkRMRUQ7Cj4gK30KPiArCj4gK3N0YXRpYyBpbnQgbHNfcGNpZV9lcF9pbnRlcnJ1 cHRfaW5pdChzdHJ1Y3QgbHNfcGNpZV9lcCAqcGNpZSwKPiArCQkJCSAgICAgc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPiArewo+ICsJdTMyIHZhbDsKPiArCWludCByZXQ7Cj4gKwo+ICsJ cGNpZS0+aXJxID0gcGxhdGZvcm1fZ2V0X2lycV9ieW5hbWUocGRldiwgInBtZSIpOwo+ICsJaWYg KHBjaWUtPmlycSA8IDApIHsKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJDYW4ndCBnZXQgJ3Bt ZScgSVJRXG4iKTsKClBNRQoKPiArCQlyZXR1cm4gcGNpZS0+aXJxOwo+ICsJfQo+ICsKPiArCXJl dCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgcGNpZS0+aXJxLAo+ICsJCQkgICAgICAg bHNfcGNpZV9lcF9ldmVudF9oYW5kbGVyLCBJUlFGX1NIQVJFRCwKPiArCQkJICAgICAgIHBkZXYt Pm5hbWUsIHBjaWUpOwoKQWdhaW4sIHBsZWFzZSB3cmFwIHRvIGZpdCB0aGUgODAgY29sdW1uIHdp ZHRoLgoKPiArCWlmIChyZXQpIHsKPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJDYW4ndCByZWdp c3RlciBQQ0llIElSUVxuIik7Cj4gKwkJcmV0dXJuIHJldDsKPiArCX0KPiArCj4gKwkvKiBFbmFi bGUgaW50ZXJydXB0cyAqLwo+ICsJdmFsID0gbHNfbHV0X3JlYWRsKHBjaWUsIFBFWF9QRjBfUE1F X01FU19JRVIpOwo+ICsJdmFsIHw9ICBQRVhfUEYwX1BNRV9NRVNfSUVSX0xERElFIHwgUEVYX1BG MF9QTUVfTUVTX0lFUl9IUkRJRSB8Cj4gKwkJUEVYX1BGMF9QTUVfTUVTX0lFUl9MVURJRTsKPiAr CWxzX2x1dF93cml0ZWwocGNpZSwgUEVYX1BGMF9QTUVfTUVTX0lFUiwgdmFsKTsKPiArCj4gKwly ZXR1cm4gMDsKPiArfQo+ICsKPiAgc3RhdGljIGNvbnN0IHN0cnVjdCBwY2lfZXBjX2ZlYXR1cmVz Kgo+ICBsc19wY2llX2VwX2dldF9mZWF0dXJlcyhzdHJ1Y3QgZHdfcGNpZV9lcCAqZXApCj4gIHsK PiBAQCAtMTI1LDYgKzIxOSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGxzX3BjaWVfZXBfcHJvYmUo c3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAgCXN0cnVjdCBsc19wY2llX2VwICpwY2ll Owo+ICAJc3RydWN0IHBjaV9lcGNfZmVhdHVyZXMgKmxzX2VwYzsKPiAgCXN0cnVjdCByZXNvdXJj ZSAqZGJpX2Jhc2U7Cj4gKwlpbnQgcmV0Owo+ICAKPiAgCXBjaWUgPSBkZXZtX2t6YWxsb2MoZGV2 LCBzaXplb2YoKnBjaWUpLCBHRlBfS0VSTkVMKTsKPiAgCWlmICghcGNpZSkKPiBAQCAtMTQ0LDYg KzIzOSw3IEBAIHN0YXRpYyBpbnQgX19pbml0IGxzX3BjaWVfZXBfcHJvYmUoc3RydWN0IHBsYXRm b3JtX2RldmljZSAqcGRldikKPiAgCXBjaS0+b3BzID0gcGNpZS0+ZHJ2ZGF0YS0+ZHdfcGNpZV9v cHM7Cj4gIAo+ICAJbHNfZXBjLT5iYXJfZml4ZWRfNjRiaXQgPSAoMSA8PCBCQVJfMikgfCAoMSA8 PCBCQVJfNCk7Cj4gKwlsc19lcGMtPmxpbmt1cF9ub3RpZmllciA9IHRydWU7Cj4gIAo+ICAJcGNp ZS0+cGNpID0gcGNpOwo+ICAJcGNpZS0+bHNfZXBjID0gbHNfZXBjOwo+IEBAIC0xNTUsOSArMjUx LDE1IEBAIHN0YXRpYyBpbnQgX19pbml0IGxzX3BjaWVfZXBfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldikKPiAgCj4gIAlwY2ktPmVwLm9wcyA9ICZsc19wY2llX2VwX29wczsKPiAg Cj4gKwlwY2llLT5iaWdfZW5kaWFuID0gb2ZfcHJvcGVydHlfcmVhZF9ib29sKGRldi0+b2Zfbm9k ZSwgImJpZy1lbmRpYW4iKTsKPiArCj4gIAlwbGF0Zm9ybV9zZXRfZHJ2ZGF0YShwZGV2LCBwY2ll KTsKPiAgCj4gLQlyZXR1cm4gZHdfcGNpZV9lcF9pbml0KCZwY2ktPmVwKTsKPiArCXJldCA9IGR3 X3BjaWVfZXBfaW5pdCgmcGNpLT5lcCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiAgcmV0OwoK RG91YmxlIHNwYWNlIGFmdGVyIHJldHVybi4KCj4gKwo+ICsJcmV0dXJuICBsc19wY2llX2VwX2lu dGVycnVwdF9pbml0KHBjaWUsIHBkZXYpOwoKRG91YmxlIHNwYWNlIGFmdGVyIHJldHVybi4KCi0g TWFuaQoKPiAgfQo+ICAKPiAgc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbHNfcGNpZV9l cF9kcml2ZXIgPSB7Cj4gLS0gCj4gMi4zNC4xCj4gCgotLSAK4K6u4K6j4K6/4K614K6j4K+N4K6j 4K6p4K+NIOCumuCupOCuvuCumuCuv+CuteCuruCvjQoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGlu dXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQu b3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=