From: Petr Vorel <pvorel@suse.cz>
To: Hao Zeng <zenghao@kylinos.cn>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] testcases:Fix the failure of shell script to get path
Date: Sat, 6 May 2023 20:55:22 +0200 [thread overview]
Message-ID: <20230506185522.GA105601@pevik> (raw)
In-Reply-To: <20230506092702.203395-1-zenghao@kylinos.cn>
Hi Hao,
> For example:
> in the file testcases/kernel/controllers/cpuset/cpuset_funcs.sh,
> if the path is obtained by
> find "$CPUSET" -type d | sort | sed -n '2,$p' | tac | while read subdir,
> the escaped characters will be lost,and by adding the -r option,
> the escaped characters will be kept as they are without escaping
> The errors are as follows:
> /opt/ltp/testcases/bin/cpuset_funcs.sh:line178:
> /dev/cpuset/machine.slice/machine-qemux2d157x2dzhx2dsxf.scope/vcpu7/tasks:
> The file or directory is not available
> rmdir: delete
> '/dev/cpuset/machine.slice/machine-qemux2d157x2dzhx2dsxf.scope/vcpu7'
> Failure: The file or directory is not available
> cpuset_memory_pressure 1 TFAIL: Couldn't remove subdir -
> /opt/ltp/testcases/bin/cpuset_funcs.sh:line178:
> /dev/cpuset/machine.slice/machine-qemux2d157x2dzhx2dsxf.scope/vcpu7/tasks:
> The file or directory is not available
> rmdir: delete
> '/dev/cpuset/machine.slice/machine-qemux2d157x2dzhx2dsxf.scope/vcpu7'
> Failure: The file or directory is not available
> cpuset_memory_pressure 1 TFAIL: Couldn't remove subdir -
> Signed-off-by: Hao Zeng <zenghao@kylinos.cn>
> Suggested-by: Petr Vorel <pvorel@suse.cz>
> ---
> testcases/kernel/controllers/cpuset/cpuset_funcs.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index 87ba7da1f..0cfa0c17e 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -184,7 +184,7 @@ cleanup()
> echo $CHILDREN_VALUE > $CLONE_CHILDREN
> echo $SCHED_LB_VALUE > $SCHED_LB
> - find "$CPUSET" -type d | sort | sed -n '2,$p' | tac | while read subdir
> + find "$CPUSET" -type d | sort | sed -n '2,$p' | tac | while read -r subdir
Is it testcases/kernel/controllers/cpuctl_fj/run_cpuctl_test_fj.sh working
without -r ? I'd expect it'd be also needed (it was in your v1 patch [1]).
I only didn't want to take
testcases/open_posix_testsuite/scripts/generate-makefiles.sh because it does not
work with /dev/cpuset/.
Kind regards,
Petr
[1] https://lore.kernel.org/ltp/6b2a7ceb.4466.1874a537430.Coremail.crawler2015@163.com/
> do
> while read pid
> do
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2023-05-06 18:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-06 9:27 [LTP] [PATCH v2] testcases:Fix the failure of shell script to get path Hao Zeng
2023-05-06 18:55 ` Petr Vorel [this message]
2023-05-08 1:43 ` Hao Zeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230506185522.GA105601@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=zenghao@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.