From: Stefan Hajnoczi <stefanha@redhat.com>
To: Mads Ynddal <m.ynddal@samsung.com>
Cc: Mads Ynddal <mads@ynddal.dk>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Cleber Rosa <crosa@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH v2 01/12] simpletrace: Improve parsing of sys.argv; fix files never closed.
Date: Mon, 8 May 2023 11:08:21 -0400 [thread overview]
Message-ID: <20230508150821.GD581920@fedora> (raw)
In-Reply-To: <0713AFC1-299C-47A2-8746-49AD8C70185D@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]
On Mon, May 08, 2023 at 01:18:40PM +0000, Mads Ynddal wrote:
> > simpletrace.py is both a command-line tool and a Python module. The
> > Python module has a public API that people's scripts may rely on. Let's
> > avoid breaking API changes unless necessary so that existing scripts
> > that import simpletrace continue to work.
> >
> > It's not very clear what is a public API in simpletrace.py, the file
> > should really have __all__ = ['Analyzer', 'process', 'run'].
> > Nevertheless, Analyzer's doc comments mention process() and the
> > process() function itself also has doc comments, so it's a public API.
> >
> > Please drop this change to avoid breaking the public API.
>
> I agree, I'll revert the changes. I can add an `__all__` too.
>
> I'd like to avoid having the same `open`, `read_trace_header` and `read_events`
> multiple places. Would it be acceptable to let `process` be more of a stub and
> move the logic to an internal `_process` function maybe?
Yes, as long as the existing public API doesn't change that would be
fine.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-05-08 15:08 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 9:23 [PATCH v2 00/12] simpletrace: refactor and general improvements Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 01/12] simpletrace: Improve parsing of sys.argv; fix files never closed Mads Ynddal
2023-05-04 18:03 ` Stefan Hajnoczi
2023-05-08 13:18 ` Mads Ynddal
2023-05-08 15:08 ` Stefan Hajnoczi [this message]
2023-05-02 9:23 ` [PATCH v2 02/12] simpletrace: Annotate magic constants from QEMU code Mads Ynddal
2023-05-09 14:34 ` Stefan Hajnoczi
2023-05-15 6:51 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 03/12] simpletrace: changed naming of edict and idtoname to improve readability Mads Ynddal
2023-05-09 14:36 ` Stefan Hajnoczi
2023-05-02 9:23 ` [PATCH v2 04/12] simpletrace: update code for Python 3.11 Mads Ynddal
2023-05-09 14:38 ` Stefan Hajnoczi
2023-05-15 6:47 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 05/12] simpletrace: Changed Analyzer class to become context-manager Mads Ynddal
2023-05-09 14:40 ` Stefan Hajnoczi
2023-05-15 7:48 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 06/12] simpletrace: Simplify construction of tracing methods Mads Ynddal
2023-05-09 14:40 ` Stefan Hajnoczi
2023-05-15 8:11 ` Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 07/12] simpletrace: Improved error handling on struct unpack Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 08/12] simpletrace: define exception and add handling Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 09/12] simpletrace: Refactor to separate responsibilities Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 10/12] MAINTAINERS: add maintainer of simpletrace.py Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 11/12] scripts/analyse-locks-simpletrace.py: changed iteritems() to items() Mads Ynddal
2023-05-02 9:23 ` [PATCH v2 12/12] scripts/analyse-locks-simpletrace.py: reflect changes to process in simpletrace.py Mads Ynddal
2023-05-03 13:55 ` [PATCH v2 00/12] simpletrace: refactor and general improvements John Snow
2023-05-08 13:28 ` Mads Ynddal
2023-05-08 15:16 ` Stefan Hajnoczi
2023-05-10 19:14 ` John Snow
2023-05-04 17:48 ` Stefan Hajnoczi
2023-05-04 17:53 ` John Snow
2023-05-08 15:07 ` Stefan Hajnoczi
2023-05-08 16:50 ` Mads Ynddal
2023-05-09 14:33 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230508150821.GD581920@fedora \
--to=stefanha@redhat.com \
--cc=crosa@redhat.com \
--cc=jsnow@redhat.com \
--cc=m.ynddal@samsung.com \
--cc=mads@ynddal.dk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.