From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1583DC77B7F for ; Mon, 8 May 2023 15:16:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw2b2-0007SR-2M; Mon, 08 May 2023 11:16:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw2b0-0007Ou-3f for qemu-devel@nongnu.org; Mon, 08 May 2023 11:16:14 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw2ay-0001t7-Lb for qemu-devel@nongnu.org; Mon, 08 May 2023 11:16:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683558971; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wjoz0XYCIYzrDp0sBYHkwhxckM7uU+3J5KP70kx8KDk=; b=aRwpvvwqf+1raIJA5zm1pnk5qm2+dUc0ZF9meddFhaVkHdI2YkIUBaKbgl+zHhnlulPpGO htViJTncIkSzbG5WBW+9Pd83SfE2+sGcxBwrgGanD0/udLYy0Iuj5slwAEGm6ajvGSoSu2 96LHIXDLU6Ip5gr2qjfaogLY+N9Vdrc= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-481-bQoF76bVM-CVb0RhWL8Mmw-1; Mon, 08 May 2023 11:16:10 -0400 X-MC-Unique: bQoF76bVM-CVb0RhWL8Mmw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 050AC2812942; Mon, 8 May 2023 15:16:10 +0000 (UTC) Received: from localhost (unknown [10.39.195.40]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6942C492B00; Mon, 8 May 2023 15:16:09 +0000 (UTC) Date: Mon, 8 May 2023 11:16:07 -0400 From: Stefan Hajnoczi To: Mads Ynddal Cc: John Snow , qemu-devel , Cleber Rosa Subject: Re: [PATCH v2 00/12] simpletrace: refactor and general improvements Message-ID: <20230508151607.GE581920@fedora> References: <20230502092339.27341-1-mads@ynddal.dk> <8690784A-9AC1-4D4C-B398-CDE0B047064D@ynddal.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JZISbZMk2kylE0KR" Content-Disposition: inline In-Reply-To: <8690784A-9AC1-4D4C-B398-CDE0B047064D@ynddal.dk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org --JZISbZMk2kylE0KR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 08, 2023 at 03:28:04PM +0200, Mads Ynddal wrote: >=20 > > A question for you: do you think it's possible to move simpletrace into= qemu/python/utils? This requires cleaning up the code to some fairly pedan= tic standards, but helps protect it against rot as we change target python = versions.=20 > >=20 > > No problem if that's too much to ask. just want to know if you had look= ed into it. >=20 > Potentially, this would be possible. But `simpletrace.py` imports > `qemu/scripts/tracetool/`, so that would have to be moved as well, or ins= talled > as a package. I haven't touched the `tracetool` code itself, so I'm not s= ure how > feasible it is (i.e. how many other places use `tracetool`). tracetool is only used by QEMU's build system to generate code from the trace-events files. In theory it's possible to move it. I'm not sure I understand the purpose of moving it to python/. What infrastructure does python/ provide that's not available to simpletrace.py in its current location? Stefan --JZISbZMk2kylE0KR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEhpWov9P5fNqsNXdanKSrs4Grc8gFAmRZEjcACgkQnKSrs4Gr c8ijaAf/ezEUID9L4c8JJT2n/xTDlqZ5BkAUR9AWrYk8eFvUA2Xi3kRDUaX+0pVl QIDpI8HmXLmK7Xeqg+0bM0MJCRt/Wc0ksPh/98NYeslPOuwSCM470FwOUdFehKX8 wrIUrElEaMW6TcI1KImDoFMHEMJfIyTkjhMXWGM8eqvO7ZTDqmLbwdUJ+X9fd5GE 94+NkE9c5/wrCbUwPlItEbI0aBbep8UggfFMyfdq8BTCxDL41thSLftopxZ0CDar 7L2n6aylnDK5U2C9sAFmWKtAbCjwHgFxpSOthdbNntcLFnG8kguRZAB0p3YWrSZg ZcxVhGVhYzSRThvWNIaac8NFscqtTA== =kvYS -----END PGP SIGNATURE----- --JZISbZMk2kylE0KR--