From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:4810:b0:965:a47e:1721 with SMTP id w16csp2266133ejq; Mon, 8 May 2023 12:41:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Rlh+DZ9FhD9YMMlO2jsJVvw/tzCh0D4GYtpNKnJ5yrFbdDvhl5N5cAl2UEsQbXdtiSxac X-Received: by 2002:ac8:7c56:0:b0:3f3:8720:4f8c with SMTP id o22-20020ac87c56000000b003f387204f8cmr10907136qtv.18.1683574914497; Mon, 08 May 2023 12:41:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683574914; cv=none; d=google.com; s=arc-20160816; b=Cfdjg9K1lx39tSVcWsD9LFl37zArid6jU5Bau5EReJz3qkXDfP9OsiCyjlyM8T6EZz giA2asLMUjop6q84ipv6MDS+Psj6FGiMprl1MFaak0Arrk61JrCS6lc2sy76Cg31e6XU 096O6cnVhQyk0l8Ssyl+BR+LWlRJUx5qoJWU52pNsf1nobdAGCXgvdnlzGaSmoombHYw 30xiWwChn0/pMkb0aT2uUpW/ozLvGn0ooOlIqggWVRHBRezrn3hSIbVS49XpbAbpSk+g 1rJLEjkNeHe4IM8FTmnWDbGnwt4yKdDAkSFSUHrWUxro0uwc2W0HKgM0WQHGio8p6r9F 3hOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=AS9hwBRrLwBVLGSk1mb4Bne5rt3KNvkrXmBGX3oVvjI=; b=toOVBJgOEJQ4/n5x3II64SB+myV4iOnrfkh+p34vQWQokc9sxYNN0uhFRV4+9PXAF7 /3Jq9rO0hvYlEq4fYUPq6MQtAB7F88ycE4Q8bxvRdyetnfUh75TVNWTk7xtzrELxwYbH 1glXfgfVee7op1KHoGm/O3n7lgCUg8LBZj5KGDGjTau0M7sZwjP8Dq3Q/e44P23WH0hN exosB0p1MqeKvS5rjlFhBVt7nU0M9tbYXH/PZqOrjgbmXPvPBmeyfG+VHohZmDP2kv2I 0jdsvY9NRhDuEtIyJxe3hGIdmA2ZzePABkGX6JM/dqRQr0EDEfTteTm0QRrm1a4ESpTb QRnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=VPZfiOtQ; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id y7-20020ac85f47000000b003f390fd027asi811077qta.686.2023.05.08.12.41.54 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 08 May 2023 12:41:54 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=VPZfiOtQ; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pw6jb-0000XS-Mu; Mon, 08 May 2023 15:41:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pw6jZ-0000UA-Pr; Mon, 08 May 2023 15:41:21 -0400 Received: from mail-lf1-x136.google.com ([2a00:1450:4864:20::136]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pw6jX-0002RM-UB; Mon, 08 May 2023 15:41:21 -0400 Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-4f22908a082so2559581e87.1; Mon, 08 May 2023 12:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683574877; x=1686166877; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AS9hwBRrLwBVLGSk1mb4Bne5rt3KNvkrXmBGX3oVvjI=; b=VPZfiOtQhfi8Nvu9+I6RxDGr0QsuG2c7neu8f05uiJa3707aVP1hFvhIi6CwQR/Uvi 3ss54ThRKHlJmM4b3MYYAgr8kQSJdnaezGfbv8dWFE97kUXQSGk21aSoKYFnMmBBchaf SAw+jxkpnkWBgDPhLMfz8XbotLevOsFbe1lZV2cvvkvhlAX3Zz2V18EWzDpScSHIRHg1 N49SZZRm8J/Tl4xOUVK2BkzEzzJBR37fVVe9B5GmqiM3qdMxHvqQr9pBsA1WAK6sg1Xn r7pCG9GlpkjqHpQYWqu48pYla7aXMoA2Y6pS9zigflqhvrSTVRqgtveg5w8JXp42L/yZ Rlug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683574877; x=1686166877; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AS9hwBRrLwBVLGSk1mb4Bne5rt3KNvkrXmBGX3oVvjI=; b=NYNo4pGnU0ocd7xRD6fFi5rLgHLSiwHJzx03mTi8sAaYxTK2WGI5V142RfHlCiSaSl BfrM8X2tVXFeyvjdxSTGfZRFAW+U3EyOyKnxOBhvvP3kEGAJAnqQD7dBRihkzhY/Mt+6 3TV1dsRx1CGvAAfU4LAOVmf8ekkiIycKXW6yHqIMpggUvZ7W6stk/6Pw+mOvhSdjdG7S R3GucY7WKNlAfYQO+2nwMVYW/XZ9Q5uG1TC1jgOeE+7eoCYkCnEEvs6Ov7Pn1P6u3DtV vn0xe+g81upJRwZwkD1ZBxB/+j/DkMfDx6okjXQVuk3+yOluuKaqIjoyaLLcBQFBiS6n PpFQ== X-Gm-Message-State: AC+VfDwIlvIW0oSXgJFK172I1ujTpQqrSI1ZAjEo4Ku3HJicjUC6omZO ILDGY4FmVphSO/s7cirfoeU= X-Received: by 2002:a19:760f:0:b0:4ed:d5b0:7fd9 with SMTP id c15-20020a19760f000000b004edd5b07fd9mr60675lff.19.1683574877506; Mon, 08 May 2023 12:41:17 -0700 (PDT) Received: from fralle-msi (217-76-87-243.cust.bredband2.com. [217.76.87.243]) by smtp.gmail.com with ESMTPSA id b20-20020ac247f4000000b004eb0dcc52ddsm82350lfp.41.2023.05.08.12.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 12:41:17 -0700 (PDT) Date: Mon, 8 May 2023 21:41:15 +0200 From: Francisco Iglesias To: Thomas Huth Cc: qemu-devel@nongnu.org, "Edgar E. Iglesias" , Alistair Francis , Jason Wang , qemu-arm@nongnu.org, Peter Maydell Subject: Re: [PATCH] hw/net: Move xilinx_ethlite.c to the target-independent source set Message-ID: <20230508194114.GC6984@fralle-msi> References: <20230508120314.59274-1-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230508120314.59274-1-thuth@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Received-SPF: pass client-ip=2a00:1450:4864:20::136; envelope-from=frasse.iglesias@gmail.com; helo=mail-lf1-x136.google.com X-Spam_score_int: -1020 X-Spam_score: -102.1 X-Spam_bar: --------------------------------------------------- X-Spam_report: (-102.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, USER_IN_WELCOMELIST=-0.01, USER_IN_WHITELIST=-100 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: UvCQgw6miMwb On [2023 May 08] Mon 14:03:14, Thomas Huth wrote: > Now that the tswap() functions are available for target-independent > code, too, we can move xilinx_ethlite.c from specific_ss to softmmu_ss > to avoid that we have to compile this file multiple times. > > Signed-off-by: Thomas Huth Reviewed-by: Francisco Iglesias > --- > hw/net/xilinx_ethlite.c | 2 +- > hw/net/meson.build | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c > index 99c22819ea..89f4f3b254 100644 > --- a/hw/net/xilinx_ethlite.c > +++ b/hw/net/xilinx_ethlite.c > @@ -25,7 +25,7 @@ > #include "qemu/osdep.h" > #include "qemu/module.h" > #include "qom/object.h" > -#include "cpu.h" /* FIXME should not use tswap* */ > +#include "exec/tswap.h" > #include "hw/sysbus.h" > #include "hw/irq.h" > #include "hw/qdev-properties.h" > diff --git a/hw/net/meson.build b/hw/net/meson.build > index e2be0654a1..a7860c5efe 100644 > --- a/hw/net/meson.build > +++ b/hw/net/meson.build > @@ -43,7 +43,7 @@ softmmu_ss.add(when: 'CONFIG_NPCM7XX', if_true: files('npcm7xx_emc.c')) > softmmu_ss.add(when: 'CONFIG_ETRAXFS', if_true: files('etraxfs_eth.c')) > softmmu_ss.add(when: 'CONFIG_COLDFIRE', if_true: files('mcf_fec.c')) > specific_ss.add(when: 'CONFIG_PSERIES', if_true: files('spapr_llan.c')) > -specific_ss.add(when: 'CONFIG_XILINX_ETHLITE', if_true: files('xilinx_ethlite.c')) > +softmmu_ss.add(when: 'CONFIG_XILINX_ETHLITE', if_true: files('xilinx_ethlite.c')) > > softmmu_ss.add(when: 'CONFIG_VIRTIO_NET', if_true: files('net_rx_pkt.c')) > specific_ss.add(when: 'CONFIG_VIRTIO_NET', if_true: files('virtio-net.c')) > -- > 2.31.1 > >