All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: kernel test robot <lkp@intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Dhruva Gole" <d-gole@ti.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Johan Hovold" <johan@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH v10 1/1] serial: core: Start managing serial controllers to enable runtime PM
Date: Tue, 9 May 2023 09:57:58 +0300	[thread overview]
Message-ID: <20230509065758.GZ14287@atomide.com> (raw)
In-Reply-To: <202305090752.w4XZxmsN-lkp@intel.com>

* kernel test robot <lkp@intel.com> [230508 23:13]:
> >> drivers/tty/serial/serial_base_bus.c:97:13: warning: variable 'id' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
>            } else if (type == &serial_port_type) {
>                       ^~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/tty/serial/serial_base_bus.c:102:77: note: uninitialized use occurs here
>            err = dev_set_name(&sbd->dev, "%s.%s.%d", type->name, dev_name(port->dev), id);
>                                                                                       ^~
>    drivers/tty/serial/serial_base_bus.c:97:9: note: remove the 'if' if its condition is always true
>            } else if (type == &serial_port_type) {
>                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/tty/serial/serial_base_bus.c:83:13: note: initialize the variable 'id' to silence this warning
>            int err, id;
>                       ^
>                        = 0
>    1 warning generated.

Thanks I'll just add else goto err_free_dev for unknown types.

Regards,

Tony

  reply	other threads:[~2023-05-09  6:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-08 11:03 [PATCH v10 1/1] serial: core: Start managing serial controllers to enable runtime PM Tony Lindgren
2023-05-08 12:11 ` Andy Shevchenko
2023-05-08 13:35   ` Tony Lindgren
2023-05-08 23:13 ` kernel test robot
2023-05-09  6:57   ` Tony Lindgren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-05-09  3:50 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509065758.GZ14287@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=d-gole@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=llvm@lists.linux.dev \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.