All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: syzbot <syzbot+3c6cac1550288f8e7060@syzkaller.appspotmail.com>,
	syzkaller-bugs@googlegroups.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Nhat Pham <nphamcs@gmail.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] workingset: add missing rcu_read_unlock() in lru_gen_refault()
Date: Tue, 9 May 2023 19:12:32 -0400	[thread overview]
Message-ID: <20230509231232.GA65434@cmpxchg.org> (raw)
In-Reply-To: <610781bc-cf11-fc89-a46f-87cb8235d439@I-love.SAKURA.ne.jp>

On Wed, May 10, 2023 at 07:22:55AM +0900, Tetsuo Handa wrote:
> syzbot is reporting sleep in RCU context, for commit d66c718d28ac
> ("workingset: refactor LRU refault to expose refault recency check")
> missed rcu_read_unlock().
> 
> Reported-by: syzbot <syzbot+3c6cac1550288f8e7060@syzkaller.appspotmail.com>
> Closes: https://syzkaller.appspot.com/bug?extid=3c6cac1550288f8e7060
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Fixes: d66c718d28ac ("workingset: refactor LRU refault to expose refault recency check")

Oops! Thanks for the fix.

Acked-by: Johannes Weiner <hannes@cmpxchg.org>


  reply	other threads:[~2023-05-09 23:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 11:45 [syzbot] [ext4?] BUG: sleeping function called from invalid context in alloc_buffer_head syzbot
2023-05-09 22:22 ` [PATCH] workingset: add missing rcu_read_unlock() in lru_gen_refault() Tetsuo Handa
2023-05-09 23:12   ` Johannes Weiner [this message]
2023-05-09 23:59   ` Nhat Pham
2023-05-10 18:59 ` [syzbot] [ext4?] BUG: sleeping function called from invalid context in alloc_buffer_head Theodore Ts'o
2023-05-10 18:59   ` syzbot
2023-05-10 19:03     ` Aleksandr Nogikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230509231232.GA65434@cmpxchg.org \
    --to=hannes@cmpxchg.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=syzbot+3c6cac1550288f8e7060@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.