From: Rohan McLure <rmclure@linux.ibm.com>
To: linuxppc-dev@lists.ozlabs.org
Cc: arnd@arndb.de, gautam@linux.ibm.com, npiggin@gmail.com,
Rohan McLure <rmclure@linux.ibm.com>
Subject: [PATCH v2 08/11] powerpc: Mark writes registering ipi to host cpu through kvm and polling
Date: Wed, 10 May 2023 13:31:14 +1000 [thread overview]
Message-ID: <20230510033117.1395895-9-rmclure@linux.ibm.com> (raw)
In-Reply-To: <20230510033117.1395895-1-rmclure@linux.ibm.com>
Mark writes to hypervisor ipi state so that KCSAN recognises these
asynchronous issue of kvmppc_{set,clear}_host_ipi to be intended, with
atomic writes. Mark asynchronous polls to this variable in
kvm_ppc_read_one_intr().
Signed-off-by: Rohan McLure <rmclure@linux.ibm.com>
---
v2: Add read-side annotations to both polling locations in
kvm_ppc_read_one_intr().
---
arch/powerpc/include/asm/kvm_ppc.h | 4 ++--
arch/powerpc/kvm/book3s_hv_builtin.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/include/asm/kvm_ppc.h b/arch/powerpc/include/asm/kvm_ppc.h
index bc57d058ad5b..d701df006c08 100644
--- a/arch/powerpc/include/asm/kvm_ppc.h
+++ b/arch/powerpc/include/asm/kvm_ppc.h
@@ -548,12 +548,12 @@ static inline void kvmppc_set_host_ipi(int cpu)
* pairs with the barrier in kvmppc_clear_host_ipi()
*/
smp_mb();
- paca_ptrs[cpu]->kvm_hstate.host_ipi = 1;
+ WRITE_ONCE(paca_ptrs[cpu]->kvm_hstate.host_ipi, 1);
}
static inline void kvmppc_clear_host_ipi(int cpu)
{
- paca_ptrs[cpu]->kvm_hstate.host_ipi = 0;
+ WRITE_ONCE(paca_ptrs[cpu]->kvm_hstate.host_ipi, 0);
/*
* order clearing of host_ipi flag vs. processing of IPI messages
*
diff --git a/arch/powerpc/kvm/book3s_hv_builtin.c b/arch/powerpc/kvm/book3s_hv_builtin.c
index da85f046377a..0f5b021fa559 100644
--- a/arch/powerpc/kvm/book3s_hv_builtin.c
+++ b/arch/powerpc/kvm/book3s_hv_builtin.c
@@ -406,7 +406,7 @@ static long kvmppc_read_one_intr(bool *again)
return 1;
/* see if a host IPI is pending */
- host_ipi = local_paca->kvm_hstate.host_ipi;
+ host_ipi = READ_ONCE(local_paca->kvm_hstate.host_ipi);
if (host_ipi)
return 1;
@@ -466,7 +466,7 @@ static long kvmppc_read_one_intr(bool *again)
* meantime. If it's clear, we bounce the interrupt to the
* guest
*/
- host_ipi = local_paca->kvm_hstate.host_ipi;
+ host_ipi = READ_ONCE(local_paca->kvm_hstate.host_ipi);
if (unlikely(host_ipi != 0)) {
/* We raced with the host,
* we need to resend that IPI, bummer
--
2.37.2
next prev parent reply other threads:[~2023-05-10 3:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 3:31 [PATCH v2 00/11] powerpc: KCSAN fix warnings and mark accesses Rohan McLure
2023-05-10 3:31 ` [PATCH v2 01/11] powerpc: qspinlock: Mark accesses to qnode lock checks Rohan McLure
2023-05-10 3:31 ` [PATCH v2 02/11] powerpc: qspinlock: Enforce qnode writes prior to publishing to queue Rohan McLure
2023-05-15 5:46 ` Nicholas Piggin
2023-05-10 3:31 ` [PATCH v2 03/11] asm-generic/mmiowb: Mark accesses to fix KCSAN warnings Rohan McLure
2023-05-12 2:20 ` Michael Ellerman
2023-05-15 5:48 ` Nicholas Piggin
2023-05-23 0:28 ` Rohan McLure
2023-05-23 0:36 ` Rohan McLure
2023-05-10 3:31 ` [PATCH v2 04/11] powerpc: Mark [h]ssr_valid accesses in check_return_regs_valid Rohan McLure
2023-05-10 3:31 ` [PATCH v2 05/11] powerpc: Mark accesses to power_save callback in arch_cpu_idle Rohan McLure
2023-05-15 5:50 ` Nicholas Piggin
2023-05-16 2:27 ` Rohan McLure
2023-05-10 3:31 ` [PATCH v2 06/11] powerpc: powernv: Fix KCSAN datarace warnings on idle_state contention Rohan McLure
2023-05-15 5:50 ` Nicholas Piggin
2023-05-10 3:31 ` [PATCH v2 07/11] powerpc: Annotate accesses to ipi message flags Rohan McLure
2023-05-15 5:51 ` Nicholas Piggin
2023-05-10 3:31 ` Rohan McLure [this message]
2023-05-15 5:53 ` [PATCH v2 08/11] powerpc: Mark writes registering ipi to host cpu through kvm and polling Nicholas Piggin
2023-05-15 22:19 ` Rohan McLure
2023-05-10 3:31 ` [PATCH v2 09/11] powerpc: powernv: Annotate data races in opal events Rohan McLure
2023-05-10 3:31 ` [PATCH v2 10/11] powerpc: powernv: Annotate asynchronous access to opal tokens Rohan McLure
2023-05-10 3:31 ` [PATCH v2 11/11] powerpc: Mark asynchronous accesses to irq_data Rohan McLure
2023-07-03 5:26 ` (subset) [PATCH v2 00/11] powerpc: KCSAN fix warnings and mark accesses Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510033117.1395895-9-rmclure@linux.ibm.com \
--to=rmclure@linux.ibm.com \
--cc=arnd@arndb.de \
--cc=gautam@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.