All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - tests: skip this testing without newer blkid
Date: Wed, 10 May 2023 14:22:32 +0000 (GMT)	[thread overview]
Message-ID: <20230510142232.04CCF385357B@sourceware.org> (raw)

Gitweb:        https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=bc28082b990bf752a2ce6ffa13aff9452c655ab8
Commit:        bc28082b990bf752a2ce6ffa13aff9452c655ab8
Parent:        d418fc14f48ba8feb3f5c561f5626a673aef4863
Author:        Zdenek Kabelac <zkabelac@redhat.com>
AuthorDate:    Wed May 10 11:45:50 2023 +0200
Committer:     Zdenek Kabelac <zkabelac@redhat.com>
CommitterDate: Wed May 10 16:19:46 2023 +0200

tests: skip this testing without newer blkid

Testing xfs --fs functionality needs new blkid.
---
 test/shell/lvresize-xfs.sh | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/test/shell/lvresize-xfs.sh b/test/shell/lvresize-xfs.sh
index 0a3b89012..7f3193941 100644
--- a/test/shell/lvresize-xfs.sh
+++ b/test/shell/lvresize-xfs.sh
@@ -45,6 +45,11 @@ mkdir -p "$mount_dir_space"
 lvcreate -n $lv -L 300M $vg
 mkfs.xfs "$DM_DEV_DIR/$vg/$lv"
 mount "$DM_DEV_DIR/$vg/$lv" "$mount_dir"
+
+# --fs tests require a libblkid version that shows FSLASTBLOCK
+# so exit 0 test here, if the feature is not present
+blkid -p "$DM_DEV_DIR/$vg/$lv" | grep FSLASTBLOCK || skip
+
 df --output=size "$mount_dir" |tee df1
 dd if=/dev/zero of="$mount_dir/zeros1" bs=1M count=10 oflag=direct
 lvextend -L+20M $vg/$lv


                 reply	other threads:[~2023-05-10 14:22 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230510142232.04CCF385357B@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.