From: Sam Ravnborg <sam@ravnborg.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: "Lee Jones" <lee@kernel.org>,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
"Maximilian Weigand" <mweigand@mweigand.net>
Subject: Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
Date: Wed, 10 May 2023 18:03:40 +0200 [thread overview]
Message-ID: <20230510160340.GA1180686@ravnborg.org> (raw)
In-Reply-To: <20230510085239.1253896-1-mweigand2017@gmail.com>
On Wed, May 10, 2023 at 10:52:39AM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: linux-pwm@vger.kernel.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>, "Lee Jones" <lee@kernel.org>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maximilian Weigand" <mweigand@mweigand.net>
Subject: Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
Date: Wed, 10 May 2023 18:03:40 +0200 [thread overview]
Message-ID: <20230510160340.GA1180686@ravnborg.org> (raw)
In-Reply-To: <20230510085239.1253896-1-mweigand2017@gmail.com>
On Wed, May 10, 2023 at 10:52:39AM +0200, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
Looks good.
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
next prev parent reply other threads:[~2023-05-10 16:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 8:52 [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Maximilian Weigand
2023-05-10 16:03 ` Sam Ravnborg [this message]
2023-05-10 16:03 ` Sam Ravnborg
2023-05-18 10:15 ` Lee Jones
2023-05-18 10:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510160340.GA1180686@ravnborg.org \
--to=sam@ravnborg.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mweigand2017@gmail.com \
--cc=mweigand@mweigand.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.