From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: lib/crypto/blake2s-selftest.c:564 blake2s_digest_test() warn: comparing different units: 'i < (8192 / 32 + (0))' 'byte < array_size'
Date: Thu, 11 May 2023 01:21:08 +0800 [thread overview]
Message-ID: <202305110117.wVzZP0cd-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Herbert Xu <herbert@gondor.apana.org.au>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 16a8829130ca22666ac6236178a6233208d425c3
commit: e20d5a22bd241c5084184bcf69dfb6eddc35417f crypto: lib/blake2s - Split up test function to halve stack usage
date: 4 months ago
:::::: branch date: 24 hours ago
:::::: commit date: 4 months ago
config: openrisc-randconfig-m031-20230509 (https://download.01.org/0day-ci/archive/20230511/202305110117.wVzZP0cd-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202305110117.wVzZP0cd-lkp@intel.com/
smatch warnings:
lib/crypto/blake2s-selftest.c:564 blake2s_digest_test() warn: comparing different units: 'i < (8192 / 32 + (0))' 'byte < array_size'
lib/crypto/blake2s-selftest.c:564 blake2s_digest_test() warn: comparing different units: 'i < (8192 / 32 + (0))' 'byte < array_size'
vim +564 lib/crypto/blake2s-selftest.c
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 547
e20d5a22bd241c Herbert Xu 2022-12-21 548 static bool __init noinline_for_stack blake2s_digest_test(void)
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 549 {
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 550 u8 key[BLAKE2S_KEY_SIZE];
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 551 u8 buf[ARRAY_SIZE(blake2s_testvecs)];
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 552 u8 hash[BLAKE2S_HASH_SIZE];
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 553 struct blake2s_state state;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 554 bool success = true;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 555 int i, l;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 556
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 557 key[0] = key[1] = 1;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 558 for (i = 2; i < sizeof(key); ++i)
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 559 key[i] = key[i - 2] + key[i - 1];
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 560
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 561 for (i = 0; i < sizeof(buf); ++i)
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 562 buf[i] = (u8)i;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 563
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 @564 for (i = l = 0; i < ARRAY_SIZE(blake2s_testvecs); l = (l + 37) % ++i) {
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 565 int outlen = 1 + i % BLAKE2S_HASH_SIZE;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 566 int keylen = (13 * i) % (BLAKE2S_KEY_SIZE + 1);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 567
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 568 blake2s(hash, buf, key + BLAKE2S_KEY_SIZE - keylen, outlen, i,
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 569 keylen);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 570 if (memcmp(hash, blake2s_testvecs[i], outlen)) {
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 571 pr_err("blake2s self-test %d: FAIL\n", i + 1);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 572 success = false;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 573 }
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 574
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 575 if (!keylen)
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 576 blake2s_init(&state, outlen);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 577 else
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 578 blake2s_init_key(&state, outlen,
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 579 key + BLAKE2S_KEY_SIZE - keylen,
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 580 keylen);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 581
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 582 blake2s_update(&state, buf, l);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 583 blake2s_update(&state, buf + l, i - l);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 584 blake2s_final(&state, hash);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 585 if (memcmp(hash, blake2s_testvecs[i], outlen)) {
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 586 pr_err("blake2s init/update/final self-test %d: FAIL\n",
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 587 i + 1);
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 588 success = false;
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 589 }
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 590 }
66d7fb94e4ffe5 Jason A. Donenfeld 2019-11-08 591
e20d5a22bd241c Herbert Xu 2022-12-21 592 return success;
e20d5a22bd241c Herbert Xu 2022-12-21 593 }
e20d5a22bd241c Herbert Xu 2022-12-21 594
:::::: The code at line 564 was first introduced by commit
:::::: 66d7fb94e4ffe5acc589e0b2b4710aecc1f07a28 crypto: blake2s - generic C library implementation and selftest
:::::: TO: Jason A. Donenfeld <Jason@zx2c4.com>
:::::: CC: Herbert Xu <herbert@gondor.apana.org.au>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-05-10 17:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305110117.wVzZP0cd-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.