From: kernel test robot <lkp@intel.com>
To: cros-kernel-buildreports@googlegroups.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: [android-common:android-4.19-stable 15107/29506] drivers/nvmem/core.c:347:5: warning: no previous prototype for 'nvmem_add_cells'
Date: Fri, 12 May 2023 07:15:52 +0800 [thread overview]
Message-ID: <202305120736.VdpP64Ta-lkp@intel.com> (raw)
Hi Bartosz,
FYI, the error/warning still remains.
tree: https://android.googlesource.com/kernel/common android-4.19-stable
head: 7cf5d82154dcd64ff75b69f3dc8dbff4ed2d2816
commit: e96a10625581a499e8a4218ef504f3f53918408b [15107/29506] UPSTREAM: nvmem: add support for cell info
config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20230512/202305120736.VdpP64Ta-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build):
git remote add android-common https://android.googlesource.com/kernel/common
git fetch --no-tags android-common android-4.19-stable
git checkout e96a10625581a499e8a4218ef504f3f53918408b
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=x86_64 olddefconfig
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/nvmem/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202305120736.VdpP64Ta-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/nvmem/core.c:347:5: warning: no previous prototype for 'nvmem_add_cells' [-Wmissing-prototypes]
347 | int nvmem_add_cells(struct nvmem_device *nvmem,
| ^~~~~~~~~~~~~~~
vim +/nvmem_add_cells +347 drivers/nvmem/core.c
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 337
b3db17e4b864e4 Andrew Lunn 2018-05-11 338 /**
b3db17e4b864e4 Andrew Lunn 2018-05-11 339 * nvmem_add_cells() - Add cell information to an nvmem device
b3db17e4b864e4 Andrew Lunn 2018-05-11 340 *
b3db17e4b864e4 Andrew Lunn 2018-05-11 341 * @nvmem: nvmem device to add cells to.
b3db17e4b864e4 Andrew Lunn 2018-05-11 342 * @info: nvmem cell info to add to the device
b3db17e4b864e4 Andrew Lunn 2018-05-11 343 * @ncells: number of cells in info
b3db17e4b864e4 Andrew Lunn 2018-05-11 344 *
b3db17e4b864e4 Andrew Lunn 2018-05-11 345 * Return: 0 or negative error code on failure.
b3db17e4b864e4 Andrew Lunn 2018-05-11 346 */
b3db17e4b864e4 Andrew Lunn 2018-05-11 @347 int nvmem_add_cells(struct nvmem_device *nvmem,
b3db17e4b864e4 Andrew Lunn 2018-05-11 348 const struct nvmem_cell_info *info,
b3db17e4b864e4 Andrew Lunn 2018-05-11 349 int ncells)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 350 {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 351 struct nvmem_cell **cells;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 352 int i, rval;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 353
b3db17e4b864e4 Andrew Lunn 2018-05-11 354 cells = kcalloc(ncells, sizeof(*cells), GFP_KERNEL);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 355 if (!cells)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 356 return -ENOMEM;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 357
b3db17e4b864e4 Andrew Lunn 2018-05-11 358 for (i = 0; i < ncells; i++) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 359 cells[i] = kzalloc(sizeof(**cells), GFP_KERNEL);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 360 if (!cells[i]) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 361 rval = -ENOMEM;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 362 goto err;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 363 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 364
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 365 rval = nvmem_cell_info_to_nvmem_cell(nvmem, &info[i], cells[i]);
287980e49ffc0f Arnd Bergmann 2016-05-27 366 if (rval) {
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 367 kfree(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 368 goto err;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 369 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 370
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 371 nvmem_cell_add(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 372 }
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 373
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 374 /* remove tmp array */
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 375 kfree(cells);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 376
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 377 return 0;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 378 err:
dfdf141429f089 Rasmus Villemoes 2016-02-08 379 while (i--)
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 380 nvmem_cell_drop(cells[i]);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 381
dfdf141429f089 Rasmus Villemoes 2016-02-08 382 kfree(cells);
dfdf141429f089 Rasmus Villemoes 2016-02-08 383
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 384 return rval;
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 385 }
b3db17e4b864e4 Andrew Lunn 2018-05-11 386 EXPORT_SYMBOL_GPL(nvmem_add_cells);
eace75cfdcf7d9 Srinivas Kandagatla 2015-07-27 387
:::::: The code at line 347 was first introduced by commit
:::::: b3db17e4b864e46ad150ebef69c0e0130a1c5fca drivers: nvmem: Export nvmem_add_cells()
:::::: TO: Andrew Lunn <andrew@lunn.ch>
:::::: CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
reply other threads:[~2023-05-11 23:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202305120736.VdpP64Ta-lkp@intel.com \
--to=lkp@intel.com \
--cc=cros-kernel-buildreports@googlegroups.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.