From: Oleg Nesterov <oleg@redhat.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: David Laight <David.Laight@ACULAB.COM>,
'Josh Poimboeuf' <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Vernon Lovejoy <vlovejoy@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86/show_trace_log_lvl: ensure stack pointer is aligned, again
Date: Fri, 12 May 2023 12:43:49 +0200 [thread overview]
Message-ID: <20230512104349.GA6220@redhat.com> (raw)
In-Reply-To: <20230512022059.ltlzs7irvbvoj2cl@treble>
On 05/11, Josh Poimboeuf wrote:
>
> I do like that better, except... put the initialization in the 'for':
>
> for (stack = stack ? : get_stack_pointer(task, regs);
> stack;
> stack = stack_info.next_sp) {
> const char ...
> stack = PTR_ALIGN(stack, sizeof(long));
>
please see v3.
Oleg.
prev parent reply other threads:[~2023-05-12 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 14:00 [PATCH] x86/show_trace_log_lvl: ensure stack pointer is aligned, again Oleg Nesterov
2023-04-28 4:31 ` Josh Poimboeuf
2023-04-28 6:55 ` Oleg Nesterov
2023-04-28 23:57 ` Josh Poimboeuf
2023-04-29 10:08 ` Oleg Nesterov
2023-04-30 11:59 ` David Laight
2023-04-30 19:00 ` Oleg Nesterov
2023-05-12 2:20 ` Josh Poimboeuf
2023-05-12 10:43 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230512104349.GA6220@redhat.com \
--to=oleg@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=jpoimboe@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vlovejoy@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.