Re: [Buildroot] [PATCH] package/qemu: allow building only the guest agent

From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: unixmania@gmail.com
Cc: Romain Naour <romain.naour@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/qemu: allow building only the guest agent
Date: Sat, 13 May 2023 10:25:26 +0200	[thread overview]
Message-ID: <20230513082526.GF2582048@scaer> (raw)
In-Reply-To: <20230322231511.551442-1-unixmania@gmail.com>

Carlos, All,

On 2023-03-22 20:15 -0300, unixmania@gmail.com spake thusly:
> From: Carlos Santos <unixmania@gmail.com>
> 
> Most of the tools are useful only on virtualization hosts. After the
> upgrade to QEMU 7.2.0, it is possible to build only quemu-ga, which
> makes more sense when we build guest VM images.
> 
> Also do not build the other tools by default if none of the emulators is
> selected, since the user does not necessarily wants them. Ideally, it
> should not be possible to select qemu without selecting at least one of
> the subcomponents but it is hard to guess what the user wants.
> 
> Signed-off-by: Carlos Santos <unixmania@gmail.com>

I am not very happy that this means we can end up with a cconfiguration
where nothing (meaningful) is installed, but fixing this becomes less
obvious...

So be it...

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
> NOTE
> 
> This was also possible on older QEMU versions, but required a trick to
> force compiling the code required to link qemu-ga without building the
> other tools:
> 
>    ./configure --enable-system --target-list="" --disable-tools --enable-guest-agent
> ---
>  package/qemu/Config.in | 8 +++++++-
>  package/qemu/qemu.mk   | 6 ++++++
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/package/qemu/Config.in b/package/qemu/Config.in
> index a446c0cf68..6a9b08648d 100644
> --- a/package/qemu/Config.in
> +++ b/package/qemu/Config.in
> @@ -26,7 +26,6 @@ menuconfig BR2_PACKAGE_QEMU
>  	depends on BR2_USE_MMU # fork()
>  	select BR2_PACKAGE_LIBGLIB2
>  	select BR2_PACKAGE_ZLIB
> -	select BR2_PACKAGE_QEMU_TOOLS if !BR2_PACKAGE_QEMU_SYSTEM && !BR2_PACKAGE_QEMU_LINUX_USER
>  	help
>  	  QEMU is a generic and open source machine emulator and
>  	  virtualizer.
> @@ -358,4 +357,11 @@ config BR2_PACKAGE_QEMU_TOOLS
>  	  Say 'y' here to include tools packaged with QEMU
>  	  (e.g. qemu-img).
>  
> +config BR2_PACKAGE_QEMU_GUEST_AGENT
> +	bool "Enable guest agent"
> +	help
> +	  Say 'y' here to include an agent to run on guests, which
> +	  communicates with the host over a virtio-serial channel
> +	  named "org.qemu.guest_agent.0".
> +
>  endif # BR2_PACKAGE_QEMU
> diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
> index 3cbeffe213..4194670bb0 100644
> --- a/package/qemu/qemu.mk
> +++ b/package/qemu/qemu.mk
> @@ -165,6 +165,12 @@ else
>  QEMU_OPTS += --disable-tools
>  endif
>  
> +ifeq ($(BR2_PACKAGE_QEMU_GUEST_AGENT),y)
> +QEMU_OPTS += --enable-guest-agent
> +else
> +QEMU_OPTS += --disable-guest-agent
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBFUSE3),y)
>  QEMU_OPTS += --enable-fuse --enable-fuse-lseek
>  QEMU_DEPENDENCIES += libfuse3
> -- 
> 2.31.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot