Re: [PATCH 2/3] ARM: dts: imx6qdl-mba6: add mac address for USB ethernet controller

[Shawn Guo <shawnguo@kernel.org>]

On Wed, May 03, 2023 at 01:31:11PM +0200, Alexander Stein wrote:
> The mac address is stored in mainboard eeprom.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm/boot/dts/imx6qdl-mba6.dtsi  | 16 ++++++++++++++++
>  arch/arm/boot/dts/imx6qdl-mba6a.dtsi |  6 ++++++
>  arch/arm/boot/dts/imx6qdl-mba6b.dtsi |  6 ++++++
>  3 files changed, 28 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6.dtsi b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> index 7b7e6c2ad190..9d90d7647024 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6.dtsi
> @@ -272,6 +272,22 @@ &uart5 {
>  &usbh1 {
>  	disable-over-current;
>  	status = "okay";
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	hub@1 {
> +		compatible = "usb424,2517";
> +		reg = <1>;
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		ethernet@1 {
> +			compatible = "usb424,9e00";
> +			reg = <1>;
> +			nvmem-cells = <&mba_mac_address>;
> +			nvmem-cell-names = "mac-address";
> +		};
> +	};
>  };
>  
>  &usbotg {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> index df8fa169e9f6..c3f3a25133ca 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6a.dtsi
> @@ -21,6 +21,12 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;

Incorrect indent?

Shawn

> +		};
>  	};
>  
>  	rtc0: rtc@68 {
> diff --git a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> index 7d1cd7454c7f..85866cfed965 100644
> --- a/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-mba6b.dtsi
> @@ -31,6 +31,12 @@ m24c64_57: eeprom@57 {
>  		compatible = "atmel,24c64";
>  		reg = <0x57>;
>  		pagesize = <32>;
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +
> +		mba_mac_address: mac-address@20 {
> +				reg = <0x20 0x6>;
> +		};
>  	};
>  
>  	rtc0: rtc@68 {
> -- 
> 2.34.1
>