From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BC15DF40 for ; Mon, 15 May 2023 16:35:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D68F5C433EF; Mon, 15 May 2023 16:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684168515; bh=ke6IBrxQa/Z0rVtosGv/WT0YqEmh9i+aENIf2DcZNzo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xZEvXXp6hyy3zn4EzfUCJ5KhYozHz3DErKzDixyiz5A3hpcRdj1+NfJjOLKba/aN+ vRBI3gUiygEzoqNPFeIFVZ1oP1dVab2Vfh/5T0Hm3or/NZDNJkbWLyq4JoGHbsc7N/ etLlGV6C+hadxj7OEGKaV7zn8KbJRibHgZewzMrY= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Liang He , Michael Ellerman , Sasha Levin Subject: [PATCH 4.14 057/116] macintosh/windfarm_smu_sat: Add missing of_node_put() Date: Mon, 15 May 2023 18:25:54 +0200 Message-Id: <20230515161700.163846425@linuxfoundation.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230515161658.228491273@linuxfoundation.org> References: <20230515161658.228491273@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Liang He [ Upstream commit 631cf002826007ab7415258ee647dcaf8845ad5a ] We call of_node_get() in wf_sat_probe() after sat is created, so we need the of_node_put() before *kfree(sat)*. Fixes: ac171c46667c ("[PATCH] powerpc: Thermal control for dual core G5s") Signed-off-by: Liang He Signed-off-by: Michael Ellerman Link: https://msgid.link/20230330033558.2562778-1-windhl@126.com Signed-off-by: Sasha Levin --- drivers/macintosh/windfarm_smu_sat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/macintosh/windfarm_smu_sat.c b/drivers/macintosh/windfarm_smu_sat.c index a0f61eb853c55..644e123510c52 100644 --- a/drivers/macintosh/windfarm_smu_sat.c +++ b/drivers/macintosh/windfarm_smu_sat.c @@ -172,6 +172,7 @@ static void wf_sat_release(struct kref *ref) if (sat->nr >= 0) sats[sat->nr] = NULL; + of_node_put(sat->node); kfree(sat); } -- 2.39.2