From: Lee Jones <lee@kernel.org>
To: Dylan Van Assche <me@dylanvanassche.be>
Cc: pavel@ucw.cz, quic_fenglinw@quicinc.com, trix@redhat.com,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org
Subject: Re: [PATCH 2/2] leds: flash: leds-qcom-flash: disable LED when changing brightness
Date: Mon, 15 May 2023 17:19:07 +0100 [thread overview]
Message-ID: <20230515161907.GA10825@google.com> (raw)
In-Reply-To: <20230507172941.364852-3-me@dylanvanassche.be>
On Sun, 07 May 2023, Dylan Van Assche wrote:
> The Qualcomm PMI8998 PMIC requires the LED to be disabled when configuring
> the brightness. Always disable the LED when setting the brightness and
> re-enable it afterwards.
>
> Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> ---
> drivers/leds/flash/leds-qcom-flash.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied, thanks
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-05-15 16:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-07 17:29 [PATCH 0/2] leds: flash: leds-qcom-flash: add PMI8998 support Dylan Van Assche
2023-05-07 17:29 ` [PATCH 1/2] " Dylan Van Assche
2023-05-15 16:18 ` Lee Jones
2023-05-07 17:29 ` [PATCH 2/2] leds: flash: leds-qcom-flash: disable LED when changing brightness Dylan Van Assche
2023-05-15 16:19 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515161907.GA10825@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=me@dylanvanassche.be \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=quic_fenglinw@quicinc.com \
--cc=trix@redhat.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.