From: Jakub Kicinski <kuba@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com,
alvaro.karsz@solid-run.com, eperezma@redhat.com,
xuanzhuo@linux.alibaba.com, david.marchand@redhat.com,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next V2 1/2] virtio-net: convert rx mode setting to use workqueue
Date: Tue, 16 May 2023 12:36:35 -0700 [thread overview]
Message-ID: <20230516123635.58a20bb0@kernel.org> (raw)
In-Reply-To: <CACGkMEvCHQLFbtB2fbF27oCd5fNSjUtUOS0q-Lx7=MeYR8KzRA@mail.gmail.com>
On Tue, 16 May 2023 12:17:50 +0800 Jason Wang wrote:
> > It's not reliable for other drivers but has been reliable for virtio.
> > I worry some software relied on this.
>
> It's probably fine since some device like vhost doesn't support this
> at all and we manage to survive for several years.
>
> > You are making good points though ... could we get some
> > maintainer's feedback on this?
>
> That would be helpful. Jakub, any input on this?
AFAIU the question is whether .ndo_set_rx_mode needs to be reliable
and instantaneous? I haven't heard any complaints for it not being
immediate, and most 10G+ NICs do the config via a workqueue.
I even have an "intern task" to implement a workqueue in the core,
for this to save the boilerplate code in the drivers.
next prev parent reply other threads:[~2023-05-16 19:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 6:40 [PATCH net-next V2 0/2] virtio-net: don't busy poll for cvq command Jason Wang
2023-04-13 6:40 ` Jason Wang
2023-04-13 6:40 ` [PATCH net-next V2 1/2] virtio-net: convert rx mode setting to use workqueue Jason Wang
2023-04-13 6:40 ` Jason Wang
2023-04-13 16:25 ` Michael S. Tsirkin
2023-04-13 16:25 ` Michael S. Tsirkin
2023-04-14 5:04 ` Jason Wang
2023-04-14 5:04 ` Jason Wang
2023-04-14 7:21 ` Michael S. Tsirkin
2023-04-14 7:21 ` Michael S. Tsirkin
2023-04-17 3:40 ` Jason Wang
2023-04-17 3:40 ` Jason Wang
2023-05-05 3:46 ` Jason Wang
2023-05-05 3:46 ` Jason Wang
2023-05-10 5:32 ` Michael S. Tsirkin
2023-05-10 5:32 ` Michael S. Tsirkin
2023-05-15 1:05 ` Jason Wang
2023-05-15 1:05 ` Jason Wang
2023-05-15 4:45 ` Michael S. Tsirkin
2023-05-15 4:45 ` Michael S. Tsirkin
2023-05-15 5:13 ` Jason Wang
2023-05-15 5:13 ` Jason Wang
2023-05-15 10:17 ` Michael S. Tsirkin
2023-05-15 10:17 ` Michael S. Tsirkin
2023-05-16 2:44 ` Jason Wang
2023-05-16 2:44 ` Jason Wang
2023-05-16 4:12 ` Michael S. Tsirkin
2023-05-16 4:12 ` Michael S. Tsirkin
2023-05-16 4:17 ` Jason Wang
2023-05-16 4:17 ` Jason Wang
2023-05-16 5:56 ` Michael S. Tsirkin
2023-05-16 5:56 ` Michael S. Tsirkin
2023-05-16 19:36 ` Jakub Kicinski [this message]
2023-04-13 6:40 ` [PATCH net-next V2 2/2] virtio-net: sleep instead of busy waiting for cvq command Jason Wang
2023-04-13 6:40 ` Jason Wang
2023-04-13 7:27 ` Xuan Zhuo
2023-04-13 7:27 ` Xuan Zhuo
2023-04-14 5:09 ` Jason Wang
2023-04-14 5:09 ` Jason Wang
2023-04-14 5:10 ` Jason Wang
2023-04-14 5:10 ` Jason Wang
2023-05-16 20:54 ` Michael S. Tsirkin
2023-05-16 20:54 ` Michael S. Tsirkin
2023-05-17 0:50 ` Jason Wang
2023-05-17 0:50 ` Jason Wang
2023-04-13 13:02 ` [PATCH net-next V2 0/2] virtio-net: don't busy poll " Maxime Coquelin
2023-04-13 13:02 ` Maxime Coquelin
2023-04-13 13:05 ` Maxime Coquelin
2023-04-13 13:05 ` Maxime Coquelin
2023-04-13 14:04 ` Jakub Kicinski
2023-04-14 4:53 ` Jason Wang
2023-04-14 4:53 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230516123635.58a20bb0@kernel.org \
--to=kuba@kernel.org \
--cc=alvaro.karsz@solid-run.com \
--cc=davem@davemloft.net \
--cc=david.marchand@redhat.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.