From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C1D9C7EE2A for ; Tue, 16 May 2023 15:21:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233766AbjEPPVI (ORCPT ); Tue, 16 May 2023 11:21:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233997AbjEPPU7 (ORCPT ); Tue, 16 May 2023 11:20:59 -0400 Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2202040E8; Tue, 16 May 2023 08:20:58 -0700 (PDT) Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34GFKhRJ047095; Tue, 16 May 2023 10:20:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1684250443; bh=jnLrcu0eOUoX1UidnkX2uPXFwv9flHOtRKmBMNOjhAI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bhckaHOEV0Vrwx7IZ+/23oJZnmI7dTTw665ZvvcCmCeGt5S9S4XBc4YFGjir2ZyTD vDU/4eZ6V7dEpdi4rI1g46EBeWcy2jbAG3cwzVfKcsWEnW3T33PSgtPs3fdp8/aKNP eFgI934y+kxcs9IAu6sF2r2CWAJCBftJh9COu98c= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34GFKhxm019444 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 May 2023 10:20:43 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 16 May 2023 10:20:43 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 10:20:43 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34GFKhJ7061028; Tue, 16 May 2023 10:20:43 -0500 Date: Tue, 16 May 2023 10:20:43 -0500 From: Nishanth Menon To: Markus Elfring CC: , , Santosh Shilimkar , Tero Kristo , , LKML Subject: Re: [cocci] [PATCH] firmware: ti_sci: Fix exception handling in ti_sci_probe() Message-ID: <20230516152043.bq2hnessstrhbc6s@distort> References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: kernel-janitors@vger.kernel.org On 22:10-20230405, Markus Elfring wrote: > Date: Wed, 5 Apr 2023 22:00:18 +0200 B4 does'nt pick this patch up cleanly. And for some reason, I get mangled patch from public-inbox as well :( a clean git-send-email might help. > > The label “out” was used to jump to another pointer check despite of Please use " for quotes. > the detail in the implementation of the function “ti_sci_probe” > that it was determined already that the corresponding variable > contained an error pointer because of a failed call of > the function “mbox_request_channel_byname”. > > * Thus use more appropriate labels instead. > > * Delete two redundant checks. > How about this: Optimize out the redundant pointer check in exit path of "out" using appropriate labels to jump in the error path > Drop the extra EoL > This issue was detected by using the Coccinelle software. Curious: what rule of coccicheck caught this? > > Fixes: aa276781a64a5f15ecc21e920960c5b1f84e5fee ("firmware: Add basic support for TI System Control Interface (TI-SCI) protocol") 12 char sha please. Please read Documentation/process/submitting-patches.rst > Signed-off-by: Markus Elfring > --- > drivers/firmware/ti_sci.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 039d92a595ec..77012d2f4160 100644 > --- a/drivers/firmware/ti_sci.c turns out as =2D-- instead of -- (might check the git format-patch output closer). > +++ b/drivers/firmware/ti_sci.c > @@ -3433,18 +3433,18 @@ static int ti_sci_probe(struct platform_device *pdev) > info->chan_rx = mbox_request_channel_byname(cl, "rx"); > if (IS_ERR(info->chan_rx)) { > ret = PTR_ERR(info->chan_rx); > - goto out; > + goto remove_debugfs; > } > > info->chan_tx = mbox_request_channel_byname(cl, "tx"); > if (IS_ERR(info->chan_tx)) { > ret = PTR_ERR(info->chan_tx); > - goto out; > + goto free_mbox_channel_rx; > } > ret = ti_sci_cmd_get_revision(info); > if (ret) { > dev_err(dev, "Unable to communicate with TISCI(%d)\n", ret); > - goto out; > + goto free_mbox_channel_tx; > } > > ti_sci_setup_ops(info); > @@ -3456,7 +3456,7 @@ static int ti_sci_probe(struct platform_device *pdev) > ret = register_restart_handler(&info->nb); > if (ret) { > dev_err(dev, "reboot registration fail(%d)\n", ret); > - goto out; > + goto free_mbox_channel_tx; > } > } > > @@ -3470,11 +3470,12 @@ static int ti_sci_probe(struct platform_device *pdev) > mutex_unlock(&ti_sci_list_mutex); > > return of_platform_populate(dev->of_node, NULL, NULL, dev); > -out: > - if (!IS_ERR(info->chan_tx)) > - mbox_free_channel(info->chan_tx); > - if (!IS_ERR(info->chan_rx)) > - mbox_free_channel(info->chan_rx); > + > +free_mbox_channel_tx: > + mbox_free_channel(info->chan_tx); > +free_mbox_channel_rx: > + mbox_free_channel(info->chan_rx); > +remove_debugfs: > debugfs_remove(info->d); > return ret; > } > -- > 2.40.0 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A6C83C77B7F for ; Tue, 16 May 2023 15:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0RuBCRigzHAUxLGnRJYXA639YC7dEt9YXsPzdEqAJ2g=; b=E8XBqL4afa0Vzk +6eXtCvEdgcnOUfPpMvXYeaJqMLOe43iO/tCqO58i2vOX3y4ep3SUjLee3FKsC0UfYpLurMwlLw4k SPF2KU95cng+kiOvqvV/U2n/2I08ON2UnOeZObcszXlu0GxWz/Nk5y4Zia0jHJzLoWXZHADh1yJDF pes11zAotkh7/m1DxjlKbsGJV4tRNgPPshRzRpxtLdmIAsCMZAkM3aJ7Cn+tS11n2hCk5VzUwqIVd ZVFYHhXdxD4B/M/salOV0MHUpldnwVl77Icc2lFDacy0PK0gC1h6GdVBs3dSpdSWOuYJy2KRwKMGT tRUc9/UbR9G11xOngAxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pywTy-006EGg-0P; Tue, 16 May 2023 15:20:58 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pywTv-006EFU-0m for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 15:20:56 +0000 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 34GFKhRJ047095; Tue, 16 May 2023 10:20:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1684250443; bh=jnLrcu0eOUoX1UidnkX2uPXFwv9flHOtRKmBMNOjhAI=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=bhckaHOEV0Vrwx7IZ+/23oJZnmI7dTTw665ZvvcCmCeGt5S9S4XBc4YFGjir2ZyTD vDU/4eZ6V7dEpdi4rI1g46EBeWcy2jbAG3cwzVfKcsWEnW3T33PSgtPs3fdp8/aKNP eFgI934y+kxcs9IAu6sF2r2CWAJCBftJh9COu98c= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 34GFKhxm019444 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 16 May 2023 10:20:43 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 16 May 2023 10:20:43 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 16 May 2023 10:20:43 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 34GFKhJ7061028; Tue, 16 May 2023 10:20:43 -0500 Date: Tue, 16 May 2023 10:20:43 -0500 From: Nishanth Menon To: Markus Elfring CC: , , Santosh Shilimkar , Tero Kristo , , LKML Subject: Re: [cocci] [PATCH] firmware: ti_sci: Fix exception handling in ti_sci_probe() Message-ID: <20230516152043.bq2hnessstrhbc6s@distort> References: <8f785de5-ebe2-edd9-2155-f440acacc643@web.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_082055_382690_8973CF15 X-CRM114-Status: GOOD ( 24.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjI6MTAtMjAyMzA0MDUsIE1hcmt1cyBFbGZyaW5nIHdyb3RlOgo+IERhdGU6IFdlZCwgNSBB cHIgMjAyMyAyMjowMDoxOCArMDIwMAoKQjQgZG9lcydudCBwaWNrIHRoaXMgcGF0Y2ggdXAgY2xl YW5seS4gQW5kIGZvciBzb21lIHJlYXNvbiwgSSBnZXQKbWFuZ2xlZCBwYXRjaCBmcm9tIHB1Ymxp Yy1pbmJveCBhcyB3ZWxsIDooIGEgY2xlYW4gZ2l0LXNlbmQtZW1haWwgbWlnaHQKaGVscC4KCj4g Cj4gVGhlIGxhYmVsIOKAnG91dOKAnSB3YXMgdXNlZCB0byBqdW1wIHRvIGFub3RoZXIgcG9pbnRl ciBjaGVjayBkZXNwaXRlIG9mCgpQbGVhc2UgdXNlICIgZm9yIHF1b3Rlcy4KCj4gdGhlIGRldGFp bCBpbiB0aGUgaW1wbGVtZW50YXRpb24gb2YgdGhlIGZ1bmN0aW9uIOKAnHRpX3NjaV9wcm9iZeKA nQo+IHRoYXQgaXQgd2FzIGRldGVybWluZWQgYWxyZWFkeSB0aGF0IHRoZSBjb3JyZXNwb25kaW5n IHZhcmlhYmxlCj4gY29udGFpbmVkIGFuIGVycm9yIHBvaW50ZXIgYmVjYXVzZSBvZiBhIGZhaWxl ZCBjYWxsIG9mCj4gdGhlIGZ1bmN0aW9uIOKAnG1ib3hfcmVxdWVzdF9jaGFubmVsX2J5bmFtZeKA nS4KCj4gCj4gKiBUaHVzIHVzZSBtb3JlIGFwcHJvcHJpYXRlIGxhYmVscyBpbnN0ZWFkLgo+IAo+ ICogRGVsZXRlIHR3byByZWR1bmRhbnQgY2hlY2tzLgo+IAoKSG93IGFib3V0IHRoaXM6CgpPcHRp bWl6ZSBvdXQgdGhlIHJlZHVuZGFudCBwb2ludGVyIGNoZWNrIGluIGV4aXQgcGF0aCBvZiAib3V0 IiB1c2luZwphcHByb3ByaWF0ZSBsYWJlbHMgdG8ganVtcCBpbiB0aGUgZXJyb3IgcGF0aAo+IApE cm9wIHRoZSBleHRyYSBFb0wKCj4gVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQgYnkgdXNpbmcgdGhl IENvY2NpbmVsbGUgc29mdHdhcmUuCgpDdXJpb3VzOiB3aGF0IHJ1bGUgb2YgY29jY2ljaGVjayBj YXVnaHQgdGhpcz8KCj4gCj4gRml4ZXM6IGFhMjc2NzgxYTY0YTVmMTVlY2MyMWU5MjA5NjBjNWIx Zjg0ZTVmZWUgKCJmaXJtd2FyZTogQWRkIGJhc2ljIHN1cHBvcnQgZm9yIFRJIFN5c3RlbSBDb250 cm9sIEludGVyZmFjZSAoVEktU0NJKSBwcm90b2NvbCIpCgoxMiBjaGFyIHNoYSBwbGVhc2UuIFBs ZWFzZSByZWFkIERvY3VtZW50YXRpb24vcHJvY2Vzcy9zdWJtaXR0aW5nLXBhdGNoZXMucnN0Cgo+ IFNpZ25lZC1vZmYtYnk6IE1hcmt1cyBFbGZyaW5nIDxlbGZyaW5nQHVzZXJzLnNvdXJjZWZvcmdl Lm5ldD4KPiAtLS0KPiAgZHJpdmVycy9maXJtd2FyZS90aV9zY2kuYyB8IDE5ICsrKysrKysrKyst LS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDkgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZmlybXdhcmUvdGlfc2NpLmMgYi9kcml2ZXJz L2Zpcm13YXJlL3RpX3NjaS5jCj4gaW5kZXggMDM5ZDkyYTU5NWVjLi43NzAxMmQyZjQxNjAgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9maXJtd2FyZS90aV9zY2kuYwp0dXJucyBvdXQgYXMgPTJELS0g aW5zdGVhZCBvZiAtLSAobWlnaHQgY2hlY2sgdGhlIGdpdCBmb3JtYXQtcGF0Y2gKb3V0cHV0IGNs b3NlcikuCgo+ICsrKyBiL2RyaXZlcnMvZmlybXdhcmUvdGlfc2NpLmMKPiBAQCAtMzQzMywxOCAr MzQzMywxOCBAQCBzdGF0aWMgaW50IHRpX3NjaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNl ICpwZGV2KQo+ICAJaW5mby0+Y2hhbl9yeCA9IG1ib3hfcmVxdWVzdF9jaGFubmVsX2J5bmFtZShj bCwgInJ4Iik7Cj4gIAlpZiAoSVNfRVJSKGluZm8tPmNoYW5fcngpKSB7Cj4gIAkJcmV0ID0gUFRS X0VSUihpbmZvLT5jaGFuX3J4KTsKPiAtCQlnb3RvIG91dDsKPiArCQlnb3RvIHJlbW92ZV9kZWJ1 Z2ZzOwo+ICAJfQo+IAo+ICAJaW5mby0+Y2hhbl90eCA9IG1ib3hfcmVxdWVzdF9jaGFubmVsX2J5 bmFtZShjbCwgInR4Iik7Cj4gIAlpZiAoSVNfRVJSKGluZm8tPmNoYW5fdHgpKSB7Cj4gIAkJcmV0 ID0gUFRSX0VSUihpbmZvLT5jaGFuX3R4KTsKPiAtCQlnb3RvIG91dDsKPiArCQlnb3RvIGZyZWVf bWJveF9jaGFubmVsX3J4Owo+ICAJfQo+ICAJcmV0ID0gdGlfc2NpX2NtZF9nZXRfcmV2aXNpb24o aW5mbyk7Cj4gIAlpZiAocmV0KSB7Cj4gIAkJZGV2X2VycihkZXYsICJVbmFibGUgdG8gY29tbXVu aWNhdGUgd2l0aCBUSVNDSSglZClcbiIsIHJldCk7Cj4gLQkJZ290byBvdXQ7Cj4gKwkJZ290byBm cmVlX21ib3hfY2hhbm5lbF90eDsKPiAgCX0KPiAKPiAgCXRpX3NjaV9zZXR1cF9vcHMoaW5mbyk7 Cj4gQEAgLTM0NTYsNyArMzQ1Niw3IEBAIHN0YXRpYyBpbnQgdGlfc2NpX3Byb2JlKHN0cnVjdCBw bGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAkJcmV0ID0gcmVnaXN0ZXJfcmVzdGFydF9oYW5kbGVy KCZpbmZvLT5uYik7Cj4gIAkJaWYgKHJldCkgewo+ICAJCQlkZXZfZXJyKGRldiwgInJlYm9vdCBy ZWdpc3RyYXRpb24gZmFpbCglZClcbiIsIHJldCk7Cj4gLQkJCWdvdG8gb3V0Owo+ICsJCQlnb3Rv IGZyZWVfbWJveF9jaGFubmVsX3R4Owo+ICAJCX0KPiAgCX0KPiAKPiBAQCAtMzQ3MCwxMSArMzQ3 MCwxMiBAQCBzdGF0aWMgaW50IHRpX3NjaV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpw ZGV2KQo+ICAJbXV0ZXhfdW5sb2NrKCZ0aV9zY2lfbGlzdF9tdXRleCk7Cj4gCj4gIAlyZXR1cm4g b2ZfcGxhdGZvcm1fcG9wdWxhdGUoZGV2LT5vZl9ub2RlLCBOVUxMLCBOVUxMLCBkZXYpOwo+IC1v dXQ6Cj4gLQlpZiAoIUlTX0VSUihpbmZvLT5jaGFuX3R4KSkKPiAtCQltYm94X2ZyZWVfY2hhbm5l bChpbmZvLT5jaGFuX3R4KTsKPiAtCWlmICghSVNfRVJSKGluZm8tPmNoYW5fcngpKQo+IC0JCW1i b3hfZnJlZV9jaGFubmVsKGluZm8tPmNoYW5fcngpOwo+ICsKPiArZnJlZV9tYm94X2NoYW5uZWxf dHg6Cj4gKwltYm94X2ZyZWVfY2hhbm5lbChpbmZvLT5jaGFuX3R4KTsKPiArZnJlZV9tYm94X2No YW5uZWxfcng6Cj4gKwltYm94X2ZyZWVfY2hhbm5lbChpbmZvLT5jaGFuX3J4KTsKPiArcmVtb3Zl X2RlYnVnZnM6Cj4gIAlkZWJ1Z2ZzX3JlbW92ZShpbmZvLT5kKTsKPiAgCXJldHVybiByZXQ7Cj4g IH0KPiAtLQo+IDIuNDAuMAo+IAoKLS0gClJlZ2FyZHMsCk5pc2hhbnRoIE1lbm9uCktleSAoMHhE REI1ODQ5RDE3MzYyNDlEKSAvIEZpbmdlcnByaW50OiBGOEEyIDg2OTMgNTRFQiA4MjMyIDE3QTMg IDFBMzQgRERCNSA4NDlEIDE3MzYgMjQ5RAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=