From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4C2C7EE24 for ; Tue, 16 May 2023 08:46:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231437AbjEPIq2 (ORCPT ); Tue, 16 May 2023 04:46:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231389AbjEPIq1 (ORCPT ); Tue, 16 May 2023 04:46:27 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0138C3C01; Tue, 16 May 2023 01:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684226786; x=1715762786; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QL+tBUOtTekpizs4IA8GnqHOaksmnf7OGlafEadIZKE=; b=OEcqNsWrVv2FC+6h2Y+KVOOC4l53dj47UVtMB/12/oc286jn+TlMPOQk QvC4AwzOyDGj6MKkrAXEJfi4fOv3sf8LQ+gC1ar1lavByXLzL4DYHB4Da MGteMyQZtZcGMZCrmWSxpjtDKbX6LiF361fXBfrzOPLIaABF45h3Ecqno emKAazza6x52//bFnnfPb01D06GgT+B4+og3h+4G9VNSbbtmHD1C9jLhv UXYhMJSRf4nzjefOFPLRZ762bXWMcvJcRauMIhA8Tm6sbV1CjeHavGg6L lxRza39jkJn0TDqkqNPzOg7UEsYJlU3+gijJ+aEm28X+YyID0sHaioRod A==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="351454167" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="351454167" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 01:46:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="704312325" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="704312325" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 16 May 2023 01:46:07 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pyqJq-0007H4-1m; Tue, 16 May 2023 08:46:06 +0000 Date: Tue, 16 May 2023 16:45:20 +0800 From: kernel test robot To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brendan.higgins@linux.dev, briannorris@chromium.org, catalin.marinas@arm.com, conor+dt@kernel.org, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, hal.feng@starfivetech.com, hasegawa-hitomi@fujitsu.com, j.neuschaefer@gmx.net, joel@jms.id.au, kernel@esmil.dk, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, p.zabel@pengutronix.de, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org Subject: Re: [PATCH v14 8/8] soc: amd: Add support for AMD Pensando SoC Controller Message-ID: <202305161642.PZQ4S8o2-lkp@intel.com> References: <20230515181606.65953-9-blarson@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515181606.65953-9-blarson@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Brad, kernel test robot noticed the following build warnings: [auto build test WARNING on e922ba281a8d84f640d8c8e18a385d032c19e185] url: https://github.com/intel-lab-lkp/linux/commits/Brad-Larson/dt-bindings-arm-add-AMD-Pensando-boards/20230516-032312 base: e922ba281a8d84f640d8c8e18a385d032c19e185 patch link: https://lore.kernel.org/r/20230515181606.65953-9-blarson%40amd.com patch subject: [PATCH v14 8/8] soc: amd: Add support for AMD Pensando SoC Controller config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230516/202305161642.PZQ4S8o2-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/48a90df35083d2f3788e171ff0af01ddc8cd871b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Brad-Larson/dt-bindings-arm-add-AMD-Pensando-boards/20230516-032312 git checkout 48a90df35083d2f3788e171ff0af01ddc8cd871b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/soc/amd/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305161642.PZQ4S8o2-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/soc/amd/pensando-ctrl.c: In function 'penctrl_ioctl': >> drivers/soc/amd/pensando-ctrl.c:91:36: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 91 | if (copy_from_user(tx_buf, (void __user *)msg->tx_buf, msg->len)) { | ^ drivers/soc/amd/pensando-ctrl.c:114:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 114 | if (copy_to_user((void __user *)msg->rx_buf, rx_buf, msg->len)) | ^ vim +91 drivers/soc/amd/pensando-ctrl.c 34 35 static long 36 penctrl_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 37 { 38 void __user *in_arg = (void __user *)arg; 39 struct penctrl_device *penctrl; 40 u8 tx_buf[PENCTRL_MAX_MSG_LEN]; 41 u8 rx_buf[PENCTRL_MAX_MSG_LEN]; 42 struct spi_transfer t[2] = {}; 43 struct penctrl_spi_xfer *msg; 44 struct spi_device *spi; 45 unsigned int num_msgs; 46 struct spi_message m; 47 u32 size; 48 int ret; 49 50 /* Check for a valid command */ 51 if (_IOC_TYPE(cmd) != PENCTRL_IOC_MAGIC) 52 return -ENOTTY; 53 54 if (_IOC_NR(cmd) > PENCTRL_IOC_MAXNR) 55 return -ENOTTY; 56 57 if (((_IOC_DIR(cmd) & _IOC_READ)) && !access_ok(in_arg, _IOC_SIZE(cmd))) 58 return -EFAULT; 59 60 if (((_IOC_DIR(cmd) & _IOC_WRITE)) && !access_ok(in_arg, _IOC_SIZE(cmd))) 61 return -EFAULT; 62 63 /* Get a reference to the SPI device */ 64 penctrl = filp->private_data; 65 if (!penctrl) 66 return -ESHUTDOWN; 67 68 spi = spi_dev_get(penctrl->spi); 69 if (!spi) 70 return -ESHUTDOWN; 71 72 /* Verify and prepare SPI message */ 73 size = _IOC_SIZE(cmd); 74 num_msgs = size / sizeof(struct penctrl_spi_xfer); 75 if (num_msgs > 2 || size == 0 || size % sizeof(struct penctrl_spi_xfer)) { 76 ret = -EINVAL; 77 goto out_unlock; 78 } 79 msg = memdup_user((struct penctrl_spi_xfer *)arg, size); 80 if (IS_ERR(msg)) { 81 ret = PTR_ERR(msg); 82 goto out_unlock; 83 } 84 if (msg->len > PENCTRL_MAX_MSG_LEN) { 85 ret = -EINVAL; 86 goto out_unlock; 87 } 88 89 t[0].tx_buf = tx_buf; 90 t[0].len = msg->len; > 91 if (copy_from_user(tx_buf, (void __user *)msg->tx_buf, msg->len)) { 92 ret = -EFAULT; 93 goto out_unlock; 94 } 95 if (num_msgs > 1) { 96 msg++; 97 if (msg->len > PENCTRL_MAX_MSG_LEN) { 98 ret = -EINVAL; 99 goto out_unlock; 100 } 101 t[1].rx_buf = rx_buf; 102 t[1].len = msg->len; 103 } 104 spi_message_init_with_transfers(&m, t, num_msgs); 105 106 /* Perform the transfer */ 107 mutex_lock(&spi_lock); 108 ret = spi_sync(spi, &m); 109 mutex_unlock(&spi_lock); 110 111 if (ret || (num_msgs == 1)) 112 goto out_unlock; 113 114 if (copy_to_user((void __user *)msg->rx_buf, rx_buf, msg->len)) 115 ret = -EFAULT; 116 117 out_unlock: 118 spi_dev_put(spi); 119 return ret; 120 } 121 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56D55C77B75 for ; Tue, 16 May 2023 08:46:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bfq+0C2GB1D9OOJhL4nfLBxJvlFdTGxCf6sxKeFRHH0=; b=ofFeXP99IY4Xjd 5QSASgtIqbI/3uwPfbmvVKJ7xGpKWclqRhcYHnlyqJmiorcbr5KJv1up4JppQ0y9dDRBr3bv+w5FY mBkdpTCcfKrLb0FwL0XEIRRPppWwNn26l6WFUnrwGUbQI0qYho/bhKmNyPEqIkBILI/SvnbpEHHdN rCZesrNTmyDITmF7Rtc+7jePWXXfVvrR9ipAlIedWmi41GGWlK6XITmhK7yyDmPqTFU4f/y0eju4h pzp7f9n9Bi5CCuu/tt00rAxCyJlrIrMp9WOzhKXGAgSsWSoXbzo+JYlAuVXT7uLgev7PNxa4LW7v/ dHu290YHPuCOt2KrATwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pyqKL-004ueA-0X; Tue, 16 May 2023 08:46:37 +0000 Received: from mga14.intel.com ([192.55.52.115]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pyqKI-004udL-2G for linux-arm-kernel@lists.infradead.org; Tue, 16 May 2023 08:46:36 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684226794; x=1715762794; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=QL+tBUOtTekpizs4IA8GnqHOaksmnf7OGlafEadIZKE=; b=M2bqD2VqgkjNsXtN36oYYkhJ/lXtTEpb5sZy3P78bPUPiinMXenaU6YT G2chGUORfK6MGV9my+W6FqvB/HhO3HoF5PbQekprh2EsSdfivKuR9oko0 MlqhPYLLd6NhnfSqpu+hwKnWRrKJl1wiHzj/bHs+hxJ4rPqdxlh91TvO1 xPk35wULNoI6Jr05ZkuXNT3OEyqFi37A50Zp8KgCeUMCJQO64TVIPkDCW thK56EzE3AuA8VQdtpBozpYRxv1qQp5Svg4Di42puYMTtWnjlf+aEz2F1 iMX9g2EIX2TPVQuDKCxTlGM1N6+wP6uNSArr/YyRG3vHzi59ey0bMkv2F A==; X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="351454173" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="351454173" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 May 2023 01:46:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10711"; a="704312325" X-IronPort-AV: E=Sophos;i="5.99,278,1677571200"; d="scan'208";a="704312325" Received: from lkp-server01.sh.intel.com (HELO dea6d5a4f140) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 16 May 2023 01:46:07 -0700 Received: from kbuild by dea6d5a4f140 with local (Exim 4.96) (envelope-from ) id 1pyqJq-0007H4-1m; Tue, 16 May 2023 08:46:06 +0000 Date: Tue, 16 May 2023 16:45:20 +0800 From: kernel test robot To: Brad Larson , linux-arm-kernel@lists.infradead.org Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, blarson@amd.com, brendan.higgins@linux.dev, briannorris@chromium.org, catalin.marinas@arm.com, conor+dt@kernel.org, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, hal.feng@starfivetech.com, hasegawa-hitomi@fujitsu.com, j.neuschaefer@gmx.net, joel@jms.id.au, kernel@esmil.dk, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, p.zabel@pengutronix.de, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org Subject: Re: [PATCH v14 8/8] soc: amd: Add support for AMD Pensando SoC Controller Message-ID: <202305161642.PZQ4S8o2-lkp@intel.com> References: <20230515181606.65953-9-blarson@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230515181606.65953-9-blarson@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230516_014634_749456_C2BD2DA3 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Brad, kernel test robot noticed the following build warnings: [auto build test WARNING on e922ba281a8d84f640d8c8e18a385d032c19e185] url: https://github.com/intel-lab-lkp/linux/commits/Brad-Larson/dt-bindings-arm-add-AMD-Pensando-boards/20230516-032312 base: e922ba281a8d84f640d8c8e18a385d032c19e185 patch link: https://lore.kernel.org/r/20230515181606.65953-9-blarson%40amd.com patch subject: [PATCH v14 8/8] soc: amd: Add support for AMD Pensando SoC Controller config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20230516/202305161642.PZQ4S8o2-lkp@intel.com/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/48a90df35083d2f3788e171ff0af01ddc8cd871b git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Brad-Larson/dt-bindings-arm-add-AMD-Pensando-boards/20230516-032312 git checkout 48a90df35083d2f3788e171ff0af01ddc8cd871b # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/soc/amd/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202305161642.PZQ4S8o2-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/soc/amd/pensando-ctrl.c: In function 'penctrl_ioctl': >> drivers/soc/amd/pensando-ctrl.c:91:36: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 91 | if (copy_from_user(tx_buf, (void __user *)msg->tx_buf, msg->len)) { | ^ drivers/soc/amd/pensando-ctrl.c:114:26: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 114 | if (copy_to_user((void __user *)msg->rx_buf, rx_buf, msg->len)) | ^ vim +91 drivers/soc/amd/pensando-ctrl.c 34 35 static long 36 penctrl_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 37 { 38 void __user *in_arg = (void __user *)arg; 39 struct penctrl_device *penctrl; 40 u8 tx_buf[PENCTRL_MAX_MSG_LEN]; 41 u8 rx_buf[PENCTRL_MAX_MSG_LEN]; 42 struct spi_transfer t[2] = {}; 43 struct penctrl_spi_xfer *msg; 44 struct spi_device *spi; 45 unsigned int num_msgs; 46 struct spi_message m; 47 u32 size; 48 int ret; 49 50 /* Check for a valid command */ 51 if (_IOC_TYPE(cmd) != PENCTRL_IOC_MAGIC) 52 return -ENOTTY; 53 54 if (_IOC_NR(cmd) > PENCTRL_IOC_MAXNR) 55 return -ENOTTY; 56 57 if (((_IOC_DIR(cmd) & _IOC_READ)) && !access_ok(in_arg, _IOC_SIZE(cmd))) 58 return -EFAULT; 59 60 if (((_IOC_DIR(cmd) & _IOC_WRITE)) && !access_ok(in_arg, _IOC_SIZE(cmd))) 61 return -EFAULT; 62 63 /* Get a reference to the SPI device */ 64 penctrl = filp->private_data; 65 if (!penctrl) 66 return -ESHUTDOWN; 67 68 spi = spi_dev_get(penctrl->spi); 69 if (!spi) 70 return -ESHUTDOWN; 71 72 /* Verify and prepare SPI message */ 73 size = _IOC_SIZE(cmd); 74 num_msgs = size / sizeof(struct penctrl_spi_xfer); 75 if (num_msgs > 2 || size == 0 || size % sizeof(struct penctrl_spi_xfer)) { 76 ret = -EINVAL; 77 goto out_unlock; 78 } 79 msg = memdup_user((struct penctrl_spi_xfer *)arg, size); 80 if (IS_ERR(msg)) { 81 ret = PTR_ERR(msg); 82 goto out_unlock; 83 } 84 if (msg->len > PENCTRL_MAX_MSG_LEN) { 85 ret = -EINVAL; 86 goto out_unlock; 87 } 88 89 t[0].tx_buf = tx_buf; 90 t[0].len = msg->len; > 91 if (copy_from_user(tx_buf, (void __user *)msg->tx_buf, msg->len)) { 92 ret = -EFAULT; 93 goto out_unlock; 94 } 95 if (num_msgs > 1) { 96 msg++; 97 if (msg->len > PENCTRL_MAX_MSG_LEN) { 98 ret = -EINVAL; 99 goto out_unlock; 100 } 101 t[1].rx_buf = rx_buf; 102 t[1].len = msg->len; 103 } 104 spi_message_init_with_transfers(&m, t, num_msgs); 105 106 /* Perform the transfer */ 107 mutex_lock(&spi_lock); 108 ret = spi_sync(spi, &m); 109 mutex_unlock(&spi_lock); 110 111 if (ret || (num_msgs == 1)) 112 goto out_unlock; 113 114 if (copy_to_user((void __user *)msg->rx_buf, rx_buf, msg->len)) 115 ret = -EFAULT; 116 117 out_unlock: 118 spi_dev_put(spi); 119 return ret; 120 } 121 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel