All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel.org>
To: x86@kernel.org
Cc: Arnd Bergmann <arnd@arndb.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Masami Hiramatsu <mhiramat@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Juergen Gross <jgross@suse.com>,
	"Srivatsa S. Bhat (VMware)" <srivatsa@csail.mit.edu>,
	Alexey Makhalov <amakhalov@vmware.com>,
	VMware PV-Drivers Reviewers <pv-drivers@vmware.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Darren Hart <dvhart@infradead.org>,
	Andy Shevchenko <andy@infradead.org>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org,
	xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org,
	linux-mm@kvack.org
Subject: [PATCH 20/20] x86: olpc: avoid missing-prototype warnings
Date: Tue, 16 May 2023 21:35:49 +0200	[thread overview]
Message-ID: <20230516193549.544673-21-arnd@kernel.org> (raw)
In-Reply-To: <20230516193549.544673-1-arnd@kernel.org>

From: Arnd Bergmann <arnd@arndb.de>

There are two functions in the olpc platform that have no prototype:

arch/x86/platform/olpc/olpc_dt.c:237:13: error: no previous prototype for 'olpc_dt_fixup' [-Werror=missing-prototypes]
arch/x86/platform/olpc/olpc-xo1-pm.c:73:26: error: no previous prototype for 'xo1_do_sleep' [-Werror=missing-prototypes]

The first one should just be marked 'static' as there are no other
callers, while the second one is called from assembler and is
just a false-positive warning that can be silenced by adding a
prototype.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/x86/platform/olpc/olpc_dt.c | 2 +-
 include/linux/olpc-ec.h          | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/x86/platform/olpc/olpc_dt.c b/arch/x86/platform/olpc/olpc_dt.c
index 75e3319e8bee..74ebd6882690 100644
--- a/arch/x86/platform/olpc/olpc_dt.c
+++ b/arch/x86/platform/olpc/olpc_dt.c
@@ -234,7 +234,7 @@ static int __init olpc_dt_compatible_match(phandle node, const char *compat)
 	return 0;
 }
 
-void __init olpc_dt_fixup(void)
+static void __init olpc_dt_fixup(void)
 {
 	phandle node;
 	u32 board_rev;
diff --git a/include/linux/olpc-ec.h b/include/linux/olpc-ec.h
index c4602364e909..3c2891d85c41 100644
--- a/include/linux/olpc-ec.h
+++ b/include/linux/olpc-ec.h
@@ -56,6 +56,8 @@ extern int olpc_ec_sci_query(u16 *sci_value);
 
 extern bool olpc_ec_wakeup_available(void);
 
+asmlinkage int xo1_do_sleep(u8 sleep_state);
+
 #else
 
 static inline int olpc_ec_cmd(u8 cmd, u8 *inbuf, size_t inlen, u8 *outbuf,
-- 
2.39.2


  parent reply	other threads:[~2023-05-16 19:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-16 19:35 [PATCH 00/20] x86: address -Wmissing-prototype warnings Arnd Bergmann
2023-05-16 19:35 ` [PATCH 01/20] x86: move prepare_ftrace_return prototype to header Arnd Bergmann
2023-05-16 21:44   ` Steven Rostedt
2023-05-16 21:44     ` Steven Rostedt
2023-05-16 19:35 ` [PATCH 02/20] x86: ce4100: Mark local functions as 'static' Arnd Bergmann
2023-05-16 19:35 ` [PATCH 03/20] x86: apic: hide unused safe_smp_processor_id on UP Arnd Bergmann
2023-05-16 19:35 ` [PATCH 04/20] x86: avoid unneeded __div64_32 function definition Arnd Bergmann
2023-05-16 19:35 ` [PATCH 05/20] x86: head: add dummy prototype for mk_early_pgtbl_32 Arnd Bergmann
2023-05-18 16:52   ` Alexander Lobakin
2023-05-16 19:35 ` [PATCH 06/20] x86: math-emu: include asm/fpu/regset.h Arnd Bergmann
2023-05-16 19:35 ` [PATCH 07/20] x86: doublefault: avoid missing-prototype warnings Arnd Bergmann
2023-05-16 19:35 ` [PATCH 08/20] x86: highmem: include asm/numa.h for set_highmem_pages_init Arnd Bergmann
2023-05-16 19:35 ` [PATCH 09/20] x86: platform_quirks: include linux/pnp.h for arch_pnpbios_disabled Arnd Bergmann
2023-05-16 19:35 ` [PATCH 10/20] x86: xen: add missing prototypes Arnd Bergmann
2023-05-18 17:28   ` Dave Hansen
2023-05-18 17:28     ` Dave Hansen
2023-05-19 11:04     ` Arnd Bergmann
2023-05-19 11:04       ` Arnd Bergmann
2023-05-16 19:35 ` [PATCH 11/20] x86: entry: add do_SYSENTER_32() prototype Arnd Bergmann
2023-05-16 19:35 ` [PATCH 12/20] x86: qspinlock-paravirt: fix mising-prototype warnings Arnd Bergmann
2023-05-16 19:35 ` [PATCH 13/20] x86: hibernate: declare global functions in suspend.h Arnd Bergmann
2023-05-16 19:35 ` [PATCH 14/20] x86: fbdev: include asm/fb.h as needed Arnd Bergmann
2023-05-16 19:35 ` [PATCH 15/20] x86: mce: add copy_mc_fragile_handle_tail prototype Arnd Bergmann
2023-05-16 19:35 ` [PATCH 16/20] x86: vdso: include vdso/processor.h Arnd Bergmann
2023-05-16 19:35 ` [PATCH 17/20] x86: usercopy: include arch_wb_cache_pmem declaration Arnd Bergmann
2023-05-16 19:35 ` [PATCH 18/20] x86: ioremap: add early_memremap_pgprot_adjust prototype Arnd Bergmann
2023-05-16 19:35 ` [PATCH 19/20] x86: purgatory: include header for warn() declaration Arnd Bergmann
2023-05-16 19:35 ` Arnd Bergmann [this message]
2023-05-18 17:31 ` [PATCH 00/20] x86: address -Wmissing-prototype warnings Dave Hansen
2023-05-18 17:31   ` Dave Hansen
2023-05-18 21:56 ` Dave Hansen
2023-05-18 21:56   ` Dave Hansen
2023-05-19  9:51   ` Andy Shevchenko
2023-05-19  9:51     ` Andy Shevchenko
2023-05-19 12:09   ` Arnd Bergmann
2023-05-19 12:09     ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230516193549.544673-21-arnd@kernel.org \
    --to=arnd@kernel.org \
    --cc=amakhalov@vmware.com \
    --cc=andy@infradead.org \
    --cc=arnd@arndb.de \
    --cc=boris.ostrovsky@oracle.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=dvhart@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=pv-drivers@vmware.com \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srivatsa@csail.mit.edu \
    --cc=tglx@linutronix.de \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.