From: Andrzej Hajda <andrzej.hajda@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
Nirmoy Das <nirmoy.das@intel.com>,
Andi Shyti <andi.shyti@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915/mtl: do not enable render power-gating on MTL
Date: Wed, 17 May 2023 15:59:32 +0200 [thread overview]
Message-ID: <20230517-mtl_disable_render_pg-v1-1-6495eebbfb24@intel.com> (raw)
Multiple CI tests fails with forcewake ack timeouts
if render power gating is enabled.
BSpec 52698 clearly states it should be 0 for MTL.
Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/4983
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
index 908a3d0f2343f4..ebb2373dd73640 100644
--- a/drivers/gpu/drm/i915/gt/intel_rc6.c
+++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
@@ -117,8 +117,9 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
GEN6_RC_CTL_RC6_ENABLE |
GEN6_RC_CTL_EI_MODE(1);
- /* Wa_16011777198 - Render powergating must remain disabled */
- if (IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
+ /* Wa_16011777198 and BSpec 52698 - Render powergating must be off */
+ if (IS_METEORLAKE(gt->i915) ||
+ IS_DG2_GRAPHICS_STEP(gt->i915, G10, STEP_A0, STEP_C0) ||
IS_DG2_GRAPHICS_STEP(gt->i915, G11, STEP_A0, STEP_B0))
pg_enable =
GEN9_MEDIA_PG_ENABLE |
---
base-commit: 01d3dd92d1b71421f6ee85e1bea829e0a917d979
change-id: 20230517-mtl_disable_render_pg-b9f9f1567f9e
Best regards,
--
Andrzej Hajda <andrzej.hajda@intel.com>
next reply other threads:[~2023-05-17 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 13:59 Andrzej Hajda [this message]
2023-05-17 15:12 ` [Intel-gfx] [PATCH] drm/i915/mtl: do not enable render power-gating on MTL Das, Nirmoy
2023-05-17 15:25 ` Vivi, Rodrigo
2023-05-17 15:36 ` Das, Nirmoy
2023-05-17 20:09 ` Rodrigo Vivi
2023-05-18 14:04 ` Andi Shyti
2023-05-18 14:50 ` [Intel-gfx] [PATCH v2] " Andrzej Hajda
2023-05-18 15:09 ` Rodrigo Vivi
2023-05-18 15:33 ` Andrzej Hajda
2023-05-18 16:11 ` Rodrigo Vivi
2023-05-18 16:56 ` Andrzej Hajda
2023-05-17 15:27 ` [Intel-gfx] [PATCH] " Andrzej Hajda
2023-05-17 19:35 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2023-05-17 21:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: do not enable render power-gating on MTL (rev2) Patchwork
2023-05-18 10:20 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2023-05-18 16:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/mtl: do not enable render power-gating on MTL (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517-mtl_disable_render_pg-v1-1-6495eebbfb24@intel.com \
--to=andrzej.hajda@intel.com \
--cc=andi.shyti@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=nirmoy.das@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.