All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
	borisp@nvidia.com, john.fastabend@gmail.com, tariqt@nvidia.com,
	Jakub Kicinski <kuba@kernel.org>,
	Shai Amiram <samiram@nvidia.com>
Subject: [PATCH net 7/7] tls: rx: strp: don't use GFP_KERNEL in softirq context
Date: Tue, 16 May 2023 18:50:42 -0700	[thread overview]
Message-ID: <20230517015042.1243644-8-kuba@kernel.org> (raw)
In-Reply-To: <20230517015042.1243644-1-kuba@kernel.org>

When receive buffer is small, or the TCP rx queue looks too
complicated to bother using it directly - we allocate a new
skb and copy data into it.

We already use sk->sk_allocation... but nothing actually
sets it to GFP_ATOMIC on the ->sk_data_ready() path.

Users of HW offload are far more likely to experience problems
due to scheduling while atomic. "Copy mode" is very rarely
triggered with SW crypto.

Fixes: 84c61fe1a75b ("tls: rx: do not use the standard strparser")
Tested-by: Shai Amiram <samiram@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 net/tls/tls_sw.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c
index 635b8bf6b937..6e6a7c37d685 100644
--- a/net/tls/tls_sw.c
+++ b/net/tls/tls_sw.c
@@ -2304,10 +2304,14 @@ static void tls_data_ready(struct sock *sk)
 	struct tls_context *tls_ctx = tls_get_ctx(sk);
 	struct tls_sw_context_rx *ctx = tls_sw_ctx_rx(tls_ctx);
 	struct sk_psock *psock;
+	gfp_t alloc_save;
 
 	trace_sk_data_ready(sk);
 
+	alloc_save = sk->sk_allocation;
+	sk->sk_allocation = GFP_ATOMIC;
 	tls_strp_data_ready(&ctx->strp);
+	sk->sk_allocation = alloc_save;
 
 	psock = sk_psock_get(sk);
 	if (psock) {
-- 
2.40.1


  parent reply	other threads:[~2023-05-17  1:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  1:50 [PATCH net 0/7] tls: rx: strp: fix inline crypto offload Jakub Kicinski
2023-05-17  1:50 ` [PATCH net 1/7] tls: rx: device: fix checking decryption status Jakub Kicinski
2023-05-18 15:42   ` Simon Horman
2023-05-17  1:50 ` [PATCH net 2/7] tls: rx: strp: set the skb->len of detached / CoW'ed skbs Jakub Kicinski
2023-05-18 15:44   ` Simon Horman
2023-05-17  1:50 ` [PATCH net 3/7] tls: rx: strp: force mixed decrypted records into copy mode Jakub Kicinski
2023-05-18 15:43   ` Simon Horman
2023-05-17  1:50 ` [PATCH net 4/7] tls: rx: strp: fix determining record length in " Jakub Kicinski
2023-05-18 15:44   ` Simon Horman
2023-05-17  1:50 ` [PATCH net 5/7] tls: rx: strp: factor out copying skb data Jakub Kicinski
2023-05-18 15:45   ` Simon Horman
2023-05-17  1:50 ` [PATCH net 6/7] tls: rx: strp: preserve decryption status of skbs when needed Jakub Kicinski
2023-05-18 15:46   ` Simon Horman
2023-05-17  1:50 ` Jakub Kicinski [this message]
2023-05-18 15:45   ` [PATCH net 7/7] tls: rx: strp: don't use GFP_KERNEL in softirq context Simon Horman
2023-05-19  7:50 ` [PATCH net 0/7] tls: rx: strp: fix inline crypto offload patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230517015042.1243644-8-kuba@kernel.org \
    --to=kuba@kernel.org \
    --cc=borisp@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=samiram@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.