From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: linux-usb@vger.kernel.org
Cc: Yehezkel Bernat <YehezkelShB@gmail.com>,
Michael Jamet <michael.jamet@intel.com>,
Lukas Wunner <lukas@wunner.de>,
Andreas Noever <andreas.noever@gmail.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: [PATCH 1/7] thunderbolt: Check for ring 0 in tb_tunnel_alloc_dma()
Date: Wed, 17 May 2023 11:40:57 +0300 [thread overview]
Message-ID: <20230517084103.45213-1-mika.westerberg@linux.intel.com> (raw)
Ring 0 cannot be used for anything else than control channel messages.
For this reason add a check to tb_tunnel_alloc_dma() and fail if someone
tries to do that.
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
---
drivers/thunderbolt/tunnel.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/thunderbolt/tunnel.c b/drivers/thunderbolt/tunnel.c
index 9099ae73e78f..dd3b5613ad2c 100644
--- a/drivers/thunderbolt/tunnel.c
+++ b/drivers/thunderbolt/tunnel.c
@@ -1452,6 +1452,10 @@ struct tb_tunnel *tb_tunnel_alloc_dma(struct tb *tb, struct tb_port *nhi,
struct tb_path *path;
int credits;
+ /* Ring 0 is reserved for control channel */
+ if (WARN_ON(!receive_ring || !transmit_ring))
+ return NULL;
+
if (receive_ring > 0)
npaths++;
if (transmit_ring > 0)
--
2.39.2
next reply other threads:[~2023-05-17 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 8:40 Mika Westerberg [this message]
2023-05-17 8:40 ` [PATCH 2/7] thunderbolt: Log function name of the called quirk Mika Westerberg
2023-05-17 8:40 ` [PATCH 3/7] thunderbolt: Add debug log for link controller power quirk Mika Westerberg
2023-05-17 8:41 ` [PATCH 4/7] thunderbolt: Allow specifying custom credits for DMA tunnels Mika Westerberg
2023-05-17 8:41 ` [PATCH 5/7] thunderbolt: Add MODULE_DESCRIPTION Mika Westerberg
2023-05-17 8:41 ` [PATCH 6/7] thunderbolt: dma_test: Update MODULE_DESCRIPTION Mika Westerberg
2023-05-17 8:41 ` [PATCH 7/7] thunderbolt: Drop retimer vendor check Mika Westerberg
2023-05-24 6:42 ` [PATCH 1/7] thunderbolt: Check for ring 0 in tb_tunnel_alloc_dma() Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517084103.45213-1-mika.westerberg@linux.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-usb@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=michael.jamet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.