From: Anton Lundin <glance@ac2.se>
To: lvm-devel@redhat.com
Subject: [PATCH] Fix header include for out of tree builds
Date: Wed, 17 May 2023 13:35:58 +0200 [thread overview]
Message-ID: <20230517113557.GD18946@accum.se> (raw)
In-Reply-To: <ddfeb159-4148-4aae-7760-0556ca3cda1d@redhat.com>
On 17 May, 2023 - Zdenek Kabelac wrote:
> Dne 16. 05. 23 v 18:05 Anton Lundin napsal(a):
> > The relative include didn't match up for out of tree builds. The
> > build tree include directory is in the include paths already.
> >
> > Signed-off-by: Anton Lundin <glance@ac2.se>
> > ---
> >
> > Now the following works:
> > $ mkdir lvm2-build
> > $ cd lvm2-build
> > $ ../lvm2/configure
>
> Hi
>
> Your bug is actually in this command:
>
> configure --srcdir=XXXXX
>
> > $ make
> >
>
> Otherwise srcdir is located in your builddir and you would actually get more
> errors in various parts of lvmb building - as we tend to use $(srcdir)
> inside makefiles..
I might be misunderstanding you. Are your comment about the fix or the
example on now to trigger the bug?
Just running configure from another directory will set srcdir
automatically. At least in any kind of modern auto-tools.
//Anton
next prev parent reply other threads:[~2023-05-17 11:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 16:05 [PATCH] Fix header include for out of tree builds Anton Lundin
2023-05-17 10:29 ` Zdenek Kabelac
2023-05-17 11:35 ` Anton Lundin [this message]
2023-05-17 11:41 ` Zdenek Kabelac
2023-05-17 11:50 ` Anton Lundin
2023-05-17 12:09 ` Zdenek Kabelac
2023-05-17 14:33 ` Zdenek Kabelac
2023-06-02 17:30 ` Anton Lundin
2023-06-05 13:58 ` Zdenek Kabelac
-- strict thread matches above, loose matches on Subject: below --
2023-05-16 16:09 Anton Lundin
2023-05-16 16:20 Anton Lundin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230517113557.GD18946@accum.se \
--to=glance@ac2.se \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.