From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11CBCC77B7A for ; Wed, 17 May 2023 21:04:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229591AbjEQVEy (ORCPT ); Wed, 17 May 2023 17:04:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229843AbjEQVEx (ORCPT ); Wed, 17 May 2023 17:04:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C38FF420E for ; Wed, 17 May 2023 14:04:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5A05264AF2 for ; Wed, 17 May 2023 21:04:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A990FC433D2; Wed, 17 May 2023 21:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1684357490; bh=L945BpKMLk65cYn7dZGc3sLJU551iQUxV6a6bSEVcgM=; h=Date:To:From:Subject:From; b=PMGd0u9ol3+ITa++Fmgvv7yOpJHM3IFE5kT7dFwmDtvI84oEKFIvkEFjfoHC8aEGh 6Fam8H/NP0jbLvhp/6tCPzjoPYEx3d166XExo78Tq/KtqcqJLaap1olBLobHciw3Y9 6TEJix5C6CRT+z6AhTbDSfQ7zWpj8M3IwdPZ9sto= Date: Wed, 17 May 2023 14:04:50 -0700 To: mm-commits@vger.kernel.org, will@kernel.org, tsbogend@alpha.franken.de, tj@kernel.org, tglx@linutronix.de, rafael@kernel.org, peterz@infradead.org, pavel@ucw.cz, paul@paul-moore.com, palmer@dabbelt.com, mpe@ellerman.id.au, monstr@monstr.eu, mingo@redhat.com, longman@redhat.com, linux@armlinux.org.uk, hca@linux.ibm.com, eparis@redhat.com, dennis@kernel.org, deller@gmx.de, cl@linux.com, catalin.marinas@arm.com, boqun.feng@gmail.com, arnd@arndb.de, akpm@linux-foundation.org From: Andrew Morton Subject: + panic-make-function-declarations-visible.patch added to mm-nonmm-unstable branch Message-Id: <20230517210450.A990FC433D2@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: panic: make function declarations visible has been added to the -mm mm-nonmm-unstable branch. Its filename is panic-make-function-declarations-visible.patch This patch will shortly appear at https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/panic-make-function-declarations-visible.patch This patch will later appear in the mm-nonmm-unstable branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next via the mm-everything branch at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and is updated there every 2-3 working days ------------------------------------------------------ From: Arnd Bergmann Subject: panic: make function declarations visible Date: Wed, 17 May 2023 15:10:56 +0200 A few panic() related functions have a global definition but not declaration, which causes a warning with W=1: kernel/panic.c:710:6: error: no previous prototype for '__warn_printk' [-Werror=missing-prototypes] kernel/panic.c:756:24: error: no previous prototype for '__stack_chk_fail' [-Werror=missing-prototypes] kernel/exit.c:1917:32: error: no previous prototype for 'abort' [-Werror=missing-prototypes] __warn_printk() is called both as a global function when CONFIG_BUG is enabled, and as a local function in other configs. The other two here are called indirectly from generated or assembler code. Add prototypes for all of these. Link: https://lkml.kernel.org/r/20230517131102.934196-9-arnd@kernel.org Signed-off-by: Arnd Bergmann Cc: Boqun Feng Cc: Catalin Marinas Cc: Christoph Lameter Cc: Dennis Zhou Cc: Eric Paris Cc: Heiko Carstens Cc: Helge Deller Cc: Ingo Molnar Cc: Michael Ellerman Cc: Michal Simek Cc: Palmer Dabbelt Cc: Paul Moore Cc: Pavel Machek Cc: Peter Zijlstra Cc: Rafael J. Wysocki Cc: Russell King Cc: Tejun Heo Cc: Thomas Bogendoerfer Cc: Thomas Gleixner Cc: Waiman Long Cc: Will Deacon Signed-off-by: Andrew Morton --- include/asm-generic/bug.h | 5 +++-- include/linux/panic.h | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) --- a/include/asm-generic/bug.h~panic-make-function-declarations-visible +++ a/include/asm-generic/bug.h @@ -87,10 +87,12 @@ struct bug_entry { * * Use the versions with printk format strings to provide better diagnostics. */ -#ifndef __WARN_FLAGS extern __printf(4, 5) void warn_slowpath_fmt(const char *file, const int line, unsigned taint, const char *fmt, ...); +extern __printf(1, 2) void __warn_printk(const char *fmt, ...); + +#ifndef __WARN_FLAGS #define __WARN() __WARN_printf(TAINT_WARN, NULL) #define __WARN_printf(taint, arg...) do { \ instrumentation_begin(); \ @@ -98,7 +100,6 @@ void warn_slowpath_fmt(const char *file, instrumentation_end(); \ } while (0) #else -extern __printf(1, 2) void __warn_printk(const char *fmt, ...); #define __WARN() __WARN_FLAGS(BUGFLAG_TAINT(TAINT_WARN)) #define __WARN_printf(taint, arg...) do { \ instrumentation_begin(); \ --- a/include/linux/panic.h~panic-make-function-declarations-visible +++ a/include/linux/panic.h @@ -32,6 +32,9 @@ extern int sysctl_panic_on_stackoverflow extern bool crash_kexec_post_notifiers; +extern void __stack_chk_fail(void); +void abort(void); + /* * panic_cpu is used for synchronizing panic() and crash_kexec() execution. It * holds a CPU number which is executing panic() currently. A value of _ Patches currently in -mm which might be from arnd@arndb.de are radix-tree-move-declarations-to-header.patch decompressor-provide-missing-prototypes.patch kasan-add-kasan_tag_mismatch-prototype.patch kasan-use-internal-prototypes-matching-gcc-13-builtins.patch mm-percpu-unhide-pcpu_embed_first_chunk-prototype.patch mm-page_poison-always-declare-__kernel_map_pages-function.patch mm-sparse-mark-populate_section_memmap-static.patch lib-devmem_is_allowed-include-linux-ioh.patch locking-add-lockevent_read-prototype.patch panic-hide-unused-global-functions.patch panic-make-function-declarations-visible.patch kunit-include-debugfs-header-file.patch init-consolidate-prototypes-in-linux-inith.patch init-move-cifs_root_data-prototype-into-linux-mounth.patch thread_info-move-function-declarations-to-linux-thread_infoh.patch time_namespace-always-provide-arch_get_vdso_data-prototype-for-vdso.patch