From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: Christoph Hellwig <hch@infradead.org>,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH vhost v9 10/12] virtio_ring: correct the expression of the description of virtqueue_resize()
Date: Thu, 18 May 2023 10:00:46 -0400 [thread overview]
Message-ID: <20230518082612-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1684411970.7875407-2-xuanzhuo@linux.alibaba.com>
On Thu, May 18, 2023 at 08:12:50PM +0800, Xuan Zhuo wrote:
> On Wed, 17 May 2023 10:22:47 +0800, Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> > Modify the "useless" to a more accurate "unused".
> >
> > Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
> > Acked-by: Jason Wang <jasowang@redhat.com>
>
>
> Hi Michael,
>
> Currently, we have to discuss a few cases regarding dma-premapped. Can you
> merge the three patches behind this (including this one)? These have nothing to
> do with dma-premapped.
>
> Should I post a new patch set separately?
>
> Thanks.
Please do.
>
>
>
> > ---
> > drivers/virtio/virtio_ring.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> > index 42730c4ecdc5..c90160d2d280 100644
> > --- a/drivers/virtio/virtio_ring.c
> > +++ b/drivers/virtio/virtio_ring.c
> > @@ -2734,7 +2734,7 @@ EXPORT_SYMBOL_GPL(vring_create_virtqueue_dma);
> > * virtqueue_resize - resize the vring of vq
> > * @_vq: the struct virtqueue we're talking about.
> > * @num: new ring num
> > - * @recycle: callback for recycle the useless buffer
> > + * @recycle: callback to recycle unused buffers
> > *
> > * When it is really necessary to create a new vring, it will set the current vq
> > * into the reset state. Then call the passed callback to recycle the buffer
> > --
> > 2.32.0.3.g01195cf9f
> >
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-05-18 14:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 2:22 [PATCH vhost v9 00/12] virtio core prepares for AF_XDP Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 01/12] virtio_ring: put mapping error check in vring_map_one_sg Xuan Zhuo
2023-05-18 6:51 ` Jason Wang
2023-05-23 6:02 ` Christoph Hellwig
2023-05-17 2:22 ` [PATCH vhost v9 02/12] virtio_ring: simplify the reference of desc state inside detach_buf_split() Xuan Zhuo
2023-05-18 6:51 ` Jason Wang
2023-05-17 2:22 ` [PATCH vhost v9 03/12] virtio_ring: check use_dma_api before unmap desc for indirect Xuan Zhuo
2023-05-18 6:51 ` Jason Wang
2023-05-17 2:22 ` [PATCH vhost v9 04/12] virtio_ring: virtqueue_add() support premapped Xuan Zhuo
2023-05-18 6:51 ` Jason Wang
2023-05-23 6:03 ` Christoph Hellwig
2023-05-23 7:19 ` Michael S. Tsirkin
2023-05-24 3:22 ` Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 05/12] virtio_ring: split: virtqueue_add_split() " Xuan Zhuo
2023-05-18 6:51 ` Jason Wang
2023-05-18 7:11 ` Michael S. Tsirkin
2023-05-18 7:33 ` Xuan Zhuo
2023-05-18 7:54 ` Jason Wang
2023-05-18 7:56 ` Xuan Zhuo
2023-05-18 8:57 ` Jason Wang
2023-05-18 9:18 ` Xuan Zhuo
2023-05-18 8:29 ` Michael S. Tsirkin
2023-05-18 8:50 ` Xuan Zhuo
2023-05-18 9:41 ` Michael S. Tsirkin
2023-05-18 8:57 ` Jason Wang
2023-05-18 9:14 ` Xuan Zhuo
2023-05-18 9:49 ` Michael S. Tsirkin
2023-05-18 12:20 ` Xuan Zhuo
2023-05-18 12:22 ` Xuan Zhuo
2023-05-18 17:12 ` Michael S. Tsirkin
2023-05-19 3:27 ` Xuan Zhuo
2023-05-19 3:39 ` Jason Wang
2023-05-19 3:38 ` Jason Wang
2023-05-18 9:44 ` Michael S. Tsirkin
2023-05-18 9:24 ` Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 06/12] virtio_ring: packed: virtqueue_add_packed() " Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 07/12] virtio_ring: introduce virtqueue_add_outbuf_premapped() Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 08/12] virtio_ring: introduce virtqueue_add_inbuf_premapped() Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 09/12] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 10/12] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo
2023-05-18 12:12 ` Xuan Zhuo
2023-05-18 14:00 ` Michael S. Tsirkin [this message]
2023-05-17 2:22 ` [PATCH vhost v9 11/12] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo
2023-05-17 2:22 ` [PATCH vhost v9 12/12] virtio_ring: introduce virtqueue_reset() Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518082612-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=hch@infradead.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.