From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Nikishkin <vladimir@nikishkin.pw>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com,
razor@blackwall.org, idosch@nvidia.com, liuhangbin@gmail.com,
eyal.birger@gmail.com, jtoppins@redhat.com
Subject: Re: [PATCH iproute2-next v4] ip-link: add support for nolocalbypass in vxlan
Date: Thu, 18 May 2023 08:49:08 -0700 [thread overview]
Message-ID: <20230518084908.7c0e14d4@hermes.local> (raw)
In-Reply-To: <20230518134601.17873-1-vladimir@nikishkin.pw>
On Thu, 18 May 2023 21:46:01 +0800
Vladimir Nikishkin <vladimir@nikishkin.pw> wrote:
> + if (tb[IFLA_VXLAN_LOCALBYPASS]) {
> + __u8 localbypass = rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS]);
> +
> + print_bool(PRINT_JSON, "localbypass", NULL, localbypass);
> + if (localbypass) {
> + print_string(PRINT_FP, NULL, "localbypass ", NULL);
> + } else {
> + print_string(PRINT_FP, NULL, "nolocalbypass ", NULL);
> + }
> + }
You don't have to print anything if nolocalbypass. Use presence as
a boolean in JSON.
I.e.
if (tb[IFLA_VXLAN_LOCALBYPASS] &&
rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS])) {
print_bool(PRINT_ANY, "localbypass", "localbypass", true);
}
That is what other options do.
Follows the best practices for changes to existing programs: your
new feature should look like all the others.
next prev parent reply other threads:[~2023-05-18 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 13:46 [PATCH iproute2-next v4] ip-link: add support for nolocalbypass in vxlan Vladimir Nikishkin
2023-05-18 15:49 ` Stephen Hemminger [this message]
2023-05-19 3:50 ` Vladimir Nikishkin
2023-05-19 9:11 ` Andrea Claudi
2023-05-19 16:19 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518084908.7c0e14d4@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=vladimir@nikishkin.pw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.