From: Lee Jones <lee@kernel.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: "Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
"Maximilian Weigand" <mweigand@mweigand.net>
Subject: Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
Date: Thu, 18 May 2023 11:15:45 +0100 [thread overview]
Message-ID: <20230518101545.GF404509@google.com> (raw)
In-Reply-To: <20230510085239.1253896-1-mweigand2017@gmail.com>
On Wed, 10 May 2023, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
I moved this tag to the correct place and ...
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
> ---
> Changes in v2:
> - fix description, replace display_is_black() with backlight_is_black()
> - use backlight_get_brightness() instead of accessing the property
> directly
>
> drivers/video/backlight/lm3630a_bl.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee@kernel.org>
To: Maximilian Weigand <mweigand2017@gmail.com>
Cc: linux-pwm@vger.kernel.org,
"Daniel Thompson" <daniel.thompson@linaro.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Helge Deller" <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Maximilian Weigand" <mweigand@mweigand.net>
Subject: Re: [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank
Date: Thu, 18 May 2023 11:15:45 +0100 [thread overview]
Message-ID: <20230518101545.GF404509@google.com> (raw)
In-Reply-To: <20230510085239.1253896-1-mweigand2017@gmail.com>
On Wed, 10 May 2023, Maximilian Weigand wrote:
> From: Maximilian Weigand <mweigand@mweigand.net>
>
> Use backlight_is_blank() to determine if the led strings should be turned
> off in the update_status() functions of both strings.
>
> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
I moved this tag to the correct place and ...
> Signed-off-by: Maximilian Weigand <mweigand@mweigand.net>
> ---
> Changes in v2:
> - fix description, replace display_is_black() with backlight_is_black()
> - use backlight_get_brightness() instead of accessing the property
> directly
>
> drivers/video/backlight/lm3630a_bl.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Applied, thanks
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2023-05-18 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 8:52 [PATCH v2] backlight: lm3630a: turn off both led strings when display is blank Maximilian Weigand
2023-05-10 16:03 ` Sam Ravnborg
2023-05-10 16:03 ` Sam Ravnborg
2023-05-18 10:15 ` Lee Jones [this message]
2023-05-18 10:15 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230518101545.GF404509@google.com \
--to=lee@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mweigand2017@gmail.com \
--cc=mweigand@mweigand.net \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.